24472 2009-03-09 15:56:49 -0700 history.length does not return number of elements in history list 2010-01-19 11:26:19 -0800 1 1 1 Unclassified WebKit DOM 525.x (Safari 3.2) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 manueldeschamps fishd beidson eric fishd just1gb sam vicki oldest_to_newest 112911 0 manueldeschamps 2009-03-09 15:56:49 -0700 This seems like it is a bug in our implementation. The behavior (previously unspecified) is now spec in http://www.whatwg.org/specs/web-apps/current-work/#dom-history-length Please file a bug. Thanks, Sam On Mar 9, 2009, at 3:41 PM, Manuel Deschamps wrote: Hello guys, It is been while!.. I had a question for you about the History object. In IE and Firefox, history.length returns the number of elements in the history list while in Safari and Opera the same property returns the "index" of the page in the history list. Example: 1) launch browser X 2) go to www.apple.com 3) then go to www.yahoo.com 4) click the back button 5) type javascript:alert(history.length) in IE,FF the value is 2, in Safari 3/4 the value is 1 So my question is, is this a bug in Safari or IE and FF are not following the standard correctly? :) Thanks _________________________________________ Manuel Deschamps | Software Engineer - Yahoo! Mail tel: 408-336-0493 | manueldr@yahoo-inc.com 113196 1 beidson 2009-03-11 10:32:07 -0700 <rdar://problem/6670095> 180302 2 fishd 2010-01-13 11:16:35 -0800 Confirming. This is a bug per spec, and it seems like WebKit really should match IE and FF here. I'm happy to write a patch for this if there are no objections to changing WebKit's behavior. 180305 3 beidson 2010-01-13 11:20:18 -0800 No brainer. Do it. 181333 4 46703 fishd 2010-01-15 12:51:37 -0800 Created attachment 46703 v1 patch 181340 5 46703 beidson 2010-01-15 12:59:30 -0800 Comment on attachment 46703 v1 patch r+ 181381 6 fishd 2010-01-15 14:09:03 -0800 Landed as http://trac.webkit.org/changeset/53346 181409 7 eric 2010-01-15 14:47:18 -0800 Looks like this is failing on Leopard: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r53346%20(9430)/fast/history/history-length-pretty-diff.html I think you already mentioned that in IRC, but wanted to record it here in case you hadn't noticed. 181416 8 eric 2010-01-15 15:19:29 -0800 Darin is not online or in his office. I'm going to roll out this change to fix the builders. He can roll it back in with the test fixed. 181417 9 eric 2010-01-15 15:31:36 -0800 Darin disabled the test in http://trac.webkit.org/changeset/53348 so the builders should roll green. 182157 10 ap 2010-01-18 23:54:46 -0800 *** Bug 14499 has been marked as a duplicate of this bug. *** 182159 11 ap 2010-01-19 00:02:02 -0800 It doesn't look like the patch was rolled out, after all. And the test has been fixed, too. Does the bug need to remain open for some reason? 182162 12 eric 2010-01-19 00:12:39 -0800 This bug should be updated with the revision of the fix, but certainly doesn't need to stay open on my account. :) 182336 13 fishd 2010-01-19 11:26:19 -0800 Yeah, I fixed the test. See https://bugs.webkit.org/show_bug.cgi?id=33749 for details. 46703 2010-01-15 12:51:37 -0800 2010-01-15 12:59:30 -0800 v1 patch len_1.txt text/plain 6462 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzM0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMTUgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo aXN0b3J5Lmxlbmd0aCBkb2VzIG5vdCByZXR1cm4gbnVtYmVyIG9mIGVsZW1lbnRzIGluIGhpc3Rv cnkgbGlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjQ0NzIKKworICAgICAgICBUZXN0OiBmYXN0L2hpc3RvcnkvaGlzdG9yeS1sZW5ndGguaHRtbAor CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OmdldEhp c3RvcnlMZW5ndGgpOgorCiAyMDEwLTAxLTE1ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6 IFdlYkNvcmUvcGFnZS9QYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvUGFnZS5j cHAJKHJldmlzaW9uIDUzMzM0KQorKysgV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zMTgsNyArMzE4LDcgQEAgdm9pZCBQYWdlOjpnb1RvSXRlbShIaXN0b3J5SXRlbSog aXRlbSwgRgogCiBpbnQgUGFnZTo6Z2V0SGlzdG9yeUxlbmd0aCgpCiB7Ci0gICAgcmV0dXJuIG1f YmFja0ZvcndhcmRMaXN0LT5iYWNrTGlzdENvdW50KCkgKyAxOworICAgIHJldHVybiBtX2JhY2tG b3J3YXJkTGlzdC0+YmFja0xpc3RDb3VudCgpICsgMSArIG1fYmFja0ZvcndhcmRMaXN0LT5mb3J3 YXJkTGlzdENvdW50KCk7CiB9CiAKIHZvaWQgUGFnZTo6c2V0R2xvYmFsSGlzdG9yeUl0ZW0oSGlz dG9yeUl0ZW0qIGl0ZW0pCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MzM0MSkKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTAxLTE1ICBE YXJpbiBGaXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaGlzdG9yeS5sZW5ndGggZG9lcyBub3QgcmV0dXJu IG51bWJlciBvZiBlbGVtZW50cyBpbiBoaXN0b3J5IGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NDcyCisKKyAgICAgICAgKiBmYXN0L2hpc3Rv cnkvaGlzdG9yeS1sZW5ndGgtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2hp c3RvcnkvaGlzdG9yeS1sZW5ndGguaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9sb2FkZXIv c3RhdGVvYmplY3RzL2RvY3VtZW50LWRlc3Ryb3llZC1uYXZpZ2F0ZS1iYWNrLWV4cGVjdGVkLnR4 dDogZml4IHVwIHRlc3QgZXhwZWN0YXRpb25zCisgICAgICAgICogZmFzdC9sb2FkZXIvc3RhdGVv YmplY3RzL2RvY3VtZW50LWRlc3Ryb3llZC1uYXZpZ2F0ZS1iYWNrLXdpdGgtZnJhZ21lbnQtc2Ny b2xsLWV4cGVjdGVkLnR4dDogZml4IHVwIHRlc3QgZXhwZWN0YXRpb25zCisKIDIwMTAtMDEtMTUg IEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBPbGl2ZXIgSHVudC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9oaXN0b3J5LWxl bmd0aC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5 L2hpc3RvcnktbGVuZ3RoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvaGlzdG9yeS9oaXN0b3J5LWxlbmd0aC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEgQEAKK1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9oaXN0b3J5 LWxlbmd0aC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9oaXN0 b3J5LWxlbmd0aC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5 L2hpc3RvcnktbGVuZ3RoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzYgQEAKKzxzY3Jp cHQ+CitvbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgaWYgKGxvY2F0aW9uLnNlYXJjaC5zdWJzdHJp bmcoMSkubGVuZ3RoID09IDApIHsKKyAgICBzZXNzaW9uU3RvcmFnZS50ZXN0U3RhZ2UgPSAwOwor ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRV bnRpbERvbmUoKTsKKyAgICB9CisgIH0KKyAgLy8gVGhpcyB0ZXN0IGFkdmFuY2VzIGhpc3Rvcnkg YnkgMiBwYWdlcywgdGhlbiBuYXZpZ2F0ZXMgYmFjayBvbmUsIGFuZAorICAvLyByZWNvcmRzIGhp c3RvcnkubGVuZ3RoLiAgV2UgZXhwZWN0IGhpc3RvcnkubGVuZ3RoIHRvIGluZGljYXRlIHRoZSB0 b3RhbAorICAvLyBsZW5ndGggb2Ygc2Vzc2lvbiBoaXN0b3J5LiAgQXQgdGhlIGVuZCBvZiB0aGUg dGVzdCwgaXQgc2hvdWxkIGJlIDIgZ3JlYXRlcgorICAvLyB0aGFuIGl0IHdhcyBhdCB0aGUgc3Rh cnQgb2YgdGhlIHRlc3QuCisgIHN3aXRjaCAoc2Vzc2lvblN0b3JhZ2UudGVzdFN0YWdlKyspIHsK KyAgY2FzZSAwOgorICAgIHNlc3Npb25TdG9yYWdlLmluaXRpYWxMZW5ndGggPSBoaXN0b3J5Lmxl bmd0aDsKKyAgICBsb2NhdGlvbiA9ICI/YSI7CisgICAgYnJlYWs7CisgIGNhc2UgMToKKyAgICBs b2NhdGlvbiA9ICI/YiI7CisgICAgYnJlYWs7CisgIGNhc2UgMjoKKyAgICBoaXN0b3J5LmJhY2so KTsKKyAgICBicmVhazsKKyAgY2FzZSAzOgorICAgIGlmIChoaXN0b3J5Lmxlbmd0aCA9PSAoc2Vz c2lvblN0b3JhZ2UuaW5pdGlhbExlbmd0aCAtIDApICsgMikKKyAgICAgIGRvY3VtZW50LmJvZHku aW5uZXJIVE1MID0gIlBBU1MiOworICAgIGVsc2UKKyAgICAgIGRvY3VtZW50LmJvZHkuaW5uZXJI VE1MID0gIkZBSUwiOworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgYnJlYWs7CisgIH0KK30K Kzwvc2NyaXB0PgorPGJvZHk+PC9ib2R5PgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIv c3RhdGVvYmplY3RzL2RvY3VtZW50LWRlc3Ryb3llZC1uYXZpZ2F0ZS1iYWNrLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvZG9j dW1lbnQtZGVzdHJveWVkLW5hdmlnYXRlLWJhY2stZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1MzMz NCkKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9kb2N1bWVudC1kZXN0 cm95ZWQtbmF2aWdhdGUtYmFjay1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTQsMTAg KzQsMTAgQEAgQUxFUlQ6IFN0YXRlIHBvcHBlZCAtIEZpcnN0RW50cnkgKHR5cGUgcwogQUxFUlQ6 IFN0YXRlIHBvcHBlZCAtIFNlY29uZEVudHJ5ICh0eXBlIHN0cmluZykKIEFMRVJUOiBOYXZpZ2F0 aW5nIGJhY2suLi4KIG1haW4gZnJhbWUgLSBoYXMgMSBvbnVubG9hZCBoYW5kbGVyKHMpCi1BTEVS VDogSGlzdG9yeSBsZW5ndGggaXMgMgorQUxFUlQ6IEhpc3RvcnkgbGVuZ3RoIGlzIDMKIEFMRVJU OiBMYXN0IHBhdGggY29tcG9uZW50IG9mIGxvY2F0aW9uIGlzIGRvY3VtZW50LWRlc3Ryb3llZC1u YXZpZ2F0ZS1iYWNrLmh0bWw/U2Vjb25kRW50cnlTaG91bGROZXZlckJlUmVhY3RpdmF0ZWQKIG1h aW4gZnJhbWUgLSBoYXMgMSBvbnVubG9hZCBoYW5kbGVyKHMpCi1BTEVSVDogSGlzdG9yeSBsZW5n dGggaXMgMQorQUxFUlQ6IEhpc3RvcnkgbGVuZ3RoIGlzIDMKIEFMRVJUOiBMYXN0IHBhdGggY29t cG9uZW50IG9mIGxvY2F0aW9uIGlzIGRvY3VtZW50LWRlc3Ryb3llZC1uYXZpZ2F0ZS1iYWNrLmh0 bWw/Rmlyc3RFbnRyeVNob3VsZE5ldmVyQmVSZWFjdGl2YXRlZAogQUxFUlQ6IFRlc3QgY29tcGxl dGVkCiBUaGlzIHRlc3Q6CkBAIC0xNiw3ICsxNiw3IEBAIFRoaXMgdGVzdDoKIC1OYXZpZ2F0ZXMg YXdheSB0byBhIG5ldyBkb2N1bWVudCwgd2l0aCB0aGUgb2xkIGRvY3VtZW50IGJlaW5nIGRlc3Ry b3llZC4KIC1OYXZpZ2F0ZXMgYmFjayB0byB0aGUgc3RhdGUgb2JqZWN0IGVudHJpZXMgYW5kIHZl cmlmaWVzIHRoZSBwb3BzdGF0ZSBldmVudCBpcyBub3QgZmlyZWQuCiAKLUhpc3RvcnkgbGVuZ3Ro IGlzIDEKK0hpc3RvcnkgbGVuZ3RoIGlzIDMKIExhc3QgcGF0aCBjb21wb25lbnQgb2YgbG9jYXRp b24gaXMgZG9jdW1lbnQtZGVzdHJveWVkLW5hdmlnYXRlLWJhY2suaHRtbD9GaXJzdEVudHJ5U2hv dWxkTmV2ZXJCZVJlYWN0aXZhdGVkCiBUZXN0IGNvbXBsZXRlZAogCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvZG9jdW1lbnQtZGVzdHJveWVkLW5hdmlnYXRlLWJh Y2std2l0aC1mcmFnbWVudC1zY3JvbGwtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9kb2N1bWVudC1kZXN0cm95ZWQtbmF2aWdh dGUtYmFjay13aXRoLWZyYWdtZW50LXNjcm9sbC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDUzMzM0 KQorKysgTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL2RvY3VtZW50LWRlc3Ry b3llZC1uYXZpZ2F0ZS1iYWNrLXdpdGgtZnJhZ21lbnQtc2Nyb2xsLWV4cGVjdGVkLnR4dAkod29y a2luZyBjb3B5KQpAQCAtNiw3ICs2LDcgQEAgQUxFUlQ6IFN0YXRlIHBvcHBlZCAtIFNlY29uZEVu dHJ5ICh0eXBlIAogQUxFUlQ6IGhhc2hDaGFuZ2VkIC0gTGFzdCBwYXRoIGNvbXBvbmVudCBvZiBs b2NhdGlvbiBpcyBkb2N1bWVudC1kZXN0cm95ZWQtbmF2aWdhdGUtYmFjay13aXRoLWZyYWdtZW50 LXNjcm9sbC5odG1sI1NlY29uZEVudHJ5CiBBTEVSVDogTmF2aWdhdGluZyBiYWNrLi4uCiBtYWlu IGZyYW1lIC0gaGFzIDEgb251bmxvYWQgaGFuZGxlcihzKQotQUxFUlQ6IEhpc3RvcnkgbGVuZ3Ro IGlzIDIKK0FMRVJUOiBIaXN0b3J5IGxlbmd0aCBpcyAzCiBBTEVSVDogTGFzdCBwYXRoIGNvbXBv bmVudCBvZiBsb2NhdGlvbiBpcyBkb2N1bWVudC1kZXN0cm95ZWQtbmF2aWdhdGUtYmFjay13aXRo LWZyYWdtZW50LXNjcm9sbC5odG1sI1NlY29uZEVudHJ5U2hvdWxkTmV2ZXJCZVJlYWN0aXZhdGVk CiBBTEVSVDogaGFzaENoYW5nZWQgLSBMYXN0IHBhdGggY29tcG9uZW50IG9mIGxvY2F0aW9uIGlz IGRvY3VtZW50LWRlc3Ryb3llZC1uYXZpZ2F0ZS1iYWNrLXdpdGgtZnJhZ21lbnQtc2Nyb2xsLmh0 bWwjRmlyc3RFbnRyeVNob3VsZE5ldmVyQmVSZWFjdGl2YXRlZAogQUxFUlQ6IFRlc3QgY29tcGxl dGVkCkBAIC0xNiw3ICsxNiw3IEBAIFRoaXMgdGVzdDoKIC1OYXZpZ2F0ZXMgYXdheSB0byBhIG5l dyBkb2N1bWVudCwgd2l0aCB0aGUgb2xkIGRvY3VtZW50IGJlaW5nIGRlc3Ryb3llZC4KIC1OYXZp Z2F0ZXMgYmFjayB0byB0aGUgc3RhdGUgb2JqZWN0IGVudHJpZXMgYW5kIHZlcmlmaWVzIHRoZSBw b3BzdGF0ZSBldmVudCBpcyBub3QgZmlyZWQuCiAKLUhpc3RvcnkgbGVuZ3RoIGlzIDIKK0hpc3Rv cnkgbGVuZ3RoIGlzIDMKIExhc3QgcGF0aCBjb21wb25lbnQgb2YgbG9jYXRpb24gaXMgZG9jdW1l bnQtZGVzdHJveWVkLW5hdmlnYXRlLWJhY2std2l0aC1mcmFnbWVudC1zY3JvbGwuaHRtbCNTZWNv bmRFbnRyeVNob3VsZE5ldmVyQmVSZWFjdGl2YXRlZAogaGFzaENoYW5nZWQgLSBMYXN0IHBhdGgg Y29tcG9uZW50IG9mIGxvY2F0aW9uIGlzIGRvY3VtZW50LWRlc3Ryb3llZC1uYXZpZ2F0ZS1iYWNr LXdpdGgtZnJhZ21lbnQtc2Nyb2xsLmh0bWwjRmlyc3RFbnRyeVNob3VsZE5ldmVyQmVSZWFjdGl2 YXRlZAogVGVzdCBjb21wbGV0ZWQK