244641 2022-08-31 16:51:22 -0700 [WPE][GTK] Introduce WPE 2.0 API version, and ENABLE_2022_GLIB_API flag to indicate either GTK 4 or WPE 2.0 2022-09-28 10:28:41 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro philn oldest_to_newest 1895343 0 mcatanzaro 2022-08-31 16:51:22 -0700 Introduce WPE 2.0 API version, and ENABLE_2022_GLIB_API flag to indicate either GTK 4 or WPE 2.0 Since there are few users of the WPE 1.1 API, and we don't need to keep it around, WPE 2.0 will simply replace WPE 1.1. In contrast, the WPE 1.0 API is still required until Igalia is ready to phase out libsoup 2. 1895344 1 mcatanzaro 2022-08-31 16:53:54 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3886 1899687 2 ews-feeder 2022-09-19 17:45:23 -0700 Committed 254653@main (b2a6414f90b3): <https://commits.webkit.org/254653@main> Reviewed commits have been landed. Closing PR #3886 and removing active labels. 1900072 3 philn 2022-09-21 02:14:28 -0700 This broke WPE builds where ENABLE_COG is ON BTW. Current cog depends on the 1.1 API. 1900132 4 mcatanzaro 2022-09-21 07:34:16 -0700 I'm bamboozled... how does this option work? It doesn't seem to be used anywhere: $ git grep 'ENABLE(COG)' $ git grep ENABLE_COG cmake/OptionsWPE.cmake: WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_COG PRIVATE ON) cmake/WebKitFeatures.cmake: WEBKIT_OPTION_DEFINE(ENABLE_COG "Toggle Cog browser compilation." PRIVATE OFF) 1901818 5 mcatanzaro 2022-09-28 10:28:41 -0700 Problem was I was searching only under Source/, but ENABLE_COG is used under Tools/. Anyway it doesn't look hard to solve, just needs some attention from the cog developers to decide which branch to use based on the WPE API version.