244624 2022-08-31 12:22:51 -0700 [GLib] Deprecate WebKitSettings enable-frame-flattening 2022-09-01 05:31:11 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=242883 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro yaneti zalan oldest_to_newest 1895245 0 mcatanzaro 2022-08-31 12:22:51 -0700 Deprecate WebKitSettings enable-frame-flattening since the implementation was removed in bug #242883 1895268 1 mcatanzaro 2022-08-31 13:53:39 -0700 We cannot remove the underlying preference from WebPreferences.yaml and WebPreferencesInternal.yaml because it still supports public API in WebKitLegacy/mac/WebView/WebPreferences.mm and WebKitLegacy/mac/WebView/WebView.mm. 1895275 2 mcatanzaro 2022-08-31 14:32:13 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3876 1895328 3 ews-feeder 2022-08-31 16:02:26 -0700 Committed 254014@main (1978c2756325): <https://commits.webkit.org/254014@main> Reviewed commits have been landed. Closing PR #3876 and removing active labels. 1895447 4 yaneti 2022-09-01 03:45:44 -0700 I am not sure I understand the logic here. It marks as deprecated which is OK, but also turns the setting in a noop default to false ? Which would not help evolution which explicitly sets it to true to actually use the now deprecated code Maybe my code comprehension is failing me.. 1895459 5 mcatanzaro 2022-09-01 05:28:58 -0700 That's the patch for the main branch. For the 2.38 branch, I instead committed exactly the patch that you uploaded on Red Hat Bugzilla: https://github.com/WebKit/WebKit/commit/871eeae26321fc4d5f6769887f2aae42200b5a6e And a different deprecation that keeps the setting alive: https://github.com/WebKit/WebKit/commit/a94dc7e25c83a375fd9ac3e73f56c2794336b176 1895460 6 yaneti 2022-09-01 05:31:11 -0700 Ah, thanks, I missed the branch difference. Sorry for the noise