244508 2022-08-29 13:17:18 -0700 New GCC warnings after enabling USE_ANGLE_WEBGL 2022-09-05 13:18:18 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build PC Linux NEW https://bugs.webkit.org/show_bug.cgi?id=244485 InRadar P2 Minor --- 1 mcatanzaro webkit-unassigned dino kbr kkinnunen webkit-bug-importer oldest_to_newest 1894615 0 mcatanzaro 2022-08-29 13:17:18 -0700 I think bug #244485 introduced these GCC warnings: [1447/6412] Building CXX object Source/ThirdParty/ANGLE/CM.../ANGLE.dir/src/libANGLE/renderer/gl/renderergl_utils.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/include/platform/FeaturesGL_autogen.h:13, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/RendererGL.h:20, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/ContextGL.h:14, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp:24: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp: In function ‘void rx::nativegl_gl::InitializeFeatures(const rx::FunctionsGL*, angle::FeaturesGL*)’: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp:2006:48: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] 2006 | !isMesa || isIntel && (Is9thGenIntel(device) || IsGeminiLake(device) || | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2007 | IsCoffeeLake(device) || Is11thGenIntel(device) || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2008 | Is12thGenIntel(device))); | ~~~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/include/platform/Feature.h:19:36: note: in definition of macro ‘ANGLE_FEATURE_CONDITION’ 19 | (set)->feature.enabled = cond; \ | ^~~~ [1467/6412] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/GLES1Renderer.cpp.o /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/GLES1Renderer.cpp: In copy constructor ‘gl::GLES1ShaderState::GLES1ShaderState(const gl::GLES1ShaderState&)’: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/GLES1Renderer.cpp:36:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct gl::GLES1ShaderState’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess] 36 | memcpy(this, &other, sizeof(GLES1ShaderState)); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/GLES1Renderer.cpp:9: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/GLES1Renderer.h:56:8: note: ‘struct gl::GLES1ShaderState’ declared here 56 | struct GLES1ShaderState | ^~~~~~~~~~~~~~~~ [1489/6412] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/State.cpp.o /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/State.cpp:10: warning: ignoring ‘#pragma clang diagnostic’ [-Wunknown-pragmas] 10 | #pragma clang diagnostic ignored "-Wglobal-constructors" | [1490/6412] Building CXX object Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/libANGLE/angletypes.cpp.o /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/angletypes.cpp: In constructor ‘gl::SamplerState::SamplerState()’: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/angletypes.cpp:173:11: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘class gl::SamplerState’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess] 173 | memset(this, 0, sizeof(SamplerState)); | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/angletypes.cpp:9: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/angletypes.h:323:7: note: ‘class gl::SamplerState’ declared here 323 | class SamplerState final | ^~~~~~~~~~~~ 1896379 1 webkit-bug-importer 2022-09-05 13:18:18 -0700 <rdar://problem/99575256>