244386 2022-08-26 02:12:02 -0700 aspect-ratio should work on errored images that have display:block 2022-10-31 10:54:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=245136 BrowserCompat, InRadar P2 Normal --- 1 jaffathecake webkit-unassigned bfulgham cathiechen changseok david esprehn+autocc ews-watchlist glenn karlcow kondapallykalyan pdr sabouhallawa simon.fraser webkit-bug-importer zalan oldest_to_newest 1893941 0 jaffathecake 2022-08-26 02:12:02 -0700 https://github.com/web-platform-tests/wpt/pull/35612 - Safari fails this test, as it seems to force failed images to have a 1:1 aspect ratio. However, there's a test that suggests failed images should ignore aspect-ratio http://wpt.live/css/css-sizing/aspect-ratio/replaced-element-028.html, but I haven't found the spec-text for this. All browsers pass this test, but Chrome & Firefox respect aspect-ratio if the image is display:block or display:inline-block. 1894368 1 karlcow 2022-08-28 19:21:17 -0700 I wonder if it relates to https://drafts.csswg.org/css-sizing-4/#aspect-ratio-automatic 1894369 2 webkit-bug-importer 2022-08-28 19:21:29 -0700 <rdar://problem/99258406> 1894811 3 cathiechen 2022-08-30 08:12:59 -0700 I checked the test in https://github.com/web-platform-tests/wpt/pull/35612 locally, it seems the cases are passed in Release 152 (Safari 16.0, WebKit 17615.1.2.3). It seems the wpt pipeline fails to install Safari Technology Preview. https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=86190&view=logs&jobId=bf8f5026-3d1f-5955-26be-17f9e1ef0bb3 Maybe it's an environmental issue, not specific to the test case? 1894933 4 karlcow 2022-08-30 14:52:30 -0700 Loading locally the test http://wpt.live/css/css-sizing/aspect-ratio/replaced-element-028.html shows that Safari displays the image with a 1:1 aspect ratio by default and I think this is what Jake is pointing. 1895190 5 cathiechen 2022-08-31 09:58:01 -0700 (In reply to Karl Dubost from comment #4) > Loading locally the test > http://wpt.live/css/css-sizing/aspect-ratio/replaced-element-028.html > > shows that Safari displays the image with a 1:1 aspect ratio by default and > I think this is what Jake is pointing. I see... Yes, 1:1 aspect ratio seems not very reasonable. I think I can take a look:) 1895436 6 jaffathecake 2022-09-01 01:25:38 -0700 Safari is passing http://wpt.live/css/css-sizing/aspect-ratio/replaced-element-028.html (as is Chrome and Firefox, although they pass it in a different way). I'm not actually sure what the correct behaviour should be for that test, other than it should ignore the aspect-ratio given by the developer. However, I think the test in https://github.com/web-platform-tests/wpt/pull/35612 is a more obvious fail. Are you sure it's passing for you? It's failing when I try it in Release 152. Another version: https://jsbin.com/zipolaj/2/edit?html,css,output. In Chrome and Firefox, the image uses the aspect ratio provided by the CSS - 2:1. In Safari it uses 1:1. 1895475 7 cathiechen 2022-09-01 07:34:53 -0700 (In reply to Jake Archibald from comment #6) > Safari is passing > http://wpt.live/css/css-sizing/aspect-ratio/replaced-element-028.html (as is > Chrome and Firefox, although they pass it in a different way). I'm not > actually sure what the correct behaviour should be for that test, other than > it should ignore the aspect-ratio given by the developer. Yeah, do we need to file a bug in GitHub to discuss the expected behavior? It seems Chrome and Firefox do not apply aspect-ratio if the error images are with alt. https://jsbin.com/yanocayapi/1/edit?html,css,output > > However, I think the test in > https://github.com/web-platform-tests/wpt/pull/35612 is a more obvious fail. > Are you sure it's passing for you? It's failing when I try it in Release 152. > It passes if I download the test and load it with file:/// > Another version: https://jsbin.com/zipolaj/2/edit?html,css,output. > > In Chrome and Firefox, the image uses the aspect ratio provided by the CSS - > 2:1. In Safari it uses 1:1. Yeah, it's 1:1. Again, if I download the test and load it with file:///, it's 2:1. Something might go wrong if trying to download the error image from network. 1895480 8 jaffathecake 2022-09-01 08:09:24 -0700 Ohhh, that's fun! I bet it avoids going into an errored state as it leaks details about the file system. 1896859 9 462186 cathiechen 2022-09-07 12:15:18 -0700 Created attachment 462186 WIP-patch 1898207 10 cathiechen 2022-09-13 06:18:04 -0700 Filed a new bug for the file:// and http:// issue:) https://bugs.webkit.org/show_bug.cgi?id=245136 I think the cases in replaced-element-028.html and replaced-element-036.html are correct. Explained a little in GitHub. https://github.com/web-platform-tests/wpt/pull/35612#issuecomment-1245268327 462186 2022-09-07 12:15:18 -0700 2022-09-07 13:42:05 -0700 WIP-patch aspect-ratio-vs-error-img-wip-patch.diff text/plain 1894 cathiechen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW1hZ2UuY3BwCmluZGV4IDYyNGNhNDMxMmVk ZS4uY2E4NTJiODA1Nzc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVySW1hZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5j cHAKQEAgLTQxOCwxOSArNDE4LDE5IEBAIHZvaWQgUmVuZGVySW1hZ2U6OnNldEltYWdlRGV2aWNl UGl4ZWxSYXRpbyhmbG9hdCBmYWN0b3IpCiAgICAgaW50cmluc2ljU2l6ZUNoYW5nZWQoKTsKIH0K IAotYm9vbCBSZW5kZXJJbWFnZTo6aXNTaG93aW5nTWlzc2luZ09ySW1hZ2VFcnJvcigpIGNvbnN0 Citib29sIFJlbmRlckltYWdlOjpzaG91bGREaXNwbGF5QnJva2VuSW1hZ2VJY29uKCkgY29uc3QK IHsKLSAgICByZXR1cm4gIWltYWdlUmVzb3VyY2UoKS5jYWNoZWRJbWFnZSgpIHx8IGltYWdlUmVz b3VyY2UoKS5lcnJvck9jY3VycmVkKCk7CisgICAgcmV0dXJuIGltYWdlUmVzb3VyY2UoKS5lcnJv ck9jY3VycmVkKCk7CiB9CiAKLWJvb2wgUmVuZGVySW1hZ2U6OmlzU2hvd2luZ0FsdFRleHQoKSBj b25zdAorYm9vbCBSZW5kZXJJbWFnZTo6aXNTaG93aW5nTWlzc2luZ09ySW1hZ2VFcnJvcigpIGNv bnN0CiB7Ci0gICAgcmV0dXJuIGlzU2hvd2luZ01pc3NpbmdPckltYWdlRXJyb3IoKSAmJiAhbV9h bHRUZXh0LmlzRW1wdHkoKTsKKyAgICByZXR1cm4gIWltYWdlUmVzb3VyY2UoKS5jYWNoZWRJbWFn ZSgpIHx8IHNob3VsZERpc3BsYXlCcm9rZW5JbWFnZUljb24oKTsKIH0KIAotYm9vbCBSZW5kZXJJ bWFnZTo6c2hvdWxkRGlzcGxheUJyb2tlbkltYWdlSWNvbigpIGNvbnN0Citib29sIFJlbmRlcklt YWdlOjppc1Nob3dpbmdBbHRUZXh0KCkgY29uc3QKIHsKLSAgICByZXR1cm4gaW1hZ2VSZXNvdXJj ZSgpLmVycm9yT2NjdXJyZWQoKTsKKyAgICByZXR1cm4gaXNTaG93aW5nTWlzc2luZ09ySW1hZ2VF cnJvcigpICYmICFtX2FsdFRleHQuaXNFbXB0eSgpOwogfQogCiBib29sIFJlbmRlckltYWdlOjpo YXNOb25CaXRtYXBJbWFnZSgpIGNvbnN0CkBAIC04NzEsMTMgKzg3MSwxMyBAQCB2b2lkIFJlbmRl ckltYWdlOjpjb21wdXRlSW50cmluc2ljUmF0aW9JbmZvcm1hdGlvbihGbG9hdFNpemUmIGludHJp bnNpY1NpemUsIGRvdQogICAgIH0KIAogICAgIC8vIERvbid0IGNvbXB1dGUgYW4gaW50cmluc2lj IHJhdGlvIHRvIHByZXNlcnZlIGhpc3RvcmljYWwgV2ViS2l0IGJlaGF2aW9yIGlmIHdlJ3JlIHBh aW50aW5nIGFsdCB0ZXh0IGFuZC9vciBhIGJyb2tlbiBpbWFnZS4KLSAgICBpZiAoc2hvdWxkRGlz cGxheUJyb2tlbkltYWdlSWNvbigpKSB7Ci0gICAgICAgIGlmIChzZXR0aW5ncygpLmFzcGVjdFJh dGlvT2ZJbWdGcm9tV2lkdGhBbmRIZWlnaHRFbmFibGVkKCkKLSAgICAgICAgICAgICYmIHN0eWxl KCkuYXNwZWN0UmF0aW9UeXBlKCkgPT0gQXNwZWN0UmF0aW9UeXBlOjpBdXRvQW5kUmF0aW8gJiYg IWlzU2hvd2luZ0FsdFRleHQoKSkKLSAgICAgICAgICAgIGludHJpbnNpY1JhdGlvID0gc3R5bGUo KS5sb2dpY2FsQXNwZWN0UmF0aW8oKTsKLSAgICAgICAgZWxzZQorICAgIGlmIChpc0ltYWdlKCkg JiYgaXNTaG93aW5nTWlzc2luZ09ySW1hZ2VFcnJvcigpKSB7CisgICAgICAgIGlmICghbV9hbHRU ZXh0LmlzRW1wdHkoKSkgeworICAgICAgICAgICAgaW50cmluc2ljUmF0aW8gPSAwOworICAgICAg ICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAgIGlmICghc3R5bGUoKS5oYXNBc3BlY3RS YXRpbygpKQogICAgICAgICAgICAgaW50cmluc2ljUmF0aW8gPSAxOwotICAgICAgICByZXR1cm47 CiAgICAgfQogfQogCg==