24436 2009-03-06 15:46:16 -0800 With ACCELERATED_COMPOSITING turned on ASSERT in RenderLayer::updateClipRects() 2009-03-24 14:03:47 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin simon.fraser simon.fraser oldest_to_newest 112670 0 cmarrin 2009-03-06 15:46:16 -0800 Turn on ACCELERATED_COMPOSITING, build debug and run the attached test case. You should see an assert at: RenderLayer.cpp:2432 112671 1 28374 cmarrin 2009-03-06 15:47:00 -0800 Created attachment 28374 Test case showing bug 114884 2 simon.fraser 2009-03-23 17:11:42 -0700 The problem here is that we use different clip rect roots for painting, and for hit testing. For painting, every composited layer is a clipping root. For hit testing (which happens in software), only elements with transforms are clipping roots. For now, I think the best solution is to compute temporary clip rects any time we're hit testing in a page with composited content. 114887 3 28879 simon.fraser 2009-03-23 17:20:26 -0700 Created attachment 28879 Patch 114892 4 28879 darin 2009-03-23 17:34:25 -0700 Comment on attachment 28879 Patch Is this going to increase the stack size used by hitTestLayer? How big is ClipRects? I don't think it's good to name a boolean "temporaryClipRects". That sounds like the name of a variable that stores somre rects in it. 114899 5 simon.fraser 2009-03-23 18:27:53 -0700 (In reply to comment #4) > (From update of attachment 28879 [review]) > Is this going to increase the stack size used by hitTestLayer? How big is > ClipRects? ClipRects is 3 * sizeof(IntRect) + 4 bytes. I think it's OK to use more stack space for hit testing transformed elements, since they are uncommon and having deeply nested ones will be very rare. > I don't think it's good to name a boolean "temporaryClipRects". That sounds > like the name of a variable that stores somre rects in it. Agreed, I can fix. 114985 6 28879 hyatt 2009-03-24 11:44:34 -0700 Comment on attachment 28879 Patch r=me 115040 7 simon.fraser 2009-03-24 14:03:47 -0700 http://trac.webkit.org/changeset/41951 28374 2009-03-06 15:47:00 -0800 2009-03-06 15:47:00 -0800 Test case showing bug card_flip.html text/html 3569 cmarrin PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgU3RyaWN0Ly9FTiIK ICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvc3RyaWN0LmR0ZCI+Cgo8aHRtbCBsYW5nPSJl biI+CiAgPGhlYWQ+CiAgICA8dGl0bGU+Q2FyZCBGbGlwPC90aXRsZT4KICAgIDxtZXRhIGh0dHAt ZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4K ICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBjb250ZW50PSJpbml0aWFsLXNjYWxlPTEuMCwgbWlu aW11bS1zY2FsZT0xLjAsIG1heGltdW0tc2NhbGU9MS4wIj4KICAgIDxzdHlsZSB0eXBlPSJ0ZXh0 L2NzcyIgbWVkaWE9InNjcmVlbiI+CgogICAgICBib2R5IHsKICAgICAgICBtYXJnaW46IDA7CiAg ICAgIH0KCiAgICAgICNjb250YWluZXIgewogICAgICAgIGhlaWdodDogMzU2cHg7CiAgICAgICAg d2lkdGg6IDMyMHB4OwogICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoNTYsMTA4LDE3OSwg MC41KTsKICAgICAgICAtd2Via2l0LXRhcC1oaWdobGlnaHQtY29sb3I6IHJnYmEoMCwwLDAsMCk7 CiAgICAgICAgLXdlYmtpdC1wZXJzcGVjdGl2ZTogNjAwOwogICAgICB9CgogICAgICAuY2FyZCB7 CiAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgIGhlaWdodDogMzAwcHg7CiAgICAg ICAgd2lkdGg6IDIwMHB4OwogICAgICAgIGxlZnQ6IDYwcHg7CiAgICAgICAgdG9wOiAyOHB4Owog ICAgICAgIC8qCiAgICAgICAgCiAgICAgICAgVGhpcyBtYWtlcyBzdXJlIHRoZSBlbGVtZW50IHdl IHRhcmdldCwgaW4gdGhpcyBjYXNlIHRoZSBjYXJkLAogICAgICAgIGxpdmVzIGNvcnJlY3RseSBp biB0aGUgM0Qgc3BhY2UgYW5kIHRoYXQgdHJhbnNmb3JtcyB3aWxsIGJlCiAgICAgICAgYXBwbGll ZCBhcyBzdWNoLgogICAgICAgIAogICAgICAgICovCiAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm0t c3R5bGU6IHByZXNlcnZlLTNkOwogICAgICAgIC8qCiAgICAgICAgCiAgICAgICAgVGhpcyBpcyB3 aGVyZSB3ZSBkZWZpbmUgdGhlIGNvcmUgcHJvcGVydGllcyBvZiB0aGUgdHJhbnNpdGlvbi4KICAg ICAgICBJbiB0aGlzIGNhc2UsIHdlIHdhbnQgdG8gaGF2ZSBhbiBhbmltYXRpb24gaGFwcGVuaW5n IHdoZW4gY2hhbmdpbmcKICAgICAgICB0aGUgLXdlYmtpdC10cmFuc2Zvcm0gcHJvcGVydHkgZHVy aW5nIDEuNSBzZWNvbmRzLgogICAgICAgIAogICAgICAgICovCiAgICAgICAgLXdlYmtpdC10cmFu c2l0aW9uLXByb3BlcnR5OiAtd2Via2l0LXRyYW5zZm9ybTsKICAgICAgICAtd2Via2l0LXRyYW5z aXRpb24tZHVyYXRpb246IDEuNXM7CiAgICAgIH0KCiAgICAgIC5jYXJkLmZsaXBwZWQgewogICAg ICAgIC8qCiAgICAgICAgCiAgICAgICAgT25jZSB0aGUgY2FyZCBoYXMgYm90aCB0aGUgImNhcmQi IGFuZCAiZmxpcHBlZCIgY2xhc3NlcyBzZXQgb24gaXQsCiAgICAgICAgdGhlIHRyYW5zZm9ybSB3 aWxsIGJlIGNoYW5nZWQgdG8gMTgwIGRlZ3JlZXMgaW4gdGhlIHktYXhpcy4gQmVjYXVzZQogICAg ICAgIHdlIHNldCAiLXdlYmtpdC10cmFuc2l0aW9uLXByb3BlcnR5IiB0byAiLXdlYmtpdC10cmFu c2Zvcm0iIGZvciB0aGUKICAgICAgICAiY2FyZCIgY2xhc3MgYWxyZWFkeSwgYW4gYW5pbWF0ZWQg dHJhbnNpdGlvbiB3aWxsIGJlIHBlcmZvcm1lZCB0bwogICAgICAgIHRvZ2dsZSBiZXR3ZWVuIHRo ZSByZWd1bGFyIGFuZCBmbGlwcGVkIHJvdGF0aW9uIHN0YXRlcy4gCiAgICAgICAgCiAgICAgICAg Ki8KICAgICAgICAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlWSgxODBkZWcpOwogICAgICB9Cgog ICAgICAuZmFjZSB7CiAgICAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgICAgIGhlaWdodDog MzAwcHg7CiAgICAgICAgd2lkdGg6IDIwMHB4OwogICAgICAgIC13ZWJraXQtYm9yZGVyLXJhZGl1 czogMTBweDsKICAgICAgICAtd2Via2l0LWJveC1zaGFkb3c6IDBweCAwcHggNnB4ICMwMDA7CiAg ICAgICAgLXdlYmtpdC11c2VyLXNlbGVjdDogbm9uZTsKICAgICAgICAvKgogICAgICAgIAogICAg ICAgIE5vdyB3ZSBtYWtlIHN1cmUgdGhhdCB0aGUgImJhY2siIG9mIHRoZSBjYXJkIGRvZXMgbm90 IHNob3cgd2hlbiBhIGNhcmQKICAgICAgICBpcyBmbGlwcGVkLiBUaGUgYmFjayBvZiB0aGUgY2Fy ZCBpcyB3aGF0IHNob3dzIHdoZW4gYW4gZWxlbWVudCBpcyByb3RhdGVkCiAgICAgICAgYXQgMTgw IGRlZ3JlZXMgYWxvbmcgdGhlIHktYXhpcy4gRXZlbiB0aG91Z2ggd2UgYXJlIG5vdCB1c2luZyB0 cmFuc3BhcmVuY3kKICAgICAgICBpbiB0aGlzIGNhc2UsIHdlIHN0aWxsIG5lZWQgdG8gZGVmaW5l IHRoaXMgcHJvcGVydHkgYXMgdGhlIGNhcmRzIGFyZSBzdGFja2VkCiAgICAgICAgaW4gdGhlIGV4 YWN0IHNhbWUgbG9jYXRpb24gYW5kIHVzaW5nIHRoaXMgcHJvcGVydHkgY2xlYXJseSB0ZWxscyB0 aGUgZW5naW5lCiAgICAgICAgd2hhdCB0byBzaG93LgogICAgICAgIAogICAgICAgICovCiAgICAg ICAgLXdlYmtpdC1iYWNrZmFjZS12aXNpYmlsaXR5OiBoaWRkZW47CiAgICAgIH0KCiAgICAgIC5m YWNlID4gcCB7CiAgICAgICAgbWFyZ2luLXRvcDogNjBweDsKICAgICAgICB0ZXh0LWFsaWduOiBj ZW50ZXI7CiAgICAgICAgZm9udC1zaXplOiA4MHB4OwogICAgICB9CgogICAgICAuZnJvbnQgewog ICAgICAgIGNvbG9yOiByZ2IoNzgsMTUwLDI0OSk7CiAgICAgICAgYmFja2dyb3VuZC1jb2xvcjog cmdiKDM0LDY1LDEwOCk7CiAgICAgIH0KCiAgICAgIC5iYWNrIHsKICAgICAgICBjb2xvcjogcmdi KDM0LDY1LDEwOCk7CiAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiYSg3OCwxNTAsMjQ5LDAu NSk7CiAgICAgICAgLyogRW5zdXJlIHRoZSBiYWNrc2lkZSBpcyBmbGlwcGVkIGFscmVhZHkgKi8K ICAgICAgICAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlWSgxODBkZWcpOwogICAgICB9CgogICAg PC9zdHlsZT4KICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYt OCI+CgogICAgICBmdW5jdGlvbiBmbGlwIChldmVudCkKICAgICAgewogICAgICAgIHZhciBlbGVt ZW50ID0gZXZlbnQuY3VycmVudFRhcmdldDsKICAgICAgICAvLyBzaW1wbHkgdG9nZ2xlIHRoZSBz ZXR0aW5nIG9mIHRoZSAiZmxpcHBlZCIgY2xhc3MKICAgICAgICBlbGVtZW50LmNsYXNzTmFtZSA9 IChlbGVtZW50LmNsYXNzTmFtZSA9PSAnY2FyZCcpID8gJ2NhcmQgZmxpcHBlZCcgOiAnY2FyZCc7 CiAgICAgIH0KCiAgICA8L3NjcmlwdD4KICA8L2hlYWQ+CgogIDxib2R5PgogICAgPGRpdiBpZD0i Y29udGFpbmVyIj4KICAgICAgPGRpdiBjbGFzcz0iY2FyZCIgb25jbGljaz0iZmxpcChldmVudCki PgogICAgICAgIDxkaXYgY2xhc3M9ImZyb250IGZhY2UiPgogICAgICAgICAgPHA+4pmgIOKZpiDi maMg4pmlPC9wPgogICAgICAgIDwvZGl2PgogICAgICAgIDxkaXYgY2xhc3M9ImJhY2sgZmFjZSI+ CiAgICAgICAgICA8cD7imaYg4pmgIOKZpSDimaM8L3A+CiAgICAgICAgPC9kaXY+CiAgICAgIDwv ZGl2PgogICAgPC9kaXY+CiAgPC9ib2R5PgoKPC9odG1sPgo= 28879 2009-03-23 17:20:26 -0700 2009-03-24 11:44:34 -0700 Patch 24436_patch.txt text/plain 2941 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTNhOWUwYy4uOWI2NjljNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAwOS0wMy0yMyAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQ0MzYKKyAgICAgICAgCisgICAgICAgIFdoZW4gY29tcG9zaXRpbmcgaXMgZW5hYmxlZCwg cGFpbnRpbmcgYW5kIGhpdCB0ZXN0aW5nIGVuZCB1cCB1c2luZyBkaWZmZXJlbnQKKyAgICAgICAg Y2xpcHBpbmcgcm9vdHMsIGJlY2F1c2UsIGZvciBwYWludGluZywgZXZlcnkgY29tcG9zaXRlZCBs YXllciBpcyBhIGNsaXBwaW5nIHJvb3QsCisgICAgICAgIGJ1dCBmb3IgaGl0IHRlc3Rpbmcgb25s eSBsYXllcnMgd2l0aCB0cmFuc2Zvcm1zIGFyZS4gVG8gZml4IHRoaXMsIHdlIHVzZQorICAgICAg ICB0ZW1wb3JhcnkgY2xpcCByZWN0cyBmb3IgaGl0IHRlc3RpbmcsIGlmIHRoZSBwYWdlIGlzIGlu IGNvbXBvc2l0aW5nIG1vZGUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmhpdFRlc3RMYXllcik6CisKKzIwMDkt MDMtMjMgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAg UmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8KICAgICAgICAgCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDczMwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCmluZGV4IDZjYTkxNzQuLjUxZmViZTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK QEAgLTIyMjYsMTUgKzIyMjYsMjcgQEAgUmVuZGVyTGF5ZXIqIFJlbmRlckxheWVyOjpoaXRUZXN0 TGF5ZXIoUmVuZGVyTGF5ZXIqIHJvb3RMYXllciwgUmVuZGVyTGF5ZXIqIGNvbnQKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IEhpdFRlc3RpbmdU cmFuc2Zvcm1TdGF0ZSogdHJhbnNmb3JtU3RhdGUsIGRvdWJsZSogek9mZnNldCkKIHsKICAgICAv LyBUaGUgbmF0dXJhbCB0aGluZyB3b3VsZCBiZSB0byBrZWVwIEhpdFRlc3RpbmdUcmFuc2Zvcm1T dGF0ZSBvbiB0aGUgc3RhY2ssIGJ1dCBpdCdzIGJpZywgc28gd2UgaGVhcC1hbGxvY2F0ZS4KKwor ICAgIGJvb2wgdGVtcG9yYXJ5Q2xpcFJlY3RzID0gZmFsc2U7CisjaWYgVVNFKEFDQ0VMRVJBVEVE X0NPTVBPU0lUSU5HKQorICAgIHRlbXBvcmFyeUNsaXBSZWN0cyA9IGNvbXBvc2l0b3IoKS0+aW5D b21wb3NpdGluZ01vZGUoKTsKKyNlbmRpZgogICAgIAogICAgIC8vIEFwcGx5IGEgdHJhbnNmb3Jt IGlmIHdlIGhhdmUgb25lLgogICAgIGlmICh0cmFuc2Zvcm0oKSAmJiAhYXBwbGllZFRyYW5zZm9y bSkgewogICAgICAgICAvLyBNYWtlIHN1cmUgdGhlIHBhcmVudCdzIGNsaXAgcmVjdHMgaGF2ZSBi ZWVuIGNhbGN1bGF0ZWQuCiAgICAgICAgIGlmIChwYXJlbnQoKSkgewotICAgICAgICAgICAgcGFy ZW50KCktPnVwZGF0ZUNsaXBSZWN0cyhyb290TGF5ZXIpOworICAgICAgICAgICAgSW50UmVjdCBj bGlwUmVjdDsKKyAgICAgICAgICAgIGlmICh0ZW1wb3JhcnlDbGlwUmVjdHMpIHsKKyAgICAgICAg ICAgICAgICBDbGlwUmVjdHMgcGFyZW50Q2xpcFJlY3RzOworICAgICAgICAgICAgICAgIHBhcmVu dCgpLT5jYWxjdWxhdGVDbGlwUmVjdHMocm9vdExheWVyLCBwYXJlbnRDbGlwUmVjdHMpOworICAg ICAgICAgICAgICAgIGNsaXBSZWN0ID0gcGFyZW50Q2xpcFJlY3RzLm92ZXJmbG93Q2xpcFJlY3Qo KTsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgcGFyZW50KCktPnVwZGF0 ZUNsaXBSZWN0cyhyb290TGF5ZXIpOworICAgICAgICAgICAgICAgIGNsaXBSZWN0ID0gcGFyZW50 KCktPmNsaXBSZWN0cygpLT5vdmVyZmxvd0NsaXBSZWN0KCk7CisgICAgICAgICAgICB9CiAgICAg ICAgIAogICAgICAgICAgICAgLy8gR28gYWhlYWQgYW5kIHRlc3QgdGhlIGVuY2xvc2luZyBjbGlw IG5vdy4KLSAgICAgICAgICAgIEludFJlY3QgY2xpcFJlY3QgPSBwYXJlbnQoKS0+Y2xpcFJlY3Rz KCktPm92ZXJmbG93Q2xpcFJlY3QoKTsKICAgICAgICAgICAgIGlmICghY2xpcFJlY3QuY29udGFp bnMoaGl0VGVzdFBvaW50KSkKICAgICAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgfQpA QCAtMjI5NCw3ICsyMzA2LDcgQEAgUmVuZGVyTGF5ZXIqIFJlbmRlckxheWVyOjpoaXRUZXN0TGF5 ZXIoUmVuZGVyTGF5ZXIqIHJvb3RMYXllciwgUmVuZGVyTGF5ZXIqIGNvbnQKICAgICBJbnRSZWN0 IGJnUmVjdDsKICAgICBJbnRSZWN0IGZnUmVjdDsKICAgICBJbnRSZWN0IG91dGxpbmVSZWN0Owot ICAgIGNhbGN1bGF0ZVJlY3RzKHJvb3RMYXllciwgaGl0VGVzdFJlY3QsIGxheWVyQm91bmRzLCBi Z1JlY3QsIGZnUmVjdCwgb3V0bGluZVJlY3QpOworICAgIGNhbGN1bGF0ZVJlY3RzKHJvb3RMYXll ciwgaGl0VGVzdFJlY3QsIGxheWVyQm91bmRzLCBiZ1JlY3QsIGZnUmVjdCwgb3V0bGluZVJlY3Qs IHRlbXBvcmFyeUNsaXBSZWN0cyk7CiAgICAgCiAgICAgLy8gVGhlIGZvbGxvd2luZyBhcmUgdXNl ZCBmb3Iga2VlcGluZyB0cmFjayBvZiB0aGUgei1kZXB0aCBvZiB0aGUgaGl0IHBvaW50IG9mIDNk LXRyYW5zZm9ybWVkCiAgICAgLy8gZGVzY2VuZGFudHMuCg==