244279 2022-08-23 16:22:12 -0700 Remove hspace and vspace attributes from input field 2022-12-30 03:14:40 -0800 1 1 1 Unclassified WebKit Forms Safari 15 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=120133 http://wpt.live/html/rendering/unmapped-attributes.html BrowserCompat, InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 karlcow ap bfulgham cdumez karlcow rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1893375 0 ahmad.saleem792 2022-08-23 16:22:12 -0700 Hi Team, Similar to bug 120133, we are still failing test cases on WPT: Link - https://wpt.fyi/results/html/rendering/unmapped-attributes.html?label=experimental&label=master&aligned Example - <input hspace> should not be mapped to style marginLeft in CSS1Compat mode Just wanted to create a bug since I was not able to find any. NOTE - Safari Technology Preview 151 and Chrome Canary 107 both are failing these tests while Firefox Nightly 106 is passing them. If it is similar to bug 120133, I am happy to give it a try. Thanks! 1893384 1 ahmad.saleem792 2022-08-23 16:58:07 -0700 https://github.com/WebKit/WebKit/pull/3598 1894128 2 ahmad.saleem792 2022-08-26 17:09:11 -0700 I closed this pull request since it is not as simple as "Bug 120133" and these are lessons learnt: 1) Following test fails with the change (if followed to do similar to Bug 120133: imported/w3c/web-platform-tests/html/rendering/dimension-attributes.html ^ This expects you to have "vspace" and "hspace" available for input type = image and not for others. 2) WPT Test case wording is wrong and it just states "input vspace" while it should be "input type=image vspace" to make it more clearer that it is an edge case. 3) m_inputType need to introduced within HTMLInputElement to look for any Input type which is Image and only then apply this vspace and hspace attributes. Since I am still lacking in learning about Webkit, Programming and C++, so I think someone else need to take this up. ______ Just wanted to share learnings before I make this available for others and close my pull requests. Thanks! 1894980 3 webkit-bug-importer 2022-08-30 16:23:16 -0700 <rdar://problem/99356718> 1922049 4 karlcow 2022-12-27 19:27:24 -0800 Pull request: https://github.com/WebKit/WebKit/pull/8083 1922050 5 karlcow 2022-12-27 19:30:48 -0800 I may have found a way to deal with it. Let's see what EWS testing says in the pull request https://github.com/WebKit/WebKit/pull/8083 1922274 6 ews-feeder 2022-12-30 03:14:38 -0800 Committed 258360@main (90658791ba8b): <https://commits.webkit.org/258360@main> Reviewed commits have been landed. Closing PR #8083 and removing active labels.