24426 2009-03-06 10:05:28 -0800 Regression from r41207 2009-03-06 15:05:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED INVALID Regression P2 Normal --- 1 sky webkit-unassigned sam oldest_to_newest 112616 0 sky 2009-03-06 10:05:28 -0800 I'll attach a test case after I create the bug. This can be seen with any of the chromium bug pages. When you edit a bug and click in one of the fields a DIV is moved to the location of the form field. The DIV is absolutely placed. The position is determined by getBoundingClientRect. Prior to 41207 this location was not relative to the viewport, so that setting the location of the div to that returned from getBoundingClientRect worked correctly. Now that getBoundingClientRect is relative to the viewport this code no longer works. The code is also attempting to offset by scrollTop (more specifically a.document.documentElement.scrollTop where a is the window), but that appears to be 0. The script on this page isn't new, what is new is it hitting the getBoundingClientRect code. The script only executes this if getBoundingClientRect is defined. 112617 1 28365 sky 2009-03-06 10:07:58 -0800 Created attachment 28365 Test case for bug To repro do the following: 1. Click the button. 2. Notice the red div appears right beneath the button. 3. vertically scroll a bit. 4. click the button again. Notice the red div is no longer placed beneath the button. The script in the test is rather ugly as it's reduced from a real page. I could certainly create a more reduced test case, but I thought you might want to see how this ever worked prior to adding getBoundingClientRect. 112621 2 sky 2009-03-06 10:34:21 -0800 FF's getBoundingClientRect is relative to the viewport, just as ours is after Sam landed 41207. Given that, I suspect this is a bug in the page. The page is assuming 'window.document.documentElement.scrollTop' returns the vertical offset, but that doesn't appear to have ever been the case in WebKit. It works in FF though. I'm going to leave open just to make sure this was intentional. Sam, please close if you think this is a bug in the page. 112623 3 28367 sky 2009-03-06 10:41:34 -0800 Created attachment 28367 Reduced test case Here's a more reduced test case given my knowledge of the bug. It basically comes down to repositioning a div with the following code: var scrollTop = window.document.documentElement.scrollTop; var targetYLoc = target.getBoundingClientRect().top; var b = document.getElementById("adiv"); b.style.top = (scrollTop + targetYLoc) + "px"; 112669 4 sam 2009-03-06 15:05:40 -0800 I suspect this is a bug in your page since we match Firefox. 28365 2009-03-06 10:07:58 -0800 2009-03-06 10:07:58 -0800 Test case for bug foo.html text/html 4975 sky PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+IAo8aHRtbD4KPGhl YWQ+CjxzY3JpcHQ+CmZ1bmN0aW9uIFJlY3QoYSxiLGMsZCxlKXsKICAgICAgICAgICAgICAgIHRo aXMueD1hOwogICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICB0aGlzLnk9YjsKICAgICAg ICAgICAgICAgIAogICAgICAgICAgICAgICAgdGhpcy53PWM7CiAgICAgICAgICAgICAgICAKICAg ICAgICAgICAgICAgIHRoaXMuaD1kOwogICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICB0 aGlzLmNvb3JkaW5hdGVGcmFtZT1lfHxudWxsCiAgICAgICAgICAgIH0KICAgICAgICAgICAgCiAg ICAgICAgICAgIAogICAgICAgICAgICBSZWN0LnByb3RvdHlwZS50b1N0cmluZz1mdW5jdGlvbigp ewogICAgICAgICAgICAgICAgcmV0dXJuIltSICIrdGhpcy53KyJ4Iit0aGlzLmgrIisiK3RoaXMu eCsiKyIrdGhpcy55KyJdIgogICAgICAgICAgICB9CgpmdW5jdGlvbiBCUl9BZ2VudENvbnRhaW5z XyhhKXsKICBpZihhIGluIEJSX0FnZW50Q29udGFpbnNfY2FjaGVfKXJldHVybiBCUl9BZ2VudENv bnRhaW5zX2NhY2hlX1thXTsKICAgICAgICAKICAgIHJldHVybiBCUl9BZ2VudENvbnRhaW5zX2Nh Y2hlX1thXT1uYXZpZ2F0b3IudXNlckFnZW50LnRvTG93ZXJDYXNlKCkuaW5kZXhPZihhKSE9LTEK ICB9CnZhciBCUl9BZ2VudENvbnRhaW5zX2NhY2hlXz17fTsKCnZhciBnZXRTY3JvbGxUb3BHZXR0 ZXJzXz17CiAgaWVRdWlya3NfOmZ1bmN0aW9uKGEpewogICAgICAgICAgICAgICAgdG90YWxSZXN1 bHQgKz0gIiBpZXF1aXJrcyI7CiAgICByZXR1cm4gYS5kb2N1bWVudC5ib2R5LnNjcm9sbFRvcAog IH0KICAgICAgICAgICAgLGllU3RhbmRhcmRzXzpmdW5jdGlvbihhKXsKICAgICAgICAgICAgICAg IHRvdGFsUmVzdWx0ICs9ICIgaWVzdGFuZGFyZHM9IiArIGEuZG9jdW1lbnQuZG9jdW1lbnRFbGVt ZW50LnNjcm9sbFRvcDsKICAgICAgICAgICAgICAgIHJldHVybiBhLmRvY3VtZW50LmRvY3VtZW50 RWxlbWVudC5zY3JvbGxUb3AKICAgICAgICAgICAgfQogICAgICAgICAgICAsZG9tXzpmdW5jdGlv bihhKXsKICAgICAgICAgICAgICAgIHRvdGFsUmVzdWx0ICs9ICIgaWVkb20iOwogICAgICAgICAg ICAgICAgcmV0dXJuIGEucGFnZVlPZmZzZXQKICAgICAgICAgICAgfQogICAgICAgICAgICAKfTsK ICAgICAgICAKCiAgICAgICAgdmFyIGdldFNjcm9sbExlZnRHZXR0ZXJzXz17CiAgICAgICAgICAg IGllUXVpcmtzXzpmdW5jdGlvbihhKXsKICAgICAgICAgICAgICAgIHJldHVybiBhLmRvY3VtZW50 LmJvZHkuc2Nyb2xsTGVmdAogICAgICAgICAgICB9CiAgICAgICAgICAgICxpZVN0YW5kYXJkc186 ZnVuY3Rpb24oYSl7CiAgICAgICAgICAgICAgICByZXR1cm4gYS5kb2N1bWVudC5kb2N1bWVudEVs ZW1lbnQuc2Nyb2xsTGVmdAogICAgICAgICAgICB9CiAgICAgICAgICAgICxkb21fOmZ1bmN0aW9u KGEpewogICAgICAgICAgICAgICAgcmV0dXJuIGEucGFnZVhPZmZzZXQKICAgICAgICAgICAgfQog ICAgICAgICAgICAKICAgICAgICB9OwoKZnVuY3Rpb24gQlJfSXNJRSgpewogIHJldHVybiBCUl9B Z2VudENvbnRhaW5zXygibXNpZSIpJiYhd2luZG93Lm9wZXJhCn0KZnVuY3Rpb24gQlJfSXNTYWZh cmkoKXsKICAgIHJldHVybiBCUl9BZ2VudENvbnRhaW5zXygic2FmYXJpIil8fEJSX0FnZW50Q29u dGFpbnNfKCJrb25xdWVyb3IiKQp9CmZ1bmN0aW9uIEJSX0lzTmF2KCl7CiAgICByZXR1cm4hQlJf SXNJRSgpJiYhQlJfSXNTYWZhcmkoKSYmQlJfQWdlbnRDb250YWluc18oIm1vemlsbGEiKQp9Cgp2 YXIgdG90YWxSZXN1bHQgPSAiIjsKCmZ1bmN0aW9uIEdldFdpbmRvd1Byb3BlcnR5QnlCcm93c2Vy XyhhLGIpewogIHRyeXsKICAgIGlmICghd2luZG93Lm9wZXJhICYmICJjb21wYXRNb2RlImluIGEu ZG9jdW1lbnQgJiYKICAgICAgICBhLmRvY3VtZW50LmNvbXBhdE1vZGU9PSJDU1MxQ29tcGF0Iikg ewogICAgICB0b3RhbFJlc3VsdCArPSAiIGNzcyBjb21wYXQgIjsKICAgICAgcmV0dXJuIGIuaWVT dGFuZGFyZHNfKGEpOwogICAgfQogICAgZWxzZSBpZihCUl9Jc0lFKCkpIHsKICAgICAgdG90YWxS ZXN1bHQgKz0gIiBpZSBxdWlya3MgIjsKICAgICAgcmV0dXJuIGIuaWVRdWlya3NfKGEpCiAgICB9 CiAgfQogIGNhdGNoKGMpewogICAgICB0b3RhbFJlc3VsdCArPSAiIGV4Y2VwdGlvbiIgKyBjICsg IiAiOwogIH0KICB0b3RhbFJlc3VsdCArPSAiIGRvbSI7CiAgdG90YWxSZXN1bHQgKz0gIiBwYWdl IHkgb2Zmc2V0ID0iICsgYS5wYWdlWU9mZnNldDsKICByZXR1cm4gYi5kb21fKGEpCn0KCmZ1bmN0 aW9uIG5vZGVCb3VuZHMoYSl7CiAgaWYoIWEpcmV0dXJuIG51bGw7CiAgICAgICAgICAgICAgICAK ICBmdW5jdGlvbiBiKGopewogICAgdmFyIGs9YS5vZmZzZXRQYXJlbnQ7CiAgICBmb3IoOyBrICYm IGsub2Zmc2V0UGFyZW50OyBrPWsub2Zmc2V0UGFyZW50KXsKICAgICAgaWYoay5zY3JvbGxMZWZ0 KWoueC09ay5zY3JvbGxMZWZ0OwogICAgICBpZihrLnNjcm9sbFRvcClqLnktPWsuc2Nyb2xsVG9w CiAgICB9CiAgICAgICAgICAgICAgICAgICAgCiAgfQogIHZhciBjOwogIGM9YS5vd25lckRvY3Vt ZW50JiZhLm93bmVyRG9jdW1lbnQucGFyZW50V2luZG93P2Eub3duZXJEb2N1bWVudC5wYXJlbnRX aW5kb3c6d2luZG93OwogIHRvdGFsUmVzdWx0ICs9ICIgd2luZG93PSIgKyBjOwogIHRvdGFsUmVz dWx0ICs9ICIgaXMgd2luZG93PSIgKyAoYyA9PSB3aW5kb3cpOwogIGlmKGEub3duZXJEb2N1bWVu dCYmYS5vd25lckRvY3VtZW50LmdldEJveE9iamVjdEZvcil7CiAgICB2YXIgZD1hLm93bmVyRG9j dW1lbnQuZ2V0Qm94T2JqZWN0Rm9yKGEpLGU9bmV3IFJlY3QoZC54LGQueSxkLndpZHRoLGQuaGVp Z2h0LGMpOwogICAgYihlKTsKICAgIHJldHVybiBlCiAgfQogIGlmKGEuZ2V0Qm91bmRpbmdDbGll bnRSZWN0KXsKICAgIHZhciBmPWEuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CiAgICB0b3RhbFJl c3VsdCArPSAiIGJvdW5kaW5nIHRvcD0iICsgZi50b3AgKyAiICI7CiAgICByZXR1cm4gbmV3IFJl Y3QoZi5sZWZ0K0dldFdpbmRvd1Byb3BlcnR5QnlCcm93c2VyXyhjLGdldFNjcm9sbExlZnRHZXR0 ZXJzXyksCiAgICAgICAgICAgICAgICAgICAgZi50b3ArR2V0V2luZG93UHJvcGVydHlCeUJyb3dz ZXJfKGMsZ2V0U2Nyb2xsVG9wR2V0dGVyc18pLAogICAgICAgICAgICAgICAgICAgIGYucmlnaHQt Zi5sZWZ0LAogICAgICAgICAgICAgICAgICAgIGYuYm90dG9tLWYudG9wLAogICAgICAgICAgICAg ICAgICAgIGMpCiAgfQogIHZhciBnPTAsaD0wLGk9YTsKICBmb3IoO2kub2Zmc2V0UGFyZW50O2k9 aS5vZmZzZXRQYXJlbnQpewogICAgZys9aS5vZmZzZXRMZWZ0OwogICAgaCs9aS5vZmZzZXRUb3AK ICB9CiAgdmFyIGU9bmV3IFJlY3QoZyxoLGEub2Zmc2V0V2lkdGgsYS5vZmZzZXRIZWlnaHQsYyk7 CiAgICAgICAgICAgICAgICAKICBiKGUpOwogICAgICAgICAgICAgICAgCiAgcmV0dXJuIGUKfQoK ZnVuY3Rpb24gZm9jdXNlZCgpIHsKICB2YXIgcmVzdWx0ID0gIlggIjsKICByZXN1bHQgPSAic2Fm YXJpPSIgKyBCUl9Jc1NhZmFyaSgpOwogIGlmICh3aW5kb3cuZXZlbnQudGFyZ2V0LnBhZ2VZIHx8 IHdpbmRvdy5ldmVudC50YXJnZXQucGFnZVgpIHsKICAgIHJlc3VsdCA9ICIgcGFnZVk9IiArIHdp bmRvdy5ldmVudC50YXJnZXQucGFnZVk7CiAgfQogIHJlc3VsdCArPSAiIGNsaWVudFk9IiArIHdp bmRvdy5ldmVudC5jbGllbnRZOwogIHZhciBib3VuZHMgPSBub2RlQm91bmRzKHdpbmRvdy5ldmVu dC50YXJnZXQpOwoKCiAgdmFyIGI9ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImFkaXYiKTsKICAg Yi5zdHlsZS5sZWZ0PWJvdW5kcy54KyJweCI7CiAgIGIuc3R5bGUudG9wPWJvdW5kcy55K2JvdW5k cy5oKyJweCI7CgogIHJlc3VsdCArPSAiIG5vZGVCb3VuZHM9IiArIGJvdW5kczsKICByZXN1bHQg PSB0b3RhbFJlc3VsdCArIHJlc3VsdDsKICB0b3RhbFJlc3VsdCA9ICIiOwoKICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0gcmVzdWx0OwoKICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnYnV0dG9uJykuaW5uZXJIVE1MID0gIm5vdyBzY3JvbGwgdmVydGljYWxs eSBhbmQgY2xpY2sgYWdhaW4iOwoKfQo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keT4KPHAgaWQ9InJl c3VsdCI+cmVzdWx0CjxkaXYgaWQ9ImFkaXYiIHN0eWxlPSJwb3NpdGlvbjphYnNvbHV0ZTsgbGVm dDo0MDBweDsgcmlnaHQ6NjAwcHg7IGJvcmRlcjogcmVkIDFweCBzb2xpZDsgYmFja2dyb3VuZC1j b2xvcjpyZWQiPmEgZGl2PC9kaXY+CjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+ YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5i bGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPGRpdj4KICA8YnV0dG9uIHR5cGU9 ImJ1dHRvbiIgb25jbGljaz0iZm9jdXNlZChldmVudCkiIGlkPSJidXR0b24iPkNsaWNrIE1lPC9i dXR0b24+CjwvZGl2Pgo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+ YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5i bGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJs YWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+Ymxh aAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFo CjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgK PC9ib2R5Pgo8L2h0bWw+Cg== 28367 2009-03-06 10:41:34 -0800 2009-03-06 10:41:34 -0800 Reduced test case foo.html text/html 1435 sky PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+IAo8aHRtbD4KPGhl YWQ+CjxzY3JpcHQ+CmZ1bmN0aW9uIGZvY3VzZWQoKSB7CiAgdmFyIHRhcmdldCA9IHdpbmRvdy5l dmVudC50YXJnZXQ7CiAgdmFyIHNjcm9sbFRvcCA9IHdpbmRvdy5kb2N1bWVudC5kb2N1bWVudEVs ZW1lbnQuc2Nyb2xsVG9wOwogIHZhciB0YXJnZXRZTG9jID0gdGFyZ2V0LmdldEJvdW5kaW5nQ2xp ZW50UmVjdCgpLnRvcDsKICAKICB2YXIgZGVidWdJbmZvID0KICAgICAgInNjcm9sbFRvcCh3aW5k b3cuZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50LnNjcm9sbFRvcCk9IiArIHNjcm9sbFRvcCArCiAg ICAgICIgdGFyZ2V0LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLnRvcD0iICsgdGFyZ2V0WUxvYzsK CiAgdmFyIGIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYWRpdiIpOwogIGIuc3R5bGUudG9w ID0gKHNjcm9sbFRvcCArIHRhcmdldFlMb2MpICsgInB4IjsKCiAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3Jlc3VsdCcpLmlubmVySFRNTCA9IGRlYnVnSW5mbzsKCiAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2J1dHRvbicpLmlubmVySFRNTCA9ICJub3cgc2Nyb2xsIHZlcnRpY2FsbHkgYW5k IGNsaWNrIGFnYWluIjsKfQo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keT4KPHAgaWQ9InJlc3VsdCI+ cmVzdWx0CjxkaXYgaWQ9ImFkaXYiIHN0eWxlPSJwb3NpdGlvbjphYnNvbHV0ZTsgbGVmdDo0MDBw eDsgcmlnaHQ6NjAwcHg7IGJvcmRlcjogcmVkIDFweCBzb2xpZDsgYmFja2dyb3VuZC1jb2xvcjpy ZWQiPmEgZGl2PC9kaXY+CjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8 cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxw PmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPGRpdj4KICA8YnV0dG9uIHR5cGU9ImJ1dHRv biIgb25jbGljaz0iZm9jdXNlZChldmVudCkiIGlkPSJidXR0b24iPkNsaWNrIE1lPC9idXR0b24+ CjwvZGl2Pgo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8 cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxw PmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+ YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5i bGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJs YWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPHA+YmxhaAo8cD5ibGFoCjxwPmJsYWgKPC9ib2R5 Pgo8L2h0bWw+Cg==