<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24423</bug_id>
          
          <creation_ts>2009-03-06 08:06:01 -0800</creation_ts>
          <short_desc>Use new soup_message_body_set_accumulate API in soup backend</short_desc>
          <delta_ts>2009-03-07 01:05:38 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk, Soup</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gustavo Noronha (kov)">gustavo</reporter>
          <assigned_to name="Gustavo Noronha (kov)">gustavo</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>112585</commentid>
    <comment_count>0</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-03-06 08:06:01 -0800</bug_when>
    <thetext>We are currently using a deprecated message flag to avoid accumulating the chunks that are downloaded. We should use the new API. There is also a commented out FIXME line for using this feature when uploading files, which can now be enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112586</commentid>
    <comment_count>1</comment_count>
      <attachid>28360</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-03-06 08:09:29 -0800</bug_when>
    <thetext>Created attachment 28360
replaces the deprecated flag</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112589</commentid>
    <comment_count>2</comment_count>
      <attachid>28361</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-03-06 08:16:13 -0800</bug_when>
    <thetext>Created attachment 28361
disable accumulating for file uploads</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112590</commentid>
    <comment_count>3</comment_count>
      <attachid>28360</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2009-03-06 08:21:53 -0800</bug_when>
    <thetext>Comment on attachment 28360
replaces the deprecated flag

yes!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112593</commentid>
    <comment_count>4</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2009-03-06 08:36:21 -0800</bug_when>
    <thetext>Both landed, as r41482 and r41483.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28360</attachid>
            <date>2009-03-06 08:09:29 -0800</date>
            <delta_ts>2009-03-06 08:21:53 -0800</delta_ts>
            <desc>replaces the deprecated flag</desc>
            <filename>0001-2009-03-06-Gustavo-Noronha-Silva-gns-gnome.org.patch</filename>
            <type>text/plain</type>
            <size>2599</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">RnJvbSA3M2E2ZWNiYTQzNDMyM2YxMWY2NTY4OTU1NDc1MWYwMGU3MDM0NGZhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy
PgpEYXRlOiBGcmksIDYgTWFyIDIwMDkgMTM6MDE6MTggLTAzMDAKU3ViamVjdDogW1BBVENIXSAy
MDA5LTAzLTA2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgoKICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgUmVwbGFjZSB1c2Ugb2YgZGVw
cmVjYXRlZCBTT1VQX01FU1NBR0VfT1ZFUldSSVRFX0NIVU5LUyBmbGFnIHdpdGgKICAgICAgICB0
aGUgbmV3IHNvdXBfbWVzc2FnZV9ib2R5X3NldF9hY2N1bXVsYXRlIEFQSSBpbiBzb3VwLgoKICAg
ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgogICAg
ICAgIChXZWJDb3JlOjpnb3RIZWFkZXJzQ2FsbGJhY2spOgogICAgICAgIChXZWJDb3JlOjpSZXNv
dXJjZUhhbmRsZTo6c3RhcnRIdHRwKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIC4uLi9wbGF0Zm9ybS9u
ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCAgIHwgICAgNiArKysrLS0KIDIgZmls
ZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg
YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGUwYzhhYjEuLjlh
NTE2MDIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl
TG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMDktMDMtMDYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAg
PGduc0Bnbm9tZS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgUmVwbGFjZSB1c2Ugb2YgZGVwcmVjYXRlZCBTT1VQX01FU1NBR0VfT1ZFUldSSVRF
X0NIVU5LUyBmbGFnIHdpdGgKKyAgICAgICAgdGhlIG5ldyBzb3VwX21lc3NhZ2VfYm9keV9zZXRf
YWNjdW11bGF0ZSBBUEkgaW4gc291cC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291
cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z290SGVhZGVyc0Nh
bGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpzdGFydEh0dHApOgor
CisyMDA5LTAzLTA2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgorCiAg
ICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5dGhlci4KIAogICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQwNTEKZGlmZiAtLWdpdCBhL1dlYkNvcmUv
cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9XZWJDb3JlL3Bs
YXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IDIxNjk0NTAu
LmYyNzk5ZjMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291
cmNlSGFuZGxlU291cC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz
b3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtMjE0LDggKzIxNCw2IEBAIHN0YXRpYyB2b2lkIGdvdEhl
YWRlcnNDYWxsYmFjayhTb3VwTWVzc2FnZSogbXNnLCBncG9pbnRlciBkYXRhKQogICAgIGlmICgh
U09VUF9TVEFUVVNfSVNfU1VDQ0VTU0ZVTChtc2ctPnN0YXR1c19jb2RlKSkKICAgICAgICAgcmV0
dXJuOwogCi0gICAgc291cF9tZXNzYWdlX3NldF9mbGFncyhtc2csIFNPVVBfTUVTU0FHRV9PVkVS
V1JJVEVfQ0hVTktTKTsKLQogICAgIC8vIFdlIHN0aWxsIGRvbid0IGtub3cgYW55dGhpbmcgYWJv
dXQgQ29udGVudC1UeXBlLCBzbyB3ZSB3aWxsIHRyeQogICAgIC8vIHNuaWZmaW5nIHRoZSBjb250
ZW50cyBvZiB0aGUgZmlsZSwgYW5kIHRoZW4gcmVwb3J0IHRoYXQgd2UgZ290CiAgICAgLy8gaGVh
ZGVycwpAQCAtNTA2LDYgKzUwNCwxMCBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdGFydEh0dHAo
U3RyaW5nIHVybFN0cmluZykKICAgICBkLT5tX21zZyA9IHN0YXRpY19jYXN0PFNvdXBNZXNzYWdl
Kj4oZ19vYmplY3RfcmVmKG1zZykpOwogICAgIC8vIGJhbGFuY2VkIGJ5IGEgZGVyZWYoKSBpbiBm
aW5pc2hlZENhbGxiYWNrLCB3aGljaCBzaG91bGQgYWx3YXlzIHJ1bgogICAgIHJlZigpOworCisg
ICAgLy8gV2UgaGFuZGxlIGVhY2ggY2h1bmsgb3Vyc2VsdmVzLCBhbmQgd2UgZG9uJ3QgbmVlZCBt
c2ctPnJlc3BvbnNlX2JvZHkKKyAgICAvLyB0byBjb250YWluIGFsbCBvZiB0aGUgZGF0YSB3ZSBn
b3QsIHdoZW4gd2UgZmluaXNoIGRvd25sb2FkaW5nLgorICAgIHNvdXBfbWVzc2FnZV9ib2R5X3Nl
dF9hY2N1bXVsYXRlKG1zZy0+cmVzcG9uc2VfYm9keSwgRkFMU0UpOwogICAgIHNvdXBfc2Vzc2lv
bl9xdWV1ZV9tZXNzYWdlKHNlc3Npb24sIGQtPm1fbXNnLCBmaW5pc2hlZENhbGxiYWNrLCB0aGlz
KTsKIAogICAgIHJldHVybiB0cnVlOwotLSAKMS42LjIKCg==
</data>
<flag name="review"
          id="13889"
          type_id="1"
          status="+"
          setter="zecke"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28361</attachid>
            <date>2009-03-06 08:16:13 -0800</date>
            <delta_ts>2009-03-06 08:31:30 -0800</delta_ts>
            <desc>disable accumulating for file uploads</desc>
            <filename>0001-2009-03-06-Gustavo-Noronha-Silva-gns-gnome.org.patch</filename>
            <type>text/plain</type>
            <size>2606</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">RnJvbSA1MGRmZGUxYmZjNjY1MDA1ZTVhNjc4Y2M5ZDEyM2VmODJhOTEyNzU1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy
PgpEYXRlOiBGcmksIDYgTWFyIDIwMDkgMTM6MTA6NTQgLTAzMDAKU3ViamVjdDogW1BBVENIXSAy
MDA5LTAzLTA2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgoKICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTI0NDIzCiAgICAgICAgVXNlIG5ldyBzb3VwX21lc3NhZ2Vf
Ym9keV9zZXRfYWNjdW11bGF0ZSBBUEkgaW4gc291cCBiYWNrZW5kCgogICAgICAgIERpc2FibGUg
YWNjdW11bGF0aW5nIGNodW5rcyBmb3IgcmVxdWVzdF9ib2R5IG9uIGZpbGUgdXBsb2FkcywKICAg
ICAgICB1c2luZyB0aGUgbmV3IHNvdXAgQVBJLgoKICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsv
c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgogICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhh
bmRsZTo6c3RhcnRIdHRwKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL25ldHdv
cmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgICA3ICstLS0tLS0KIDIgZmlsZXMg
Y2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X
ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDlhNTE2MDIuLjc3YzFk
ZjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n
CkBAIC0yLDYgKzIsMTkgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
IAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQ0MjMK
KyAgICAgICAgVXNlIG5ldyBzb3VwX21lc3NhZ2VfYm9keV9zZXRfYWNjdW11bGF0ZSBBUEkgaW4g
c291cCBiYWNrZW5kCisKKyAgICAgICAgRGlzYWJsZSBhY2N1bXVsYXRpbmcgY2h1bmtzIGZvciBy
ZXF1ZXN0X2JvZHkgb24gZmlsZSB1cGxvYWRzLAorICAgICAgICB1c2luZyB0aGUgbmV3IHNvdXAg
QVBJLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291
cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnRIdHRwKToKKwor
MjAwOS0wMy0wNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBSZXBsYWNlIHVzZSBv
ZiBkZXByZWNhdGVkIFNPVVBfTUVTU0FHRV9PVkVSV1JJVEVfQ0hVTktTIGZsYWcgd2l0aAogICAg
ICAgICB0aGUgbmV3IHNvdXBfbWVzc2FnZV9ib2R5X3NldF9hY2N1bXVsYXRlIEFQSSBpbiBzb3Vw
LgogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhh
bmRsZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5k
bGVTb3VwLmNwcAppbmRleCBmMjc5OWYzLi5iOWE3M2I1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs
YXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCisrKyBiL1dlYkNvcmUv
cGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKQEAgLTQ0OCwxMyAr
NDQ4LDggQEAgYm9vbCBSZXNvdXJjZUhhbmRsZTo6c3RhcnRIdHRwKFN0cmluZyB1cmxTdHJpbmcp
CiAgICAgICAgICAgICAgKiBiZSAoYmlnKSBmaWxlcywgd2hpY2ggd2Ugd2lsbCB3YW50IHRvIG1t
YXAgaW5zdGVhZCBvZgogICAgICAgICAgICAgICogY29weWluZyBpbnRvIG1lbW9yeTsgVE9ETzog
c3VwcG9ydCB1cGxvYWQgb2Ygbm9uLWxvY2FsCiAgICAgICAgICAgICAgKiAodGhpbmsgc2Z0cDov
LykgZmlsZXMgYnkgdXNpbmcgR0lPPwotICAgICAgICAgICAgICoKLSAgICAgICAgICAgICAqIFRP
RE86IHdlIGNhbiBhdm9pZCBhcHBlbmRpbmcgYWxsIHRoZSBidWZmZXJzIHRvIHRoZQotICAgICAg
ICAgICAgICogcmVxdWVzdF9ib2R5IHZhcmlhYmxlIHdpdGggdGhlIGZvbGxvd2luZyBjYWxsLCBi
dXQgd2UKLSAgICAgICAgICAgICAqIG5lZWQgdG8gZGVwZW5kIG9uIGxpYnNvdXAgPiAyLjI1LjQK
LSAgICAgICAgICAgICAqCi0gICAgICAgICAgICAgKiBzb3VwX21lc3NhZ2VfYm9keV9zZXRfYWNj
dW11bGF0ZShtc2ctPnJlcXVlc3RfYm9keSwgRkFMU0UpOwogICAgICAgICAgICAgICovCisgICAg
ICAgICAgICBzb3VwX21lc3NhZ2VfYm9keV9zZXRfYWNjdW11bGF0ZShtc2ctPnJlcXVlc3RfYm9k
eSwgRkFMU0UpOwogICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBudW1FbGVtZW50
czsgaSsrKSB7CiAgICAgICAgICAgICAgICAgY29uc3QgRm9ybURhdGFFbGVtZW50JiBlbGVtZW50
ID0gaHR0cEJvZHktPmVsZW1lbnRzKClbaV07CiAKLS0gCjEuNi4yCgo=
</data>
<flag name="review"
          id="13890"
          type_id="1"
          status="+"
          setter="zecke"
    />
          </attachment>
      

    </bug>

</bugzilla>