24417 2009-03-05 17:54:09 -0800 [GTK] WebKitDownload's _cancel and _dispose methods may emit warnings 2009-03-06 05:24:54 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 gustavo gustavo oldest_to_newest 112494 0 gustavo 2009-03-05 17:54:09 -0800 Those calls deal with the GTimer used to keep information about download elapsed time, but the timer may never get initialized if _start is not called. If nothing handles the download-requested signal, for example, this will emit nasty warning/critical messages in the terminal. 112495 1 28343 gustavo 2009-03-05 17:54:38 -0800 Created attachment 28343 proposed fix 112519 2 28343 mrowe 2009-03-05 20:32:27 -0800 Comment on attachment 28343 proposed fix r=me. "existence" is misspelt in the ChangeLog, the comma is unnecessary there too, and perhaps the comments in the code could be a little more consistent (exists vs non-NULL). 112570 3 gustavo 2009-03-06 05:24:54 -0800 Landed as r41478. 28343 2009-03-05 17:54:38 -0800 2009-03-05 20:32:27 -0800 proposed fix 0001-Check-for-timer-existance-on-_cancel-and-_dispose.patch text/plain 2021 gustavo RnJvbSA5N2RjMTljOGZiNGNlOGViZjlkN2ZhNzkwZmVmYTJjMTZiM2Y2M2ZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDUgTWFyIDIwMDkgMjI6NDk6MjMgLTAzMDAKU3ViamVjdDogW1BBVENIXSBD aGVjayBmb3IgdGltZXIgZXhpc3RhbmNlIG9uIF9jYW5jZWwgYW5kIF9kaXNwb3NlLgoKLS0tCiBX ZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiBX ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgfCAgIDEwICsrKysrKysrLS0KIDIg ZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDJi YzJlOGIuLjBlYjQwZWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dl YktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMDUgIEd1c3Rhdm8g Tm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgZm9yIHRpbWVyIGV4aXN0YW5jZSBvbiBfY2Fu Y2VsIGFuZCBfZGlzcG9zZSwgdG8gYXZvaWQgYmFkCisgICAgICAgIHdhcm5pbmdzLgorCisgICAg ICAgICogd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcDoKKyAgICAgICAgKF9XZWJLaXREb3dubG9h ZFByaXZhdGU6OndlYmtpdF9kb3dubG9hZF9maW5hbGl6ZSk6CisgICAgICAgIChfV2ViS2l0RG93 bmxvYWRQcml2YXRlOjp3ZWJraXRfZG93bmxvYWRfY2FuY2VsKToKKwogMjAwOS0wMy0wMiAgWGFu IExvcGV6ICA8eGFuQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2Uu CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAgYi9XZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXRkb3dubG9hZC5jcHAKaW5kZXggNWZlOGMzMy4uMGVmOGQzMSAx MDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwCisrKyBiL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcApAQCAtMTI0LDcgKzEyNCwxMCBAQCBz dGF0aWMgdm9pZCB3ZWJraXRfZG93bmxvYWRfZmluYWxpemUoR09iamVjdCogb2JqZWN0KQogICAg IGRlbGV0ZSBwcml2LT5kb3dubG9hZENsaWVudDsKICAgICBkZWxldGUgcHJpdi0+bmV0d29ya1Jl c3BvbnNlOwogCi0gICAgZ190aW1lcl9kZXN0cm95KHByaXYtPnRpbWVyKTsKKyAgICAvLyBUaGUg ZG93bmxvYWQgb2JqZWN0IG1heSBuZXZlciBoYXZlIF9zdGFydCBjYWxsZWQgb24gaXQsIHNvIHdl CisgICAgLy8gbmVlZCB0byBtYWtlIHN1cmUgdGltZXIgZXhpc3RzLgorICAgIGlmIChwcml2LT50 aW1lcikKKyAgICAgICAgZ190aW1lcl9kZXN0cm95KHByaXYtPnRpbWVyKTsKIAogICAgIGdfZnJl ZShwcml2LT5kZXN0aW5hdGlvblVSSSk7CiAgICAgZ19mcmVlKHByaXYtPnN1Z2dlc3RlZEZpbGVu YW1lKTsKQEAgLTQxNSw3ICs0MTgsMTAgQEAgdm9pZCB3ZWJraXRfZG93bmxvYWRfY2FuY2VsKFdl YktpdERvd25sb2FkKiBkb3dubG9hZCkKIAogICAgIFdlYktpdERvd25sb2FkUHJpdmF0ZSogcHJp diA9IGRvd25sb2FkLT5wcml2OwogCi0gICAgZ190aW1lcl9zdG9wKHByaXYtPnRpbWVyKTsKKyAg ICAvLyBDYW5jZWwgbWF5IGJlIGNhbGxlZCBldmVuIGlmIHN0YXJ0IHdhcyBub3QgY2FsbGVkLCBz byB3ZSBuZWVkCisgICAgLy8gdG8gbWFrZSBzdXJlIHRpbWVyIGlzIG5vbi1OVUxMLgorICAgIGlm IChwcml2LT50aW1lcikKKyAgICAgICAgZ190aW1lcl9zdG9wKHByaXYtPnRpbWVyKTsKIAogICAg IGlmIChwcml2LT5yZXNvdXJjZUhhbmRsZSkKICAgICAgICAgcHJpdi0+cmVzb3VyY2VIYW5kbGUt PmNhbmNlbCgpOwotLSAKMS42LjIucmMwCgo=