244134 2022-08-19 12:27:29 -0700 REGRESSION(253549@main): [ iOS ] 2X animations/(Layout tests) are constant failures 2022-08-24 19:17:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=244017 https://bugs.webkit.org/show_bug.cgi?id=244285 InRadar P2 Normal --- 1 hhjalmarsson simon.fraser ap simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1892471 0 hhjalmarsson 2022-08-19 12:27:29 -0700 animations/no-style-recalc-during-accelerated-animation.html Is a constant text failure on iOS ToT and since 253549@main. HISTORY: https://results.webkit.org/?suite=layout-tests&test=animations/no-style-recalc-during-accelerated-animation.html DIFF: @@ -1,2 +1,2 @@ Got iteration event. -PASS: saw five or fewer style recalcs during the animation. +FAIL: saw 8 style recalcs during the animation, should only see five. 1892472 1 webkit-bug-importer 2022-08-19 12:27:52 -0700 <rdar://problem/98894287> 1892473 2 hhjalmarsson 2022-08-19 12:29:07 -0700 DIFF URL: https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/253549@main%20(4145)/animations/no-style-recalc-during-accelerated-animation-pretty-diff.html 1892474 3 hhjalmarsson 2022-08-19 12:32:17 -0700 This issue can be bisected to 253549@main using command: run-webkit-tests --ios-simulator --iterations=2 animations/no-style-recalc-during-accelerated-animation.html 1892475 4 ews-feeder 2022-08-19 12:44:00 -0700 Test gardening commit 253601@main (886100c335f4): <https://commits.webkit.org/253601@main> Reviewed commits have been landed. Closing PR #3481 and removing active labels. 1892478 5 hhjalmarsson 2022-08-19 12:47:03 -0700 animations/steps-transform-rendering-updates.html Is a constant text failure on iOS ToT with the same regression point of 253549@main. However, with a different DIFF. They both appear to be related. HISTORY: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=animations%2Fsteps-transform-rendering-updates.html&test=animations%2Fno-style-recalc-during-accelerated-animation.html DIFF: @@ -1,5 +1,5 @@ PASS count is 0 -PASS count < 7 is true +FAIL count < 7 should be true. Was false. PASS successfullyParsed is true TEST COMPLETE 1892479 6 ews-feeder 2022-08-19 12:58:09 -0700 Test gardening commit 253602@main (7199d3824d94): <https://commits.webkit.org/253602@main> Reviewed commits have been landed. Closing PR #3482 and removing active labels. 1892833 7 ap 2022-08-21 14:49:42 -0700 The commit message claims that a few more rendering updates "should be benign". Not sure if the count is flaky now, or what the impact on power use is though. 1893254 8 simon.fraser 2022-08-23 08:46:15 -0700 I've been investigating the causes of the extra updates on iOS; haven't nailed it down yet, but it's benign (a few more per animation, not the "update every frame" that the test was designed to detect). 1893363 9 simon.fraser 2022-08-23 15:08:25 -0700 After lots of debugging, I think the iOS difference is due to differences in timer slop, and how we drive rendering updates with UI-side compositing. I did file bug 244276, and I'll adjust the test to call `setSpeculativeTilingDelayDisabledForTesting(true)` to make sure that doesn't introduce flakiness. 1893396 10 simon.fraser 2022-08-23 18:13:52 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3482 1893640 11 simon.fraser 2022-08-24 19:17:57 -0700 Fixed via https://github.com/WebKit/WebKit/pull/3602