244008 2022-08-16 14:04:36 -0700 Leak of id<MTLArgumentEncoder> in rx::(anonymous)::InitArgumentBufferEncoder() 2022-08-18 03:48:51 -0700 1 1 1 Unclassified WebKit ANGLE Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 218877 219260 1 ddkilzer ddkilzer dino kbr kkinnunen kpiddington webkit-bug-importer oldest_to_newest 1891753 0 ddkilzer 2022-08-16 14:04:36 -0700 Leak of id<MTLArgumentEncoder> in rx::(anonymous)::InitArgumentBufferEncoder(). The struct is defined like this in ProgramMtl.h: ``` struct ProgramArgumentBufferEncoderMtl { void reset(ContextMtl *contextMtl); mtl::AutoObjCPtr<id<MTLArgumentEncoder>> metalArgBufferEncoder; mtl::BufferPool bufferPool; }; ``` However the method doesn't adopt the object in ProgramMtl.mm, which causes it to be assigned with a +2 retain count: ``` void InitArgumentBufferEncoder(mtl::Context *context, id<MTLFunction> function, uint32_t bufferIndex, ProgramArgumentBufferEncoderMtl *encoder) { encoder->metalArgBufferEncoder = [function newArgumentEncoderWithBufferIndex:bufferIndex]; // LEAK! if (encoder->metalArgBufferEncoder) { encoder->bufferPool.initialize(context, encoder->metalArgBufferEncoder.get().encodedLength, mtl::kArgumentBufferOffsetAlignment, 0); } } ``` 1891755 1 webkit-bug-importer 2022-08-16 14:05:06 -0700 <rdar://problem/98747531> 1891756 2 ddkilzer 2022-08-16 14:07:06 -0700 This regressed in commit 6b271237a02594f551ab5948d7d2951addfda81f (232042@main) on Dec 02, 2020. 1891768 3 ddkilzer 2022-08-16 14:43:47 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3380 1891983 4 ews-feeder 2022-08-17 11:14:06 -0700 Committed 253525@main (06f230986084): <https://commits.webkit.org/253525@main> Reviewed commits have been landed. Closing PR #3380 and removing active labels. 1892180 5 kkinnunen 2022-08-18 03:48:51 -0700 https://chromium-review.googlesource.com/c/angle/angle/+/3834820