243915 2022-08-12 20:17:04 -0700 `background-repeat` is incorrectly exposed through inline style 2023-12-17 04:09:41 -0800 1 1 1 Unclassified WebKit CSS Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser clshortfuse koivisto simon.fraser webkit-bug-importer oldest_to_newest 1891074 0 simon.fraser 2022-08-12 20:17:04 -0700 This testcase fails in WebKit: <div id="target" style="background-repeat: no-repeat;"></div> <script> let target = document.getElementById('target'); target.textContent = target.style.length + ' rules'; </script> reporting `0 rules`. Other browsers correctly find one rule. This causes failures on https://css3test.com which uses this technique to detect support for style properties. The bug relates to how webkit expands `background-repeat` to `background-repeat-x` and `background-repeat-y`. 1891076 1 461569 simon.fraser 2022-08-12 20:21:13 -0700 Created attachment 461569 Testcase 1891077 2 simon.fraser 2022-08-12 20:26:18 -0700 `PropertySetCSSStyleDeclaration::length()` is really API, so to fix this we'd either have to recompute the length by collapsing longhands, or not expand `background-repeat` to `background-repeat-x` and `background-repeat-y`. 1891078 3 simon.fraser 2022-08-12 20:42:25 -0700 Maybe we could stop pretending that `background-repeat` is a shorthand. 1891186 4 simon.fraser 2022-08-13 17:21:48 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3292 1891454 5 ews-feeder 2022-08-15 15:04:09 -0700 Committed 253440@main (165b098dbd0b): <https://commits.webkit.org/253440@main> Reviewed commits have been landed. Closing PR #3292 and removing active labels. 1891455 6 webkit-bug-importer 2022-08-15 15:05:24 -0700 <rdar://problem/98690270> 2000265 7 annevk 2023-12-17 04:09:41 -0800 *** Bug 252403 has been marked as a duplicate of this bug. *** 461569 2022-08-12 20:21:13 -0700 2022-08-12 20:21:13 -0700 Testcase background-repeat-computed.html text/html 485 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8c3R5bGU+CiAgICAuYm94IHsKICAgICAgICB3aWR0aDog MTAwcHg7CiAgICAgICAgaGVpZ2h0OiAxMDBweDsKICAgICAgICBiYWNrZ3JvdW5kLWltYWdlOiBs aW5lYXItZ3JhZGllbnQoc2lsdmVyLCB5ZWxsb3cpOwogICAgICAgIGJhY2tncm91bmQtc2l6ZTog MjBweCAyMHB4OwogICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOwogICAgfQogICAgCjwv c3R5bGU+Cjxib2R5PgogICAgPGRpdiBpZD0idGFyZ2V0IiBjbGFzcz0iYm94IiBzdHlsZT0iYmFj a2dyb3VuZC1yZXBlYXQ6IG5vLXJlcGVhdDsiPgogICAgPC9kaXY+CiAgICA8c2NyaXB0PgogICAg ICAgIGxldCB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGFyZ2V0Jyk7CiAgICAg ICAgdGFyZ2V0LnRleHRDb250ZW50ID0gdGFyZ2V0LnN0eWxlLmxlbmd0aCArICcgcnVsZXMnOwog ICAgPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgo=