24386 2009-03-05 08:36:27 -0800 Faster implementation of extractMIMETypeFromMediaType() 2009-03-05 11:58:44 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED http://code.staikos.net/cgi-bin/gitweb.cgi?p=WebKit-CE;a=commitdiff;h=a6eca12aadcacde17c9a78ab573aa0d873bccf4d P2 Normal --- 0 yong.li.webkit webkit-unassigned manyoso staikos oldest_to_newest 112378 0 yong.li.webkit 2009-03-05 08:36:27 -0800 The old implementation runs slowly due to frequently allocating and releasing String object. 112380 1 28304 yong.li.webkit 2009-03-05 08:40:43 -0800 Created attachment 28304 patch file http://code.staikos.net/cgi-bin/gitweb.cgi?p=WebKit-CE;a=commitdiff;h=a6eca12aadcacde17c9a78ab573aa0d873bccf4d#patch1 112414 2 28313 manyoso 2009-03-05 11:28:46 -0800 Created attachment 28313 With Changelog 112419 3 manyoso 2009-03-05 11:58:44 -0800 Landed with r41457. 28304 2009-03-05 08:40:43 -0800 2009-03-05 11:28:46 -0800 patch file faster_extractMIMETypeFromMediaType.patch text/plain 1727 yong.li.webkit QXV0aG9yOiBZb25nIExpIDx5b25nLmxpQHRvcmNobW9iaWxlLmNvbT4gIDIwMDktMDMtMDUgMTE6 MjM6MjUNCkNvbW1pdHRlcjogWW9uZyBMaSA8eW9uZy5saUB0b3JjaG1vYmlsZS5jb20+ICAyMDA5 LTAzLTA1IDExOjI0OjMwDQpQYXJlbnQ6IDM1ODNkOTg3YmU4MmQ4YmY2ZGY4Y2VlMDdhZWMyMDE1 NmI0MjQxNjQgKHdoeSBjYWxsIGN1cnJlbnRUaW1lKCkgdHdpY2UgdW5uZWNlc3NhcmlseT8pDQpC cmFuY2hlczogbWFzdGVyLCByZW1vdGVzL29yaWdpbi9tYXN0ZXINCkZvbGxvd3M6IGlyaXNfYnJv d3Nlcl8xLjEuMA0KUHJlY2VkZXM6IA0KDQogICAgYSBmYXN0ZXIgaW1wbGVtZW5hdGlvbg0KDQot LS0tLS0tLS0tLS0tLS0tLS0tIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5j cHAgLS0tLS0tLS0tLS0tLS0tLS0tLQ0KaW5kZXggMDg1OGZjOS4uMDI0NzQxYSAxMDA2NDQNCkBA IC0xLDYgKzEsNyBAQA0KIC8qDQogICogQ29weXJpZ2h0IChDKSAyMDA2IEFsZXhleSBQcm9za3Vy eWFrb3YgKGFwQHdlYmtpdC5vcmcpDQogICogQ29weXJpZ2h0IChDKSAyMDA2LCAyMDA3LCAyMDA4 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4NCisgKiBDb3B5cmlnaHQgKEMpIDIwMDkg VG9yY2ggTW9iaWxlIEluYy4NCiAgKg0KICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dA0KICAqIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucw0KQEAg LTEzMSwxOCArMTMyLDE4IEBAIFN0cmluZyBmaWxlbmFtZUZyb21IVFRQQ29udGVudERpc3Bvc2l0 aW9uKGNvbnN0IFN0cmluZyYgdmFsdWUpDQogDQogU3RyaW5nIGV4dHJhY3RNSU1FVHlwZUZyb21N ZWRpYVR5cGUoY29uc3QgU3RyaW5nJiBtZWRpYVR5cGUpDQogew0KLSAgICBTdHJpbmcgbWltZVR5 cGU7DQorICAgIFZlY3RvcjxVQ2hhciwgNjQ+IG1pbWVUeXBlOw0KICAgICB1bnNpZ25lZCBsZW5n dGggPSBtZWRpYVR5cGUubGVuZ3RoKCk7DQorICAgIG1pbWVUeXBlLnJlc2VydmVDYXBhY2l0eShs ZW5ndGgpOw0KICAgICBmb3IgKHVuc2lnbmVkIG9mZnNldCA9IDA7IG9mZnNldCA8IGxlbmd0aDsg b2Zmc2V0KyspIHsNCiAgICAgICAgIFVDaGFyIGMgPSBtZWRpYVR5cGVbb2Zmc2V0XTsNCiAgICAg ICAgIGlmIChjID09ICc7JykNCiAgICAgICAgICAgICBicmVhazsNCiAgICAgICAgIGVsc2UgaWYg KGlzU3BhY2VPck5ld2xpbmUoYykpIC8vIEZJWE1FOiBUaGlzIHNlZW1zIHdyb25nLCAiICIgaXMg YW4gaW52YWxpZCBNSU1FIHR5cGUgY2hhcmFjdGVyIGFjY29yZGluZyB0byBSRkMgMjA0NS4gIGJ1 ZyA4NjQ0DQogICAgICAgICAgICAgY29udGludWU7DQotICAgICAgICAvLyBGSVhNRTogVGhpcyBp cyBhIHZlcnkgc2xvdyB3YXkgdG8gYnVpbGQgYSBzdHJpbmcsIGdpdmVuIFdlYkNvcmU6OlN0cmlu ZydzIGltcGxlbWVudGF0aW9uLg0KLSAgICAgICAgbWltZVR5cGUgKz0gU3RyaW5nKCZjLCAxKTsN CisgICAgICAgIG1pbWVUeXBlLmFwcGVuZChjKTsNCiAgICAgfQ0KLSAgICByZXR1cm4gbWltZVR5 cGU7DQorICAgIHJldHVybiBTdHJpbmcobWltZVR5cGUuZGF0YSgpLCBtaW1lVHlwZS5zaXplKCkp Ow0KIH0NCiANCiBTdHJpbmcgZXh0cmFjdENoYXJzZXRGcm9tTWVkaWFUeXBlKGNvbnN0IFN0cmlu ZyYgbWVkaWFUeXBlKQ0KDQo= 28313 2009-03-05 11:28:46 -0800 2009-03-05 11:39:09 -0800 With Changelog 24386.patch text/plain 2017 manyoso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDRkMjJiZS4uZDVlOTJiMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wMy0wNSAgWW9uZyBMaSAgPHlv bmcubGlAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEEgZmFzdGVyIGltcGxlbWVudGF0aW9uIG9mIGV4dHJhY3RNSU1FVHlw ZUZyb21NZWRpYVR5cGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJz LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmV4dHJhY3RNSU1FVHlwZUZyb21NZWRpYVR5cGUpOgor CiAyMDA5LTAzLTA1ICBBZGFtIFRyZWF0ICA8YWRhbS50cmVhdEB0b3JjaG1vYmlsZS5jb20+CiAK ICAgICAgICAgQnVpbGQgZml4IGZvciB3aGVuIEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJID0g MC4gIFRoZSBtZXRob2QKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQ UGFyc2Vycy5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuY3BwCmlu ZGV4IDA4NThmYzkuLmYzNmU5ZmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9IVFRQUGFyc2Vycy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJz ZXJzLmNwcApAQCAtMSw2ICsxLDcgQEAKIC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYgQWxleGV5 IFByb3NrdXJ5YWtvdiAoYXBAd2Via2l0Lm9yZykKICAqIENvcHlyaWdodCAoQykgMjAwNiwgMjAw NywgMjAwOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMp IDIwMDkgVG9yY2ggTW9iaWxlIEluYy4gaHR0cDovL3d3dy50b3JjaG1vYmlsZS5jb20vCiAgKgog ICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhh dCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTEzMSwxOCArMTMyLDE4IEBAIFN0cmluZyBm aWxlbmFtZUZyb21IVFRQQ29udGVudERpc3Bvc2l0aW9uKGNvbnN0IFN0cmluZyYgdmFsdWUpCiAK IFN0cmluZyBleHRyYWN0TUlNRVR5cGVGcm9tTWVkaWFUeXBlKGNvbnN0IFN0cmluZyYgbWVkaWFU eXBlKQogewotICAgIFN0cmluZyBtaW1lVHlwZTsKKyAgICBWZWN0b3I8VUNoYXIsIDY0PiBtaW1l VHlwZTsKICAgICB1bnNpZ25lZCBsZW5ndGggPSBtZWRpYVR5cGUubGVuZ3RoKCk7CisgICAgbWlt ZVR5cGUucmVzZXJ2ZUNhcGFjaXR5KGxlbmd0aCk7CiAgICAgZm9yICh1bnNpZ25lZCBvZmZzZXQg PSAwOyBvZmZzZXQgPCBsZW5ndGg7IG9mZnNldCsrKSB7CiAgICAgICAgIFVDaGFyIGMgPSBtZWRp YVR5cGVbb2Zmc2V0XTsKICAgICAgICAgaWYgKGMgPT0gJzsnKQogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIGVsc2UgaWYgKGlzU3BhY2VPck5ld2xpbmUoYykpIC8vIEZJWE1FOiBUaGlzIHNl ZW1zIHdyb25nLCAiICIgaXMgYW4gaW52YWxpZCBNSU1FIHR5cGUgY2hhcmFjdGVyIGFjY29yZGlu ZyB0byBSRkMgMjA0NS4gIGJ1ZyA4NjQ0CiAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAg Ly8gRklYTUU6IFRoaXMgaXMgYSB2ZXJ5IHNsb3cgd2F5IHRvIGJ1aWxkIGEgc3RyaW5nLCBnaXZl biBXZWJDb3JlOjpTdHJpbmcncyBpbXBsZW1lbnRhdGlvbi4KLSAgICAgICAgbWltZVR5cGUgKz0g U3RyaW5nKCZjLCAxKTsKKyAgICAgICAgbWltZVR5cGUuYXBwZW5kKGMpOwogICAgIH0KLSAgICBy ZXR1cm4gbWltZVR5cGU7CisgICAgcmV0dXJuIFN0cmluZyhtaW1lVHlwZS5kYXRhKCksIG1pbWVU eXBlLnNpemUoKSk7CiB9CiAKIFN0cmluZyBleHRyYWN0Q2hhcnNldEZyb21NZWRpYVR5cGUoY29u c3QgU3RyaW5nJiBtZWRpYVR5cGUpCg==