24382 2009-03-05 07:32:13 -0800 request to add SH4 platform 2009-03-05 23:18:17 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 simone.fiorentino webkit-unassigned ddkilzer oldest_to_newest 112369 0 simone.fiorentino 2009-03-05 07:32:13 -0800 I had some problems related to non-aligned memory accesses as done in WebCore::equal(StringImpl* string, const UChar* characters, unsigned length) function for the SH4 platform. My question is: can you add support in WebKit sources for SH4 platform? In attachment you can find a patch (against WebKit trunk) that introduce the SH4 platform and solves the non-aligned memory accesses (I use the same code as per ARM platform). 112370 1 28299 simone.fiorentino 2009-03-05 07:37:19 -0800 Created attachment 28299 Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal 1. Introduce the SH4 platform 2. Solves the non-aligned memory accesses for SH4 (I use the same code as per ARM platform). 112523 2 28299 ddkilzer 2009-03-05 21:03:01 -0800 Comment on attachment 28299 Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal r=me NOTE: Need to add the bug title and bug number to the ChangeLogs before landing. 112543 3 ddkilzer 2009-03-05 23:18:17 -0800 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/Platform.h M WebCore/ChangeLog M WebCore/platform/text/AtomicString.cpp Committed r41475 http://trac.webkit.org/changeset/41475 28299 2009-03-05 07:37:19 -0800 2009-03-05 21:03:01 -0800 Introduce the SH4 platform - solves the non-aligned memory accesses for SH4 in WebCore::equal sh4Platform.patch text/plain 1944 simone.fiorentino SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQxNDQ3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDktMDMtMDUgIFNpbW9uZSBG aW9yZW50aW5vICA8c2ltb25lLmZpb3JlbnRpbm9AY29uc3VsZW50aS5mYXN0d2ViLml0PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRm b3JtLmg6CisgICAgICAgIEFkZGVkIHN1cHBvcnQgZm9yIFNINCBwbGF0Zm9ybQkKKwogMjAwOS0w My0wNSAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgYnVp bGQuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gNDE0NDcpCisrKyBKYXZhU2Ny aXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMjMyLDYgKzIzMiwxMiBA QAogIyAgIGVuZGlmCiAjZW5kaWYKIAorLyogUExBVEZPUk0oU0g0KSAqLworI2lmICAgZGVmaW5l ZChfX1NINF9fKQorI2RlZmluZSBXVEZfUExBVEZPUk1fU0g0IDEKKyNlbmRpZgorCisKIC8qIENv bXBpbGVyICovCiAKIC8qIENPTVBJTEVSKE1TVkMpICovCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNDE0NDcpCisrKyBX ZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDA5LTAz LTA1ICBTaW1vbmUgRmlvcmVudGlubyAgPHNpbW9uZS5maW9yZW50aW5vQGNvbnN1bGVudGkuZmFz dHdlYi5pdD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIHBs YXRmb3JtL3RleHQvQXRvbWljU3RyaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmVxdWFsKToK KyAgICAgICAgQWxpZ25lZCBtZW1vcnkgYWNjZXNzIG9uIFNINCBwbGF0Zm9ybQkKKwogMjAwOS0w My0wNSAgWGFuIExvcGV6ICA8eGFuQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBN YXJrIFJvd2UuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL3RleHQvQXRvbWljU3RyaW5nLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3RleHQvQXRvbWljU3RyaW5nLmNwcAkocmV2 aXNpb24gNDE0NDcpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvQXRvbWljU3RyaW5nLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTAxLDcgKzEwMSw3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBlcXVh bChTdHJpbmdJbXBsKiBzdHIKICAgICBpZiAoc3RyaW5nLT5sZW5ndGgoKSAhPSBsZW5ndGgpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAotI2lmIFBMQVRGT1JNKEFSTSkKKyNpZiBQTEFURk9STShB Uk0pIHx8IFBMQVRGT1JNKFNINCkKICAgICBjb25zdCBVQ2hhciogc3RyaW5nQ2hhcmFjdGVycyA9 IHN0cmluZy0+Y2hhcmFjdGVycygpOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgIT0gbGVu Z3RoOyArK2kpIHsKICAgICAgICAgaWYgKCpzdHJpbmdDaGFyYWN0ZXJzKysgIT0gKmNoYXJhY3Rl cnMrKykK