243819 2022-08-11 03:55:53 -0700 webgl/2.0.y/deqp/functional/gles3/negativetextureapi.html assertion failure 2022-08-17 17:12:02 -0700 1 1 1 Unclassified WebKit WebGL Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=242614 InRadar P2 Normal --- 222812 1 kkinnunen djg dino kbr kkinnunen oldest_to_newest 1890543 0 kkinnunen 2022-08-11 03:55:53 -0700 webgl/2.0.y/deqp/functional/gles3/negativetextureapi.html assertion failure The validation is not run when pixels == nullptr Due to bug 242614 1890544 1 kkinnunen 2022-08-11 03:57:30 -0700 <rdar://98347913> 1890545 2 kkinnunen 2022-08-11 03:58:21 -0700 The issue is that validation is not done when user passes pixels=null, where as the teximage3dbase expect that the validation is done. WebGL defines pixels=null means pixels=sufficiently large 0 filled pixels. The philosophical rabbit hole: Current WebGL implementation naturally "optimizes" so that it doesn't create the sufficiently large 0 filled pixels buffer, rather that it just passes pixels=nullptr down. However, it also validates other arguments based on pixels. The validation shoudn't be done this way, it should be done based on the GL type, since pixels isn't always there. The other philosophical rabbit hole: the ASSERT_UNUSED(ok) is the smell that reveals the bug. Instead, the validation should return the computed properties, if the validation passes. This way the computation is done once 1890844 3 djg 2022-08-12 03:04:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3263 1892095 4 ews-feeder 2022-08-17 17:11:59 -0700 Committed 253543@main (592cd219941f): <https://commits.webkit.org/253543@main> Reviewed commits have been landed. Closing PR #3263 and removing active labels.