243781 2022-08-10 05:11:19 -0700 [GStreamer] REGRESSION(253289@main): Broke debug builds 2022-08-10 08:18:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=243638 InRadar P2 Normal --- 1 aperez philn philn webkit-bug-importer oldest_to_newest 1890262 0 aperez 2022-08-10 05:11:19 -0700 /app/webkit/WebKitBuild/Debug/WTF/Headers/wtf/Ref.h:119:52: error: invalid argument type 'WebCore::VideoFrameGStreamer' to unary expression bool operator!() const { ASSERT(m_ptr); return !*m_ptr; } ^~~~~~~ /app/webkit/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp:195:5: note: in instantiation of member function 'WTF::Ref<WebCore::VideoFrameGStreamer>::operator!' requested here ASSERT(newVideoFrame); ^ 1890263 1 aperez 2022-08-10 05:12:38 -0700 I suppose the assertion should be moved into PLATFORM(COCOA). Another option would be to explicitly declare the variable as RefPtr<VideFrameGStreamer> instead of using “auto” to avoid the compiler deducing it can use Ref<T>. I am not sure what option is preferred in this case. 1890265 2 aperez 2022-08-10 05:41:34 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3190 1890271 3 pnormand 2022-08-10 06:16:48 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3192 1890293 4 ews-feeder 2022-08-10 08:17:52 -0700 Committed 253296@main (ec1e02abd6f9): <https://commits.webkit.org/253296@main> Reviewed commits have been landed. Closing PR #3192 and removing active labels. 1890294 5 webkit-bug-importer 2022-08-10 08:18:16 -0700 <rdar://problem/98451754>