243748 2022-08-09 13:19:24 -0700 [Filters] Move the static createEffect functions to the FilterOperation classes 2022-08-16 13:20:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 sabouhallawa sabouhallawa bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1890077 0 sabouhallawa 2022-08-09 13:19:24 -0700 The CSS FilterOperations have a hierarchy of base and super classes. Instead of having static createEffect functions in CSSFilter.cpp for every FilterOperation we can make them virtual functions and call them through the base class FilterOperation. The only exception is ReferenceFilterOperation which requires access to the renderer and the filterElement. Accessing these classes from a platform file is a layering violation. So we still need to call createReferenceFilter() from CSSFilter::buildFilterFunctions() as a special case. 1890082 1 sabouhallawa 2022-08-09 13:35:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/3165 1891740 2 webkit-bug-importer 2022-08-16 13:20:34 -0700 <rdar://problem/98745167>