24361 2009-03-04 10:41:52 -0800 REGRESSION(r41379-TOT): clicking a generated content block does not trigger a click for the node 2009-03-04 11:59:10 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 1 timothy simon.fraser hyatt timothy oldest_to_newest 112231 0 timothy 2009-03-04 10:41:52 -0800 Clicking a generated content block does not trigger a click for the node it hangs off of. See attached test case. This has broken some disclosure triangles in the Web Inspector. 112232 1 28274 timothy 2009-03-04 10:42:09 -0800 Created attachment 28274 Test Case 112244 2 simon.fraser 2009-03-04 11:28:23 -0800 I see the problem. 112250 3 28277 simon.fraser 2009-03-04 11:50:29 -0800 Created attachment 28277 Patch, testcase, changelog 112251 4 28277 hyatt 2009-03-04 11:53:26 -0800 Comment on attachment 28277 Patch, testcase, changelog r=me 112252 5 28277 darin 2009-03-04 11:55:03 -0800 Comment on attachment 28277 Patch, testcase, changelog We normally use early return for functions like this. 112254 6 simon.fraser 2009-03-04 11:59:10 -0800 http://trac.webkit.org/changeset/41427 28274 2009-03-04 10:42:09 -0800 2009-03-04 10:42:09 -0800 Test Case hit-test.html text/html 316 timothy PHN0eWxlPgpkaXYgewoJcG9zaXRpb246IHJlbGF0aXZlOwoJd2lkdGg6IDIwMHB4OwoJaGVpZ2h0 OiAyMDBweDsKfQoKZGl2OjpiZWZvcmUgewoJcG9zaXRpb246IGFic29sdXRlOwoJdG9wOiAwOwoJ bGVmdDogMDsKCXdpZHRoOiAxMDAlOwoJaGVpZ2h0OiAxMDAlOwoJYmFja2dyb3VuZC1jb2xvcjog cmVkOwoJY29udGVudDogIiI7Cn0KCmRpdjphY3RpdmU6OmJlZm9yZSB7CgliYWNrZ3JvdW5kLWNv bG9yOiBncmVlbjsKfQo8L3N0eWxlPgpDbGlja2luZyB0aGlzIGJsb2NrIHNob3VsZCBtYWtlIGl0 IHR1cm4gR3JlZW4uCjxkaXY+Jm5ic3A7PC9kaXY+Cg== 28277 2009-03-04 11:50:29 -0800 2009-03-04 11:53:26 -0800 Patch, testcase, changelog 24361_patch.txt text/plain 6273 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNThkOTY3Li5jY2VhZGI2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDMt MDQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQzNjEKKyAgICAgICAgCisgICAgICAgIFRlc3Qg aGl0IHRlc3Rpbmcgb24gZ2VuZXJhdGVkIGNvbnRlbnQuCisKKyAgICAgICAgKiBmYXN0L2Nzcy1n ZW5lcmF0ZWQtY29udGVudC9oaXQtdGVzdC1nZW5lcmF0ZWQtY29udGVudC5odG1sOiBBZGRlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaGl0LXRl c3QtZ2VuZXJhdGVkLWNvbnRlbnQtZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAq IHBsYXRmb3JtL21hYy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9oaXQtdGVzdC1nZW5lcmF0 ZWQtY29udGVudC1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9m YXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9oaXQtdGVzdC1nZW5lcmF0ZWQtY29udGVudC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorCiAyMDA5LTAzLTAzICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxl LmNvbT4KIAogICAgICAgICBUZXN0IGNhc2UgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNDIwMQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2Vu ZXJhdGVkLWNvbnRlbnQvaGl0LXRlc3QtZ2VuZXJhdGVkLWNvbnRlbnQuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2hpdC10ZXN0LWdlbmVyYXRlZC1jb250ZW50 Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNzBhMDQ4YQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2hpdC10 ZXN0LWdlbmVyYXRlZC1jb250ZW50Lmh0bWwKQEAgLTAsMCArMSw0MiBAQAorPGh0bWw+Cis8aGVh ZD4KKzxzdHlsZT4KKyN0YXJnZXQgeworICBwb3NpdGlvbjogcmVsYXRpdmU7CisgIHdpZHRoOiAx MDBweDsKKyAgaGVpZ2h0OiAxMDBweDsKK30KKworI3RhcmdldDo6YmVmb3JlIHsKKyAgcG9zaXRp b246IGFic29sdXRlOworICB0b3A6IDA7CisgIGxlZnQ6IDA7CisgIHdpZHRoOiAxMDAlOworICBo ZWlnaHQ6IDEwMCU7CisgIGJhY2tncm91bmQtY29sb3I6IGdyYXk7CisgIGNvbnRlbnQ6ICIiOwor fQorCis8L3N0eWxlPgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0 Zi04Ij4KKyAgZnVuY3Rpb24gcnVuVGVzdCgpCisgIHsKKyAgICB2YXIgaGl0RWxlbWVudCA9IGRv Y3VtZW50LmVsZW1lbnRGcm9tUG9pbnQoNTgsIDU4KTsKKyAgICB2YXIgcmVzdWx0cyA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHRzJykKKyAgICBpZiAoaGl0RWxlbWVudCAmJiBoaXRF bGVtZW50LmlkID09ICd0YXJnZXQnKQorICAgICAgcmVzdWx0cy5pbm5lckhUTUwgPSAnZWxlbWVu dEZyb21Qb2ludCBmb3VuZCB0YXJnZXQ6IFBBU1MnOworICAgIGVsc2UKKyAgICAgIHJlc3VsdHMu aW5uZXJIVE1MID0gJ2VsZW1lbnRGcm9tUG9pbnQgZGlkIG5vdCBmaW5kIHRhcmdldDogRkFJTCc7 CisgIH0KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorCis8 cD5UZXN0cyBoaXQgdGVzdGluZyBvbiBnZW5lcmF0ZWQgY29udGVudDwvcD4KKzxkaXYgaWQ9InRh cmdldCI+Jm5ic3A7PC9kaXY+CisKKzxkaXYgaWQ9InJlc3VsdHMiPgorPC9kaXY+CisKKzwvYm9k eT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaGl0LXRlc3Qt Z2VuZXJhdGVkLWNvbnRlbnQtZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaGl0LXRlc3QtZ2VuZXJhdGVkLWNvbnRl bnQtZXhwZWN0ZWQuY2hlY2tzdW0KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u YzFhOGJmOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0 L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9oaXQtdGVzdC1nZW5lcmF0ZWQtY29udGVudC1leHBlY3Rl ZC5jaGVja3N1bQpAQCAtMCwwICsxIEBACisyMTBjMTI2OWMzOTUzZGRhNTFjYTJjODE5Y2E2ZmQw YwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9oaXQtdGVzdC1nZW5lcmF0ZWQt Y29udGVudC1leHBlY3RlZC5wbmcgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9jc3Mt Z2VuZXJhdGVkLWNvbnRlbnQvaGl0LXRlc3QtZ2VuZXJhdGVkLWNvbnRlbnQtZXhwZWN0ZWQucG5n Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjk0YjNlNGQKQmluYXJ5IGZpbGVz IC9kZXYvbnVsbCBhbmQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9jc3MtZ2VuZXJh dGVkLWNvbnRlbnQvaGl0LXRlc3QtZ2VuZXJhdGVkLWNvbnRlbnQtZXhwZWN0ZWQucG5nIGRpZmZl cgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvY3NzLWdlbmVyYXRl ZC1jb250ZW50L2hpdC10ZXN0LWdlbmVyYXRlZC1jb250ZW50LWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9oaXQtdGVzdC1n ZW5lcmF0ZWQtY29udGVudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uOGI5MGUxNgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9oaXQtdGVzdC1nZW5lcmF0ZWQtY29udGVu dC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxOCBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4 NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBz aXplIDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAor ICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNpemUgNzg0eDU4NAorICAgICAgUmVuZGVy QmxvY2sge1B9IGF0ICgwLDApIHNpemUgNzg0eDE4CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0 fSBhdCAoMCwwKSBzaXplIDIzM3gxOAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRo IDIzMzogIlRlc3RzIGhpdCB0ZXN0aW5nIG9uIGdlbmVyYXRlZCBjb250ZW50IgorICAgICAgUmVu ZGVyQmxvY2sge0RJVn0gYXQgKDAsMTM0KSBzaXplIDc4NHgxOAorICAgICAgICBSZW5kZXJUZXh0 IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAyNDN4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCww KSB3aWR0aCAyNDM6ICJlbGVtZW50RnJvbVBvaW50IGZvdW5kIHRhcmdldDogUEFTUyIKK2xheWVy IGF0ICg4LDQyKSBzaXplIDEwMHgxMDAKKyAgUmVuZGVyQmxvY2sgKHJlbGF0aXZlIHBvc2l0aW9u ZWQpIHtESVZ9IGF0ICgwLDM0KSBzaXplIDEwMHgxMDAKKyAgICBSZW5kZXJUZXh0IHsjdGV4dH0g YXQgKDAsMCkgc2l6ZSA0eDE4CisgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA0OiAiICIK K2xheWVyIGF0ICg4LDQyKSBzaXplIDEwMHgxMDAKKyAgUmVuZGVyQmxvY2sgKHBvc2l0aW9uZWQp IGF0ICgwLDApIHNpemUgMTAweDEwMCBbYmdjb2xvcj0jODA4MDgwXQorICAgIFJlbmRlclRleHQg YXQgKDAsMCkgc2l6ZSAweDAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggYjEwMzg4Mi4uMWE1MjNlOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0w My0wNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDM2MQorICAgICAgICAKKyAgICAgICAgUmVp bnN0YXRlIGNvZGUgdGhhdCBzZXRzIHJlc3VsdC5pbm5lck5vZGUgd2hlbiBoaXRUZXN0KCkgcmV0 dXJucyB0cnVlLAorICAgICAgICBidXQgbmV2ZXIgZmlsbGVkIGluIHRoZSBpbm5lck5vZGUuIEZp eGVzIGhpdCB0ZXN0aW5nIG9mIGdlbmVyYXRlZCBjb250ZW50LgorCisgICAgICAgIFRlc3Q6IGZh c3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2hpdC10ZXN0LWdlbmVyYXRlZC1jb250ZW50Lmh0bWwK KworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJMYXllcjo6aGl0VGVzdENvbnRlbnRzKToKKwogMjAwOS0wMy0wNCAgQnJhZHkgRWlk c29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA0MDkyOTI0Li45OTE2ZDc4IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0yMzgyLDEwICsyMzgyLDI1IEBAIFJlbmRlckxh eWVyKiBSZW5kZXJMYXllcjo6aGl0VGVzdExheWVyKFJlbmRlckxheWVyKiByb290TGF5ZXIsIFJl bmRlckxheWVyKiBjb250CiAKIGJvb2wgUmVuZGVyTGF5ZXI6OmhpdFRlc3RDb250ZW50cyhjb25z dCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwgSGl0VGVzdFJlc3VsdCYgcmVzdWx0LCBjb25zdCBJ bnRSZWN0JiBsYXllckJvdW5kcywgY29uc3QgSW50UG9pbnQmIGhpdFRlc3RQb2ludCwgSGl0VGVz dEZpbHRlciBoaXRUZXN0RmlsdGVyKSBjb25zdAogewotICAgIHJldHVybiByZW5kZXJlcigpLT5o aXRUZXN0KHJlcXVlc3QsIHJlc3VsdCwgaGl0VGVzdFBvaW50LAorICAgIGlmIChyZW5kZXJlcigp LT5oaXRUZXN0KHJlcXVlc3QsIHJlc3VsdCwgaGl0VGVzdFBvaW50LAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGxheWVyQm91bmRzLngoKSAtIHJlbmRlckJveFgoKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBsYXllckJvdW5kcy55KCkgLSByZW5kZXJCb3hZKCksIAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGhpdFRlc3RGaWx0ZXIpOworICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGhpdFRlc3RGaWx0ZXIpKSB7CisgICAgICAgIC8vIEZvciBwb3NpdGlvbmVkIGdl bmVyYXRlZCBjb250ZW50LCB3ZSBtaWdodCBzdGlsbCBub3QgaGF2ZSBhCisgICAgICAgIC8vIG5v ZGUgYnkgdGhlIHRpbWUgd2UgZ2V0IHRvIHRoZSBsYXllciBsZXZlbCwgc2luY2Ugbm9uZSBvZgor ICAgICAgICAvLyB0aGUgY29udGVudCBpbiB0aGUgbGF5ZXIgaGFzIGFuIGVsZW1lbnQuIFNvIGp1 c3Qgd2FsayB1cAorICAgICAgICAvLyB0aGUgdHJlZS4KKyAgICAgICAgaWYgKCFyZXN1bHQuaW5u ZXJOb2RlKCkgfHwgIXJlc3VsdC5pbm5lck5vblNoYXJlZE5vZGUoKSkgeworICAgICAgICAgICAg Tm9kZSogZSA9IGVuY2xvc2luZ0VsZW1lbnQoKTsKKyAgICAgICAgICAgIGlmICghcmVzdWx0Lmlu bmVyTm9kZSgpKQorICAgICAgICAgICAgICAgIHJlc3VsdC5zZXRJbm5lck5vZGUoZSk7CisgICAg ICAgICAgICBpZiAoIXJlc3VsdC5pbm5lck5vblNoYXJlZE5vZGUoKSkKKyAgICAgICAgICAgICAg ICByZXN1bHQuc2V0SW5uZXJOb25TaGFyZWROb2RlKGUpOworICAgICAgICB9CisgICAgICAgIAor ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB2b2lk IFJlbmRlckxheWVyOjp1cGRhdGVDbGlwUmVjdHMoY29uc3QgUmVuZGVyTGF5ZXIqIHJvb3RMYXll cikK