<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24360</bug_id>
          
          <creation_ts>2009-03-04 10:33:50 -0800</creation_ts>
          <short_desc>Upstream Chromium Linux build fix</short_desc>
          <delta_ts>2009-03-04 16:57:43 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Adam Langley">agl</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>112226</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Langley">agl</who>
    <bug_when>2009-03-04 10:33:50 -0800</bug_when>
    <thetext>r41362 mistakenly added functions &quot;RenderThemeWin::&quot; into RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed them to void return types. This patch switches them back to ints.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112228</commentid>
    <comment_count>1</comment_count>
      <attachid>28272</attachid>
    <who name="Adam Langley">agl</who>
    <bug_when>2009-03-04 10:35:42 -0800</bug_when>
    <thetext>Created attachment 28272
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112230</commentid>
    <comment_count>2</comment_count>
      <attachid>28272</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2009-03-04 10:36:34 -0800</bug_when>
    <thetext>Comment on attachment 28272
patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112322</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-03-04 16:57:43 -0800</bug_when>
    <thetext>WebCore/rendering/RenderThemeChromiumLinux.cpp: locally modified
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderThemeChromiumLinux.cpp
Committed r41438
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28272</attachid>
            <date>2009-03-04 10:35:42 -0800</date>
            <delta_ts>2009-03-04 10:36:34 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>2023</size>
            <attacher name="Adam Langley">agl</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
Yzc5ZGNiYi4uNTE4MWE3MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wMy0wNCAgQWRhbSBMYW5nbGV5
ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgcjQxMzYyIG1pc3Rha2VubHkgYWRkZWQgZnVuY3Rpb25zICJSZW5kZXJUaGVt
ZVdpbjo6IiBpbnRvCisgICAgICAgIFJlbmRlclRoZW1lQ2hyb21pdW1HdGsuY3BwLiBXaGVuIGNv
cnJlY3RpbmcgdGhpcywgSSBzb21laG93IGNoYW5nZWQKKyAgICAgICAgdGhlbSB0byB2b2lkIHJl
dHVybiB0eXBlcy4gVGhpcyBwYXRjaCBzd2l0Y2hlcyB0aGVtIGJhY2sgdG8gaW50cy4KKworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQzNjAKKworICAg
ICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtTGludXguY3BwOgorICAgICAgICAo
V2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpidXR0b25JbnRlcm5hbFBhZGRpbmdM
ZWZ0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6YnV0dG9u
SW50ZXJuYWxQYWRkaW5nUmlnaHQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVDaHJv
bWl1bUxpbnV4OjpidXR0b25JbnRlcm5hbFBhZGRpbmdUb3ApOgorICAgICAgICAoV2ViQ29yZTo6
UmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpidXR0b25JbnRlcm5hbFBhZGRpbmdCb3R0b20pOgor
CiAyMDA5LTAzLTA0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAg
ICAgICAqIEVuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczogVXBkYXRlIHN0cmluZ3Mg
dG8gaW5jbHVkZSAiREFUQUJBU0VTIiwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1Jl
bmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt
ZUNocm9taXVtTGludXguY3BwCmluZGV4IDgyMWU1MGQuLjA0Mjg2ZjIgMTAwNjQ0Ci0tLSBhL1dl
YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1MaW51eC5jcHAKKysrIGIvV2ViQ29y
ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4LmNwcApAQCAtMzM1LDIyICszMzUs
MjIgQEAgaW50IFJlbmRlclRoZW1lQ2hyb21pdW1MaW51eDo6cG9wdXBJbnRlcm5hbFBhZGRpbmdC
b3R0b20oUmVuZGVyU3R5bGUqIHN0eWxlKSBjb24KICAgICByZXR1cm4gbWVudUxpc3RJbnRlcm5h
bFBhZGRpbmcoc3R5bGUsIEJvdHRvbVBhZGRpbmcpOwogfQogCi12b2lkIFJlbmRlclRoZW1lQ2hy
b21pdW1MaW51eDo6YnV0dG9uSW50ZXJuYWxQYWRkaW5nTGVmdCgpIGNvbnN0CitpbnQgUmVuZGVy
VGhlbWVDaHJvbWl1bUxpbnV4OjpidXR0b25JbnRlcm5hbFBhZGRpbmdMZWZ0KCkgY29uc3QKIHsK
ICAgICByZXR1cm4gMzsKIH0KIAotdm9pZCBSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OmJ1dHRv
bkludGVybmFsUGFkZGluZ1JpZ2h0KCkgY29uc3QKK2ludCBSZW5kZXJUaGVtZUNocm9taXVtTGlu
dXg6OmJ1dHRvbkludGVybmFsUGFkZGluZ1JpZ2h0KCkgY29uc3QKIHsKICAgICByZXR1cm4gMzsK
IH0KIAotdm9pZCBSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OmJ1dHRvbkludGVybmFsUGFkZGlu
Z1RvcCgpIGNvbnN0CitpbnQgUmVuZGVyVGhlbWVDaHJvbWl1bUxpbnV4OjpidXR0b25JbnRlcm5h
bFBhZGRpbmdUb3AoKSBjb25zdAogewogICAgIHJldHVybiAxOwogfQogCi12b2lkIFJlbmRlclRo
ZW1lQ2hyb21pdW1MaW51eDo6YnV0dG9uSW50ZXJuYWxQYWRkaW5nQm90dG9tKCkgY29uc3QKK2lu
dCBSZW5kZXJUaGVtZUNocm9taXVtTGludXg6OmJ1dHRvbkludGVybmFsUGFkZGluZ0JvdHRvbSgp
IGNvbnN0CiB7CiAgICAgcmV0dXJuIDE7CiB9Cg==
</data>
<flag name="review"
          id="13828"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>