24353 2009-03-04 07:21:19 -0800 Allow to overrule default build options for Qt build 2009-03-09 09:38:16 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 laszlo.gombos webkit-unassigned hausmann vestbo oldest_to_newest 112194 0 laszlo.gombos 2009-03-04 07:21:19 -0800 WebKit in general, and the Qt port specifically does a good job of picking sensible default configuration options and at the same time allowing the build system to overrule the default options without changing the source code. I run into a few configuration options where the Qt build system does not allow to overrule the defaults. For example WebCore.pro makes a choice that if "embedded" is defined than NETSCAPE_PLUGIN_API is not supported; and this choice can not be overruled without changing WebCore.pro. A patch will follow to address this issue and make the Qt build system more flexible and consistent to follow a general guideline that if a default config coice is made than there should be a way to overrule the default config choice without changing the source files. 112195 1 28265 laszlo.gombos 2009-03-04 07:27:18 -0800 Created attachment 28265 Proposed fix to make the Qt build system more flexible and consistent 112833 2 manyoso 2009-03-09 09:38:16 -0700 Landed with r41528. 28265 2009-03-04 07:27:18 -0800 2009-03-06 12:40:13 -0800 Proposed fix to make the Qt build system more flexible and consistent patch_24353.txt text/plain 3811 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQxNDIwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDMtMDQgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNDM1MworICAgICAgICBBbGxvdyB0byBvdmVycnVsZSBkZWZhdWx0IGJ1aWxk IG9wdGlvbnMgZm9yIFF0IGJ1aWxkLgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUucHJpOiBB bGxvdyB0byBvdmVycnVsZSBFTkFCTEVfSklUCisKIDIwMDktMDMtMDMgIERhdmlkIEtpbHplciAg PGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjU4MTIwMz4g V2ViQ29yZSBhbmQgV2ViS2l0IHNob3VsZCBpbnN0YWxsIHRoZSBzYW1lIHNldCBvZiBoZWFkZXJz IGR1cmluZyBpbnN0YWxsaGRycyBwaGFzZSBhcyBidWlsZCBwaGFzZQpJbmRleDogSmF2YVNjcmlw dENvcmUvSmF2YVNjcmlwdENvcmUucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLnByaQkocmV2aXNpb24gNDE0MjApCisrKyBKYXZhU2NyaXB0Q29yZS9KYXZh U2NyaXB0Q29yZS5wcmkJKHdvcmtpbmcgY29weSkKQEAgLTE0LDE3ICsxNCwxOSBAQCB3aW4zMi0q IHsKIH0KIAogIyBEaXNhYmxlIHRoZSBKSVQgZHVlIHRvIG51bWVyb3VzIG9ic2VydmVkIG1pc2Nv bXBpbGF0aW9ucyA6KAotQ09ORklHKHJlbGVhc2UpOmlzRXF1YWwoUVRfQVJDSCxpMzg2KSB7Ci0g ICAgIEpJVF9ERUZJTkVTID0gRU5BQkxFX0pJVCBFTkFCTEVfV1JFQyBFTkFCTEVfSklUX09QVElN SVpFX0NBTEwgRU5BQkxFX0pJVF9PUFRJTUlaRV9QUk9QRVJUWV9BQ0NFU1MgRU5BQkxFX0pJVF9P UFRJTUlaRV9BUklUSE1FVElDCi0gICAgICMgUmVxdWlyZSBnY2MgPj0gNC4xCi0gICAgIGxpbnV4 LWcrKyo6Z3JlYXRlclRoYW4oUVRfR0NDX01BSk9SX1ZFUlNJT04sMyk6Z3JlYXRlclRoYW4oUVRf R0NDX01JTk9SX1ZFUlNJT04sMCkgewotICAgICAgICAgREVGSU5FUyArPSAkJEpJVF9ERUZJTkVT IFdURl9VU0VfSklUX1NUVUJfQVJHVU1FTlRfVkFfTElTVAotICAgICAgICAgUU1BS0VfQ1hYRkxB R1MgKz0gLWZuby1zdGFjay1wcm90ZWN0b3IKLSAgICAgICAgIFFNQUtFX0NGTEFHUyArPSAtZm5v LXN0YWNrLXByb3RlY3RvcgotICAgICB9Ci0gICAgIHdpbjMyLW1zdmMqIHsKLSAgICAgICAgIERF RklORVMgKz0gJCRKSVRfREVGSU5FUyBXVEZfVVNFX0pJVF9TVFVCX0FSR1VNRU5UX1JFR0lTVEVS Ci0gICAgIH0KKyFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfSklUPS4pIHsKKyAgICBDT05GSUco cmVsZWFzZSk6aXNFcXVhbChRVF9BUkNILGkzODYpIHsKKyAgICAgICAgIEpJVF9ERUZJTkVTID0g RU5BQkxFX0pJVCBFTkFCTEVfV1JFQyBFTkFCTEVfSklUX09QVElNSVpFX0NBTEwgRU5BQkxFX0pJ VF9PUFRJTUlaRV9QUk9QRVJUWV9BQ0NFU1MgRU5BQkxFX0pJVF9PUFRJTUlaRV9BUklUSE1FVElD CisgICAgICAgICAjIFJlcXVpcmUgZ2NjID49IDQuMQorICAgICAgICAgbGludXgtZysrKjpncmVh dGVyVGhhbihRVF9HQ0NfTUFKT1JfVkVSU0lPTiwzKTpncmVhdGVyVGhhbihRVF9HQ0NfTUlOT1Jf VkVSU0lPTiwwKSB7CisgICAgICAgICAgICAgREVGSU5FUyArPSAkJEpJVF9ERUZJTkVTIFdURl9V U0VfSklUX1NUVUJfQVJHVU1FTlRfVkFfTElTVAorICAgICAgICAgICAgIFFNQUtFX0NYWEZMQUdT ICs9IC1mbm8tc3RhY2stcHJvdGVjdG9yCisgICAgICAgICAgICAgUU1BS0VfQ0ZMQUdTICs9IC1m bm8tc3RhY2stcHJvdGVjdG9yCisgICAgICAgICB9CisgICAgICAgICB3aW4zMi1tc3ZjKiB7Cisg ICAgICAgICAgICAgREVGSU5FUyArPSAkJEpJVF9ERUZJTkVTIFdURl9VU0VfSklUX1NUVUJfQVJH VU1FTlRfUkVHSVNURVIKKyAgICAgICAgIH0KKyAgICB9CiB9CiAKIGluY2x1ZGUocGNyZS9wY3Jl LnByaSkKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hh bmdlTG9nCShyZXZpc2lvbiA0MTQyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDMtMDQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDM1 MworICAgICAgICBBbGxvdyB0byBvdmVycnVsZSBkZWZhdWx0IGJ1aWxkIG9wdGlvbnMgZm9yIFF0 IGJ1aWxkLgorCisgICAgICAgICogV2ViQ29yZS5wcm86IEFsbG93IHRvIG92ZXJydWxlIEVOQUJM RV9WSURFTyBhbmQgRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkKKwogMjAwOS0wMy0wMiAgS2lt IEdyw7ZuaG9sbSAgPGtpbS5ncm9uaG9sbUBub21vdm9rLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5wcm8KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9XZWJDb3JlLnBybwkocmV2aXNpb24gNDE0MjApCisrKyBXZWJDb3JlL1dl YkNvcmUucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0xMTAsMTQgKzExMCwxOCBAQCBDT05GSUcoUVRE SVJfYnVpbGQpIHsKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfU1ZHX1VTRT0uKTogREVGSU5F UyArPSBFTkFCTEVfU1ZHX1VTRT0xCiAKICMgSFRNTDUgbWVkaWEgc3VwcG9ydAotY29udGFpbnMo UVRfQ09ORklHLCBwaG9ub24pOkRFRklORVMgKz0gRU5BQkxFX1ZJREVPPTEKLWVsc2U6REVGSU5F UyArPSBFTkFCTEVfVklERU89MAorIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9WSURFTz0uKSB7 CisgICAgY29udGFpbnMoUVRfQ09ORklHLCBwaG9ub24pOkRFRklORVMgKz0gRU5BQkxFX1ZJREVP PTEKKyAgICBlbHNlOkRFRklORVMgKz0gRU5BQkxFX1ZJREVPPTAKK30KIAogIyBOZXNjYXBlIHBs dWdpbnMgc3VwcG9ydCAoTlBBUEkpCi11bml4fHdpbjMyLSo6IWVtYmVkZGVkOiF3aW5jZSo6IXN5 bWJpYW4gewotICAgIERFRklORVMgKz0gRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEk9MQotfSBl bHNlIHsKLSAgICBERUZJTkVTICs9IEVOQUJMRV9ORVRTQ0FQRV9QTFVHSU5fQVBJPTAKKyFjb250 YWlucyhERUZJTkVTLCBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQST0uKSB7CisgICAgdW5peHx3 aW4zMi0qOiFlbWJlZGRlZDohd2luY2UqOiFzeW1iaWFuIHsKKyAgICAgICAgREVGSU5FUyArPSBF TkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQST0xCisgICAgfSBlbHNlIHsKKyAgICAgICAgREVGSU5F UyArPSBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQST0wCisgICAgfQogfQogCiBERUZJTkVTICs9 IFdURl9VU0VfSkFWQVNDUklQVENPUkVfQklORElOR1M9MSBXVEZfQ0hBTkdFUz0xCg==