24349 2009-03-04 06:11:44 -0800 [Qt] HTTP status text is never set 2009-03-13 03:06:26 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 adam.bergkvist webkit-unassigned ap zecke oldest_to_newest 112186 0 adam.bergkvist 2009-03-04 06:11:44 -0800 See related bug: https://bugs.webkit.org/show_bug.cgi?id=3547 112189 1 28263 adam.bergkvist 2009-03-04 06:24:17 -0800 Created attachment 28263 patch 112359 2 28263 ap 2009-03-05 04:54:15 -0800 Comment on attachment 28263 patch r=me 112716 3 28263 zecke 2009-03-07 05:08:50 -0800 Comment on attachment 28263 patch > + response.setHTTPStatusText(m_reply->attribute(QNetworkRequest::HttpReasonPhraseAttribute).toByteArray().constData()); this is weird... QString -> QByteArray -> constData -> String when we have a QString -> String already... 112801 4 ap 2009-03-09 01:16:12 -0700 I'm reluctant to make any changes, as I don't have a Qt build, but please feel free to tweak and land. 112809 5 adam.bergkvist 2009-03-09 02:31:05 -0700 (In reply to comment #3) > (From update of attachment 28263 [review]) > > > + response.setHTTPStatusText(m_reply->attribute(QNetworkRequest::HttpReasonPhraseAttribute).toByteArray().constData()); > > this is weird... > QString -> QByteArray -> constData -> String when we have a QString -> String > already... > m_reply->attribute(QNetworkRequest::HttpReasonPhraseAttribute) is a QVariant::ByteArray. We could do a toString() to construct a QString, but that would cause an extra copy of the character data. 112815 6 zecke 2009-03-09 02:41:07 -0700 I only looked at the Qt site of things and: grep -rn HttpReasonPhraseAttribute * qnetworkaccesscachebackend.cpp:81: setAttribute(QNetworkRequest::HttpReasonPhraseAttribute, attributes.value(QNetworkRequest::HttpReasonPhraseAttribute)); qnetworkaccesshttpbackend.cpp:772: setAttribute(QNetworkRequest::HttpReasonPhraseAttribute, httpReply->reasonPhrase()); qnetworkaccesshttpbackend.cpp:890: setAttribute(QNetworkRequest::HttpReasonPhraseAttribute, attributes.value(QNetworkRequest::HttpReasonPhraseAttribute)); qnetworkaccesshttpbackend.cpp:1039: attributes.insert(QNetworkRequest::HttpReasonPhraseAttribute, httpReply->reasonPhrase()); qnetworkrequest.cpp:116: \value HttpReasonPhraseAttribute qnetworkrequest.h:67: HttpReasonPhraseAttribute, and reasonPhrase() is a QString coming from: qhttp.h: QString reasonPhrase() const; qhttpnetworkconnection_p.h: QString reasonPhrase() const; so what am I missing? 112817 7 adam.bergkvist 2009-03-09 03:24:30 -0700 Strange... considering that the documentation states that it is a ByteArray. A ByteArray would make sense since the reason phrase can only contain ascii characters. http://doc.trolltech.com/main-snapshot/qnetworkrequest.html#Attribute-enum 113568 8 zecke 2009-03-13 03:04:50 -0700 (In reply to comment #7) > http://doc.trolltech.com/main-snapshot/qnetworkrequest.html#Attribute-enum Okay, we should stick with the documentation here. 113569 9 ap 2009-03-13 03:06:26 -0700 Committed revision 41664. 28263 2009-03-04 06:24:17 -0800 2009-03-05 04:54:15 -0800 patch patch_24349 text/plain 1551 adam.bergkvist SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTQxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDMtMDQgIEFkYW0gQmVyZ2t2aXN0IDxhZGFtLmJlcmdrdmlz dEBlcmljc3Nvbi5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MzQ5Cisg ICAgICAgIFtRVF0gSFRUUCBzdGF0dXMgdGV4dCBpcyBuZXZlciBzZXQKKworICAgICAgICBTZXQg SFRUUCBzdGF0dXMgdGV4dCB0byB0aGUgcmVhc29uIHBocmFzZSBhdHRyaWJ1dGUgb2YgUU5ldHdv cmtSZXBseS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhh bmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UU5ldHdvcmtSZXBseUhhbmRsZXI6OnNlbmRS ZXNwb25zZUlmTmVlZGVkKToKKwogMjAwOS0wMy0wMyAgTWlrZSBCZWxzaGUgIDxtaWtlQGJlbHNo ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6 IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5k bGVyLmNwcAkocmV2aXNpb24gNDEzNTMpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQv UU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjksOCArMjY5LDEw IEBAIHZvaWQgUU5ldHdvcmtSZXBseUhhbmRsZXI6OnNlbmRSZXNwb25zZUkKIAogICAgIGNvbnN0 IGJvb2wgaXNMb2NhbEZpbGVSZXBseSA9IChtX3JlcGx5LT51cmwoKS5zY2hlbWUoKSA9PSBRTGF0 aW4xU3RyaW5nKCJmaWxlIikpOwogICAgIGludCBzdGF0dXNDb2RlID0gbV9yZXBseS0+YXR0cmli dXRlKFFOZXR3b3JrUmVxdWVzdDo6SHR0cFN0YXR1c0NvZGVBdHRyaWJ1dGUpLnRvSW50KCk7Ci0g ICAgaWYgKCFpc0xvY2FsRmlsZVJlcGx5KQorICAgIGlmICghaXNMb2NhbEZpbGVSZXBseSkgewog ICAgICAgICByZXNwb25zZS5zZXRIVFRQU3RhdHVzQ29kZShzdGF0dXNDb2RlKTsKKyAgICAgICAg cmVzcG9uc2Uuc2V0SFRUUFN0YXR1c1RleHQobV9yZXBseS0+YXR0cmlidXRlKFFOZXR3b3JrUmVx dWVzdDo6SHR0cFJlYXNvblBocmFzZUF0dHJpYnV0ZSkudG9CeXRlQXJyYXkoKS5jb25zdERhdGEo KSk7CisgICAgfQogICAgIGVsc2UgaWYgKG1fcmVwbHktPmVycm9yKCkgPT0gUU5ldHdvcmtSZXBs eTo6Q29udGVudE5vdEZvdW5kRXJyb3IpCiAgICAgICAgIHJlc3BvbnNlLnNldEhUVFBTdGF0dXND b2RlKDQwNCk7CiAK