24345 2009-03-04 01:31:38 -0800 wxWebkit should make use of gcc(4 and greater) hidden visibility feature 2009-05-05 16:12:03 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 1 mmacleod webkit-unassigned oldest_to_newest 112164 0 mmacleod 2009-03-04 01:31:38 -0800 wxWebKit does not currently make use of the gcc hidden visibility features that are available since gcc 4. Changing it to make use of these features is trivial as everything is already in place to do so, so the gains that can be had are almost for free. I have done so and it results in a +-35% binary size decrease (From 30Mib down to 19mib on a 64 bit system). Obviously this also speeds up linking time and other similar benefits. I will attach the patch to enable this below. 112165 1 28259 mmacleod 2009-03-04 01:32:30 -0800 Created attachment 28259 Patch to enable hidden visibility for gcc > 4 112166 2 mmacleod 2009-03-04 01:34:50 -0800 Forgot to mention that this has been tested successfully on both an x86 system with GCC 4.1.2 as well as an x86_64 system with GCC 4.3.3 120038 3 kevino 2009-05-05 16:12:03 -0700 Landed in r43260, thanks! 28259 2009-03-04 01:32:30 -0800 2009-05-05 16:09:16 -0700 Patch to enable hidden visibility for gcc > 4 gcc_hidden_visibility.patch text/plain 1739 mmacleod SW5kZXg6IFdlYktpdC93eC9XZWJGcmFtZS5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L3d4L1dl YkZyYW1lLmgJKHJldmlzaW9uIDQxNDE4KQ0KKysrIFdlYktpdC93eC9XZWJGcmFtZS5oCSh3b3Jr aW5nIGNvcHkpDQpAQCAtNDYsNiArNDYsOSBAQA0KIAogI2lmbmRlZiBTV0lHCiAKKyNpZiAhd3hD SEVDS19WRVJTSU9OKDIsOSwwKSAmJiB3eENIRUNLX0dDQ19WRVJTSU9OKDQsMCkKKyNkZWZpbmUg V1hETExJTVBFWFBfV0VCS0lUIF9fYXR0cmlidXRlX18gKCh2aXNpYmlsaXR5KCJkZWZhdWx0Iikp KQorI2Vsc2UKICNpZiBXWE1BS0lOR0RMTF9XRUJLSVQKICNkZWZpbmUgV1hETExJTVBFWFBfV0VC S0lUIFdYRVhQT1JUCiAjZWxpZiBkZWZpbmVkKFdYVVNJTkdETExfV0VCS0lUKQpAQCAtNTQsOCAr NTcsNyBAQA0KICNkZWZpbmUgV1hETExJTVBFWFBfV0VCS0lUCiAjZW5kaWYKIAotI2Vsc2UgCi0j ZGVmaW5lIFdYRExMSU1QRVhQX1dFQktJVAorI2VuZGlmCiAjZW5kaWYgLy8gU1dJRwogCiBjbGFz cyBXWERMTElNUEVYUF9XRUJLSVQgd3hXZWJWaWV3RE9NRWxlbWVudEluZm8KSW5kZXg6IFdlYktp dC93eC9XZWJWaWV3LmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvd3gvV2ViVmlldy5oCShyZXZp c2lvbiA0MTQxOCkNCisrKyBXZWJLaXQvd3gvV2ViVmlldy5oCSh3b3JraW5nIGNvcHkpDQpAQCAt NDYsNiArNDYsOSBAQA0KIAogI2lmbmRlZiBTV0lHCiAKKyNpZiAhd3hDSEVDS19WRVJTSU9OKDIs OSwwKSAmJiB3eENIRUNLX0dDQ19WRVJTSU9OKDQsMCkKKyNkZWZpbmUgV1hETExJTVBFWFBfV0VC S0lUIF9fYXR0cmlidXRlX18gKCh2aXNpYmlsaXR5KCJkZWZhdWx0IikpKQorI2Vsc2UKICNpZiBX WE1BS0lOR0RMTF9XRUJLSVQKICNkZWZpbmUgV1hETExJTVBFWFBfV0VCS0lUIFdYRVhQT1JUCiAj ZWxpZiBkZWZpbmVkKFdYVVNJTkdETExfV0VCS0lUKQpAQCAtNTQsOCArNTcsNyBAQA0KICNkZWZp bmUgV1hETExJTVBFWFBfV0VCS0lUCiAjZW5kaWYKIAotI2Vsc2UgCi0jZGVmaW5lIFdYRExMSU1Q RVhQX1dFQktJVAorI2VuZGlmCiAjZW5kaWYgLy8gU1dJRwogCiAjaWZuZGVmIFNXSUcKSW5kZXg6 IFdlYktpdFRvb2xzL3d4L2J1aWxkLXd4d2Via2l0DQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0VG9v bHMvd3gvYnVpbGQtd3h3ZWJraXQJKHJldmlzaW9uIDQxNDE4KQ0KKysrIFdlYktpdFRvb2xzL3d4 L2J1aWxkLXd4d2Via2l0CSh3b3JraW5nIGNvcHkpDQpAQCAtMTc5LDcgKzE3OSw3IEBADQogICAg ICAgICBjZCAkb2xkZGlyCiAgICAgZWxzZQogICAgICAgICBpZiBbIC1mICRkaXIvR05VbWFrZWZp bGUgXTsgdGhlbgotICAgICAgICAgICAgbWFrZSAtQyAkZGlyIC1mIEdOVW1ha2VmaWxlICRNQUtF X0FSR1MgQ1hYRkxBR1M9IiRjeHhmbGFncyIgJEAKKyAgICAgICAgICAgIG1ha2UgLUMgJGRpciAt ZiBHTlVtYWtlZmlsZSAkTUFLRV9BUkdTIENYWEZMQUdTPSIkY3h4ZmxhZ3MgLWZ2aXNpYmlsaXR5 PWhpZGRlbiAtZnZpc2liaWxpdHktaW5saW5lcy1oaWRkZW4iICRACiAgICAgICAgIGZpCiAgICAg ZmkKICAgICBpZiBbICQ/ICE9IDAgXTsgdGhlbgo=