24340 2009-03-03 17:46:38 -0800 Expose allowUniversalAccessFromFileUrls to Qt 2009-03-04 09:39:59 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned abarth phoenix1701 oldest_to_newest 112115 0 abarth 2009-03-03 17:46:38 -0800 Clients of the QT port might want to set allowUniversalAccessFromFileUrls. We should expose it in http://trac.webkit.org/browser/trunk/WebKit/qt/Api/qwebsettings.h 112117 1 28252 abarth 2009-03-03 18:02:31 -0800 Created attachment 28252 patch I can't build QT, but this patch is trivially simple (meaning it will probably only break the build in two ways). 112153 2 ap 2009-03-04 00:20:37 -0800 QT is QuickTime, re-titling. 112155 3 28252 ap 2009-03-04 00:29:38 -0800 Comment on attachment 28252 patch + Reviewed by NOBODY (OOPS!). + + Expose AllowUniversalAccessFromFileUrls to QT clients. Please add a bug URL. r=me, but AllowUniversalAccessFromFileUrls should really be AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's particularly unfortunate to have this exposed as a (private) preference, could you please rename all instances? A separate patch would probably be more appropriate. 112158 4 phoenix1701 2009-03-04 00:40:54 -0800 (In reply to comment #3) > r=me, but AllowUniversalAccessFromFileUrls should really be > AllowUniversalAccessFromFileURLs - not just in Qt, but everywhere. It's > particularly unfortunate to have this exposed as a (private) preference, could > you please rename all instances? A separate patch would probably be more > appropriate. "URL" is consistent with the naming of preferences in WebCore, but Qt uses "Url" instead of "URL" pretty universally -- see e.g. the QUrl class and the QWebPage method "userAgentForUrl". Perhaps it should be left alone in QtWebKit and changed elsewhere? 112207 5 abarth 2009-03-04 09:34:00 -0800 > could you please rename all instances? A separate patch would probably be more > appropriate. Filed as: https://bugs.webkit.org/show_bug.cgi?id=24356 112208 6 abarth 2009-03-04 09:39:59 -0800 Sending WebKit/qt/Api/qwebsettings.cpp Sending WebKit/qt/Api/qwebsettings.h Sending WebKit/qt/ChangeLog Transmitting file data ... Committed revision 41421. 28252 2009-03-03 18:02:31 -0800 2009-03-04 00:29:38 -0800 patch qtsettings.patch text/plain 2863 abarth SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDE0MTQpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDMtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBFeHBvc2UgQWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVybHMgdG8gUVQgY2xpZW50cy4K KworICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAoUVdlYlNldHRpbmdz UHJpdmF0ZTo6YXBwbHkpOgorICAgICAgICAoUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MpOgor ICAgICAgICAqIEFwaS9xd2Vic2V0dGluZ3MuaDoKKwogMjAwOS0wMy0wMyAgQXJpeWEgSGlkYXlh dCAgPGFyaXlhLmhpZGF5YXRAdHJvbGx0ZWNoLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBl ZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAJKHJldmlzaW9u IDQxNDE0KQorKysgV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xODMsNiArMTgzLDEwIEBAIHZvaWQgUVdlYlNldHRpbmdzUHJpdmF0ZTo6YXBwbHkoKQog ICAgICAgICB2YWx1ZSA9IGF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpMb2NhbFN0b3Jh Z2VEYXRhYmFzZUVuYWJsZWQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGdsb2JhbC0+YXR0cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OkxvY2FsU3RvcmFnZURhdGFi YXNlRW5hYmxlZCkpOwogICAgICAgICBzZXR0aW5ncy0+c2V0TG9jYWxTdG9yYWdlRW5hYmxlZCh2 YWx1ZSk7CisKKyAgICAgICAgdmFsdWUgPSBhdHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6 QWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9tRmlsZVVybHMsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OkFs bG93VW5pdmVyc2FsQWNjZXNzRnJvbUZpbGVVcmxzKSk7CisgICAgICAgIHNldHRpbmdzLT5zZXRB bGxvd1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVXJscyh2YWx1ZSk7CiAgICAgfSBlbHNlIHsKICAg ICAgICAgUUxpc3Q8UVdlYlNldHRpbmdzUHJpdmF0ZSAqPiBzZXR0aW5ncyA9ICo6OmFsbFNldHRp bmdzKCk7CiAgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgc2V0dGluZ3MuY291bnQoKTsgKytp KQpAQCAtMzExLDYgKzMxNSw4IEBAIFFXZWJTZXR0aW5ncyAqUVdlYlNldHRpbmdzOjpnbG9iYWxT ZXR0aW4KICAgICAgICAgd2ViIGFwcGxpY2F0aW9uIGNhY2hlIGZlYXR1cmUgaXMgZW5hYmxlZCBv ciBub3QuCiAgICAgXHZhbHVlIExvY2FsU3RvcmFnZURhdGFiYXNlRW5hYmxlZCBTcGVjaWZpZXMg d2hldGhlciBzdXBwb3J0IGZvciB0aGUgSFRNTCA1CiAgICAgICAgIGxvY2FsIHN0b3JhZ2UgZmVh dHVyZSBpcyBlbmFibGVkIG9yIG5vdC4KKyAgICBcdmFsdWUgQWxsb3dVbml2ZXJzYWxBY2Nlc3NG cm9tRmlsZVVybHMgU3BlY2lmaWVzIHdoZXRoZXIgZG9jdW1lbnRzIGZyb20gZmlsZQorICAgICAg ICBVUkxzIHNob3VsZCBiZSBncmFudGVkIHVuaXZlcnNhbCBhY2Nlc3MgKGUuZy4sIHRvIEhUVFAg YW5kIEhUVFBTIGRvY3VtZW50cykuCiAqLwogCiAvKiEKQEAgLTMzOSw2ICszNDUsNyBAQCBRV2Vi U2V0dGluZ3M6OlFXZWJTZXR0aW5ncygpCiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNl dHRpbmdzOjpPZmZsaW5lU3RvcmFnZURhdGFiYXNlRW5hYmxlZCwgdHJ1ZSk7CiAgICAgZC0+YXR0 cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVu YWJsZWQsIHRydWUpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6TG9j YWxTdG9yYWdlRGF0YWJhc2VFbmFibGVkLCB0cnVlKTsKKyAgICBkLT5hdHRyaWJ1dGVzLmluc2Vy dChRV2ViU2V0dGluZ3M6OkFsbG93VW5pdmVyc2FsQWNjZXNzRnJvbUZpbGVVcmxzLCB0cnVlKTsK ICAgICBkLT5vZmZsaW5lU3RvcmFnZURlZmF1bHRRdW90YSA9IDUgKiAxMDI0ICogMTAyNDsKIAog fQpJbmRleDogV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oCShyZXZpc2lvbiA0MTQxNCkKKysrIFdlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmgJKHdvcmtpbmcgY29weSkKQEAgLTYzLDcgKzYzLDggQEAgcHVibGlj OgogICAgICAgICBQcmludEVsZW1lbnRCYWNrZ3JvdW5kcywKICAgICAgICAgT2ZmbGluZVN0b3Jh Z2VEYXRhYmFzZUVuYWJsZWQsCiAgICAgICAgIE9mZmxpbmVXZWJBcHBsaWNhdGlvbkNhY2hlRW5h YmxlZCwKLSAgICAgICAgTG9jYWxTdG9yYWdlRGF0YWJhc2VFbmFibGVkCisgICAgICAgIExvY2Fs U3RvcmFnZURhdGFiYXNlRW5hYmxlZCwKKyAgICAgICAgQWxsb3dVbml2ZXJzYWxBY2Nlc3NGcm9t RmlsZVVybHMKICAgICB9OwogICAgIGVudW0gV2ViR3JhcGhpYyB7CiAgICAgICAgIE1pc3NpbmdJ bWFnZUdyYXBoaWMsCg==