24339 2009-03-03 17:27:54 -0800 Add test for potential crash in window.frames.length 2009-03-11 14:18:30 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pam pam ap oldest_to_newest 112112 0 pam 2009-03-03 17:27:54 -0800 Test to make sure that window.frames.length does not crash the browser after the frame navigates away from the original page. 112114 1 28250 pam 2009-03-03 17:39:29 -0800 Created attachment 28250 New test + result This test is not well suited to the JS test framework. 112140 2 28250 fishd 2009-03-03 23:28:41 -0800 Comment on attachment 28250 New test + result >Index: fast/dom/window-collection-length-no-crash.html >=================================================================== >--- fast/dom/window-collection-length-no-crash.html (revision 0) >+++ fast/dom/window-collection-length-no-crash.html (revision 0) >@@ -0,0 +1,22 @@ >+<HTML> >+<script> >+if (window.layoutTestController) { >+ window.layoutTestController.dumpAsText(); >+ window.layoutTestController.waitUntilDone(); >+} >+ >+function run_test() { nit: run_test -> runTest otherwise, LGTM 112141 3 fishd 2009-03-03 23:29:52 -0800 hmm, however... shouldn't this live in fast/dom/Window? 112157 4 ap 2009-03-04 00:34:37 -0800 Why is this a potential crash? My understanding is form.submit() does nothing until script execution finishes. 112308 5 28289 pam 2009-03-04 15:43:59 -0800 Created attachment 28289 New test + result, no form submission (In reply to comment #4) > Why is this a potential crash? My understanding is form.submit() does nothing > until script execution finishes. I can't easily confirm either way, since the original of this test was created for a bug Chromium had a long time ago. But here's one that sidesteps the form submission question, and is more closely related to the original compatibility problem as well. 112348 6 28289 ap 2009-03-05 00:08:29 -0800 Comment on attachment 28289 New test + result, no form submission > +<iframe id="subframe"><p id="contents">Subframe</p></iframe> This paragraph will be ignored - did you intend to do src='data:text/html,<p id="contents">Subframe</p>'? But in this case, the test would probably need to run from an onload handler, as data: URL loading is async. r=me either way. 112441 7 pam 2009-03-05 14:04:52 -0800 (In reply to comment #6) > (From update of attachment 28289 [review]) > > +<iframe id="subframe"><p id="contents">Subframe</p></iframe> > > This paragraph will be ignored Good catch. I took that from the original reduced test case in our (Chromium's) old bug, but it shouldn't be doing anything. Probably it just never got reduced out of the failing third-party webpage. I'll drop it. 112443 8 pam 2009-03-05 14:12:16 -0800 landed in r41459. 113228 9 pam 2009-03-11 14:18:30 -0700 Landed again in r41598, since I neglected to include the test and result files last time. It sure was a nice ChangeLog patch, though. 28250 2009-03-03 17:39:29 -0800 2009-03-04 15:43:59 -0800 New test + result 24339a.txt text/plain 1816 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQxNDE0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMt MDMgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0IGZvciBwb3RlbnRpYWwgY3Jh c2ggaW4gd2luZG93LmZyYW1lcy5sZW5ndGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI0MzM5CisKKyAgICAgICAgKiBmYXN0L2RvbS93aW5kb3ctY29s bGVjdGlvbi1sZW5ndGgtbm8tY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L2RvbS93aW5kb3ctY29sbGVjdGlvbi1sZW5ndGgtbm8tY3Jhc2guaHRtbDogQWRkZWQuCisK IDIwMDktMDMtMDMgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogZmFzdC9kb20vd2luZG93LWNv bGxlY3Rpb24tbGVuZ3RoLW5vLWNyYXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0 L2RvbS93aW5kb3ctY29sbGVjdGlvbi1sZW5ndGgtbm8tY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgZmFzdC9kb20vd2luZG93LWNvbGxlY3Rpb24tbGVuZ3RoLW5vLWNyYXNoLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorSWYgdGhpcyBwYWdlIGFwcGVh cnMgd2l0aG91dCBhIGNyYXNoLCB0aGUgdGVzdCBoYXMgcGFzc2VkLgpJbmRleDogZmFzdC9kb20v d2luZG93LWNvbGxlY3Rpb24tbGVuZ3RoLW5vLWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZmFz dC9kb20vd2luZG93LWNvbGxlY3Rpb24tbGVuZ3RoLW5vLWNyYXNoLmh0bWwJKHJldmlzaW9uIDAp CisrKyBmYXN0L2RvbS93aW5kb3ctY29sbGVjdGlvbi1sZW5ndGgtbm8tY3Jhc2guaHRtbAkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSwyMiBAQAorPEhUTUw+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikgeworICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOworICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgp OworfQorCitmdW5jdGlvbiBydW5fdGVzdCgpIHsKKyAgdmFyIGYgPSB3aW5kb3cuZnJhbWVzOwor ICBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiZm9ybSIpWzBdLnN1Ym1pdCgpOworICBm Lmxlbmd0aDsKK30KKworPC9zY3JpcHQ+Cis8Qk9EWSBvbmxvYWQ9InJ1bl90ZXN0KCkiPgorPGZv cm0gYWN0aW9uPSJyZXNvdXJjZXMvdGVzdC1zdWNjZXNzZnVsLWRlc3RpbmF0aW9uLmh0bWwiIG1l dGhvZD0iR0VUIj48L2Zvcm0+CitUaGlzIHRlc3RzIHRoYXQgd2luZG93LmZyYW1lcy5sZW5ndGgg ZG9lcyBub3QgY3Jhc2ggdGhlIGJyb3dzZXIgYWZ0ZXIKK3RoZSBmcmFtZSBuYXZpZ2F0ZXMgYXdh eSBmcm9tIHRoZSBjdXJyZW50IHBhZ2UuPGJyPgorCitZb3Ugc2hvdWxkIG5vdCBzZWUgdGhpcyBt ZXNzYWdlIGlmIHRoZSB0ZXN0IHBhc3Nlcy48YnI+Cis8L0JPRFk+Cis8L0hUTUw+Cg== 28289 2009-03-04 15:43:59 -0800 2009-03-05 00:08:29 -0800 New test + result, no form submission 24339b.txt text/plain 2259 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQxNDM1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMt MDQgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0IGZvciBwb3RlbnRpYWwgY3Jh c2ggaW4gd2luZG93LmZyYW1lcy5sZW5ndGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI0MzM5CisKKyAgICAgICAgKiBmYXN0L2RvbS9XaW5kb3cvd2lu ZG93LWNvbGxlY3Rpb24tbGVuZ3RoLW5vLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9kb20vV2luZG93L3dpbmRvdy1jb2xsZWN0aW9uLWxlbmd0aC1uby1jcmFzaC5o dG1sOiBBZGRlZC4KKwogMjAwOS0wMy0wNCAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IGZh c3QvZG9tL1dpbmRvdy93aW5kb3ctY29sbGVjdGlvbi1sZW5ndGgtbm8tY3Jhc2gtZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ctY29sbGVjdGlvbi1sZW5n dGgtbm8tY3Jhc2gtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgZmFzdC9kb20vV2luZG93 L3dpbmRvdy1jb2xsZWN0aW9uLWxlbmd0aC1uby1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsNCBAQAorCisgCitUaGlzIHRlc3RzIHRoYXQgd2luZG93LmZyYW1lcy5s ZW5ndGggZG9lcyBub3QgY3Jhc2ggdGhlIGJyb3dzZXIgYWZ0ZXIgdGhlIGZyYW1lIG5hdmlnYXRl cyBhd2F5IGZyb20gdGhlIGN1cnJlbnQgcGFnZS4gWW91IHNob3VsZCBzZWUgIlNVQ0NFU1MiIGJl bG93IG9uY2UgdGhlIHRlc3QgY29tcGxldGVzLiAKK1NVQ0NFU1MKSW5kZXg6IGZhc3QvZG9tL1dp bmRvdy93aW5kb3ctY29sbGVjdGlvbi1sZW5ndGgtbm8tY3Jhc2guaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBmYXN0L2RvbS9XaW5kb3cvd2luZG93LWNvbGxlY3Rpb24tbGVuZ3RoLW5vLWNyYXNoLmh0bWwJ KHJldmlzaW9uIDApCisrKyBmYXN0L2RvbS9XaW5kb3cvd2luZG93LWNvbGxlY3Rpb24tbGVuZ3Ro LW5vLWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzIgQEAKKzxodG1sPgorPGhl YWQ+PC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxicj4KKzxpZnJh bWUgaWQ9InN1YmZyYW1lIj48cCBpZD0iY29udGVudHMiPlN1YmZyYW1lPC9wPjwvaWZyYW1lPgor PGJyPgorVGhpcyB0ZXN0cyB0aGF0IHdpbmRvdy5mcmFtZXMubGVuZ3RoIGRvZXMgbm90IGNyYXNo IHRoZSBicm93c2VyIGFmdGVyIHRoZQorZnJhbWUgbmF2aWdhdGVzIGF3YXkgZnJvbSB0aGUgY3Vy cmVudCBwYWdlLiBZb3Ugc2hvdWxkIHNlZSAiU1VDQ0VTUyIgYmVsb3cKK29uY2UgdGhlIHRlc3Qg Y29tcGxldGVzLgorPGJyPgorPGRpdiBpZD0ic3RhdHVzIj5UZXN0IGluIHByb2dyZXNzLi4uPC9k aXY+CisKKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAg d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICB3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCit2YXIgbXlGcmFtZXMgPSBz dWJmcmFtZS5mcmFtZXM7CisKK2Z1bmN0aW9uIGRvbmUoKSB7CisgICAgdmFyIGZvbyA9IG15RnJh bWVzLmxlbmd0aDsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3RhdHVzIikuaW5uZXJU ZXh0ID0gIlNVQ0NFU1MiOworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg ICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Cit9CisKK3N1 YmZyYW1lLmRvY3VtZW50LmxvY2F0aW9uID0gInJlc291cmNlcy9ub3RpZnktcGFyZW50LWRvbmUu aHRtbCI7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K