24337 2009-03-03 15:39:43 -0800 Assert when doing sync XHR in worker for cacheable response. 2009-12-23 14:38:54 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin ap robert oldest_to_newest 112090 0 levin 2009-03-03 15:39:43 -0800 For example: req = new XMLHttpRequest; req.open("GET", "missing-file", false); req.send(); 112099 1 levin 2009-03-03 16:29:22 -0800 I also found a way to get this same assert when doing a cross site async xhr request in a document. I'll attach both test cases and the fix. 112110 2 28249 levin 2009-03-03 17:15:47 -0800 Created attachment 28249 Proposed fix. 112161 3 28249 ap 2009-03-04 00:57:40 -0800 Comment on attachment 28249 Proposed fix. + if (window.layoutTestController) + layoutTestController.notifyDone(); + log("PASS"); The PASS string is printed after notifyDone(), so I'm very surprised it shows up in expected results. + if (m_sendResourceLoadCallbacks) + return frameLoader()->client()->willCacheResponse(documentLoader(), identifier(), response); + return 0; Our usual style is to do early return (if (!m_sendResourceLoadCallbacks) return 0;). Some say that's bad for performance though, so we may need to reconsider it eventually. I don't think this has much to do with the resource being missing - more likely, it's just that the response is cacheable, unlike what a CGI from methods.html sends. It would be nice to make this clearer in ChangeLog and test comments. r=me 112290 4 levin 2009-03-04 14:31:47 -0800 Committed as r41434. 174658 5 robert 2009-12-23 14:38:54 -0800 > + * http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added. > + * http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added. Hi David, As you can see from https://bugs.webkit.org/show_bug.cgi?id=32521 I'm a bit confused about what the above test is meant to prove. I should have looked it up in the logs a long time ago! If I'm reading the bug correctly, it is possible to perform an async xhr where m_sendResourceLoadCallbacks is false and in such cases this test will ensure it doesn't trigger an assert on the Mac port. On Qt and Gtk at least, m_sendResourceLoadCallbacks is true when this test is run and it wouldn't touch the patched code in any event. So is this test Mac specific, or is it testing something in more general WebCore? Thanks for any light you can shed on this. 28249 2009-03-03 17:15:47 -0800 2009-03-04 00:57:40 -0800 Proposed fix. bug24337.txt text/plain 6987 levin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0MWEwNDRmLi5jMjMzNWIyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDMt MDMgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyNDMzNzogQXNzZXJ0IHdoZW4gZG9p bmcgWEhSIGZvciBtaXNzaW5nIGZpbGUgaW4gd29ya2VyLgorICAgICAgICA8aHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MzM3PgorCisgICAgICAgICogaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC9hY2Nlc3MtY29udHJvbC1iYXNpYy1kZW5pZWQtcHJlZmxpZ2h0LWNh Y2hlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVx dWVzdC9hY2Nlc3MtY29udHJvbC1iYXNpYy1kZW5pZWQtcHJlZmxpZ2h0LWNhY2hlLmh0bWw6IEFk ZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy9yZXNvdXJj ZXMveG1saHR0cHJlcXVlc3QtZmlsZS1ub3QtZm91bmQuanM6IEFkZGVkLgorICAgICAgICAobG9n KToKKyAgICAgICAgKGRvbmUpOgorICAgICAgICAqIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv d29ya2Vycy94bWxodHRwcmVxdWVzdC1maWxlLW5vdC1mb3VuZC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy94bWxodHRwcmVx dWVzdC1maWxlLW5vdC1mb3VuZC5odG1sOiBBZGRlZC4KKwogMjAwOS0wMy0wMSAgRGF2aWQgTGV2 aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFBy b3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJl cXVlc3QvYWNjZXNzLWNvbnRyb2wtYmFzaWMtZGVuaWVkLXByZWZsaWdodC1jYWNoZS1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2FjY2Vzcy1jb250 cm9sLWJhc2ljLWRlbmllZC1wcmVmbGlnaHQtY2FjaGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjJlMTc1YjkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2FjY2Vzcy1jb250cm9sLWJhc2ljLWRl bmllZC1wcmVmbGlnaHQtY2FjaGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGVzdCBh c3luYyB4aHIgcHJlZmxpZ2h0IGNhY2hlIGRlbmlhbC4gSWYgdGhpcyB0ZXN0IHBhc3NlcywgdGhl cmUgc2hvdWxkIGJlIGEgc2luZ2xlIFBBU1MgYmVsb3cuCisKK1BBU1MKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtYmFzaWMt ZGVuaWVkLXByZWZsaWdodC1jYWNoZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxo dHRwcmVxdWVzdC9hY2Nlc3MtY29udHJvbC1iYXNpYy1kZW5pZWQtcHJlZmxpZ2h0LWNhY2hlLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMzk5MjdmMQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNv bnRyb2wtYmFzaWMtZGVuaWVkLXByZWZsaWdodC1jYWNoZS5odG1sCkBAIC0wLDAgKzEsMzggQEAK KzxodG1sPgorPGJvZHk+Cis8cD5UZXN0IGFzeW5jIHhociBwcmVmbGlnaHQgY2FjaGUgZGVuaWFs LiAgSWYgdGhpcyB0ZXN0IHBhc3NlcywgdGhlcmUgc2hvdWxkIGJlIGEgc2luZ2xlIFBBU1MgYmVs b3cuPC9wPgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7 CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIH0KKworICAgIHZhciBjb25z b2xlX21lc3NhZ2VzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidWwiKTsKKyAgICBkb2N1bWVu dC5ib2R5LmFwcGVuZENoaWxkKGNvbnNvbGVfbWVzc2FnZXMpOworCisgICAgZnVuY3Rpb24gbG9n KG1lc3NhZ2UpCisgICAgeworICAgICAgICB2YXIgaXRlbSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoImxpIik7CisgICAgICAgIGl0ZW0uYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5v ZGUobWVzc2FnZSkpOworICAgICAgICBjb25zb2xlX21lc3NhZ2VzLmFwcGVuZENoaWxkKGl0ZW0p OworICAgIH0KKworICAgIHhociA9IG5ldyBYTUxIdHRwUmVxdWVzdDsKKyAgICB4aHIub25yZWFk eXN0YXRlY2hhbmdlID0gcHJvY2Vzc1N0YXRlQ2hhbmdlOworICAgIHRyeSB7CisgICAgICAgIHho ci5vcGVuKCJGT08iLCAiaHR0cDovL2xvY2FsaG9zdDo4MDAwL3htbGh0dHByZXF1ZXN0L3Jlc291 cmNlcy9hY2Nlc3MtY29udHJvbC1iYXNpYy1kZW5pZWQuY2dpIik7CisgICAgICAgIHhoci5zZW5k KCk7CisgICAgfSBjYXRjaCAoZSkgeworICAgICAgICBsb2coIkdvdCBleGNlcHRpb24uIik7Cisg ICAgfQorCisgICAgZnVuY3Rpb24gcHJvY2Vzc1N0YXRlQ2hhbmdlKCkgeworICAgICAgICBpZiAo eGhyLnJlYWR5U3RhdGUgPT0gMSkgeworICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlE b25lKCk7CisgICAgICAgICAgICBsb2coIlBBU1MiKTsKKyAgICAgICAgfQorICAgIH0KKzwvc2Ny aXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC93b3JrZXJzL3Jlc291cmNlcy94bWxodHRwcmVxdWVzdC1maWxlLW5v dC1mb3VuZC5qcyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vy cy9yZXNvdXJjZXMveG1saHR0cHJlcXVlc3QtZmlsZS1ub3QtZm91bmQuanMKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMDdmZWE2NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy9yZXNvdXJjZXMveG1saHR0 cHJlcXVlc3QtZmlsZS1ub3QtZm91bmQuanMKQEAgLTAsMCArMSwxOCBAQAorZnVuY3Rpb24gbG9n KG1lc3NhZ2UpCit7CisgICAgcG9zdE1lc3NhZ2UoImxvZyAiICsgbWVzc2FnZSk7Cit9CisKK2Z1 bmN0aW9uIGRvbmUoKQoreworICAgIHBvc3RNZXNzYWdlKCJET05FIik7Cit9CisKK3JlcSA9IG5l dyBYTUxIdHRwUmVxdWVzdDsKK3RyeSB7CisgICAgcmVxLm9wZW4oIkdFVCIsICJtaXNzaW5nLWZp bGUiLCBmYWxzZSk7CisgICAgcmVxLnNlbmQoKTsKK30gY2F0Y2ggKGUpIHsKKyAgICBsb2coIkV4 Y2VwdGlvbiByZWNlaXZlZC4iKTsKK30KK2RvbmUoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy94bWxodHRwcmVxdWVzdC1maWxlLW5v dC1mb3VuZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L3dvcmtlcnMveG1saHR0cHJlcXVlc3QtZmlsZS1ub3QtZm91bmQtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmY0ZDQxNmEKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3dvcmtlcnMveG1saHR0 cHJlcXVlc3QtZmlsZS1ub3QtZm91bmQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorUmVx dWVzdCBhIGZpbGUgdGhhdCBpc24ndCBwcmVzZW50IG9uIHRoZSBzZXJ2ZXIgaW4gWE1MSHR0cFJl cXVlc3QgaW4gYSBXb3JrZXJzLiBJZiB0aGlzIHRlc3QgcGFzc2VzLCB0aGVyZSBzaG91bGQgYmUg YSBzaW5nbGUgUEFTUyBiZWxvdy4KKworUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy94bWxodHRwcmVxdWVzdC93b3JrZXJzL3htbGh0dHByZXF1ZXN0LWZpbGUtbm90LWZv dW5kLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3dvcmtlcnMv eG1saHR0cHJlcXVlc3QtZmlsZS1ub3QtZm91bmQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi4wMmEwOWZhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy94bWxodHRwcmVxdWVzdC93b3JrZXJzL3htbGh0dHByZXF1ZXN0LWZpbGUtbm90LWZv dW5kLmh0bWwKQEAgLTAsMCArMSwzMyBAQAorPGh0bWw+Cis8Ym9keT4KKzxwPlJlcXVlc3QgYSBm aWxlIHRoYXQgaXNuJ3QgcHJlc2VudCBvbiB0aGUgc2VydmVyIGluIFhNTEh0dHBSZXF1ZXN0IGlu IGEgV29ya2Vycy4gIElmIHRoaXMgdGVzdCBwYXNzZXMsIHRoZXJlIHNob3VsZCBiZSBhIHNpbmds ZSBQQVNTIGJlbG93LjwvcD4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cisg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisgICAg CisgICAgdmFyIGNvbnNvbGVfbWVzc2FnZXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ1bCIp OworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoY29uc29sZV9tZXNzYWdlcyk7CisgICAg CisgICAgZnVuY3Rpb24gbG9nKG1lc3NhZ2UpCisgICAgeworICAgICAgICB2YXIgaXRlbSA9IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImxpIik7CisgICAgICAgIGl0ZW0uYXBwZW5kQ2hpbGQoZG9j dW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2FnZSkpOworICAgICAgICBjb25zb2xlX21lc3NhZ2Vz LmFwcGVuZENoaWxkKGl0ZW0pOworICAgIH0KKworICAgIHZhciB3b3JrZXIgPSBuZXcgV29ya2Vy KCdyZXNvdXJjZXMveG1saHR0cHJlcXVlc3QtZmlsZS1ub3QtZm91bmQuanMnKTsKKyAgICB3b3Jr ZXIub25tZXNzYWdlID0gZnVuY3Rpb24oZXZ0KQorICAgIHsKKyAgICAgICAgaWYgKC9sb2cgLisv LnRlc3QoZXZ0LmRhdGEpKQorICAgICAgICAgICAgbG9nKGV2dC5kYXRhLnN1YnN0cig0KSk7Cisg ICAgICAgIGVsc2UgaWYgKC9ET05FLy50ZXN0KGV2dC5kYXRhKSkgeworICAgICAgICAgICAgbG9n KCJQQVNTIik7CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICAg ICAgfQorICAgIH0KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5YzBlM2M3Li40MTU5NGE1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE4IEBACisyMDA5LTAzLTAzICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBC dWcgMjQzMzc6IEFzc2VydCB3aGVuIGRvaW5nIFhIUiBmb3IgbWlzc2luZyBmaWxlIGluIHdvcmtl ci4KKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDMz Nz4KKworICAgICAgICBUZXN0czogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9hY2Nlc3MtY29u dHJvbC1iYXNpYy1kZW5pZWQtcHJlZmxpZ2h0LWNhY2hlLmh0bWwKKyAgICAgICAgICAgICAgIGh0 dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy94bWxodHRwcmVxdWVzdC1maWxlLW5vdC1m b3VuZC5odG1sCisKKyAgICAgICAgKiBsb2FkZXIvbWFjL1Jlc291cmNlTG9hZGVyTWFjLm1tOgor ICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OndpbGxDYWNoZVJlc3BvbnNlKToKKyAg ICAgICAgQW4gaWRlbnRpZmllciBpcyBvbmx5IGFzc3NpZ25lZCBpZiByZXNvdXJjZSBsb2FkIGNh bGxiYWNrcyBhcmUgZG9uZS4gIFNvIGRvbid0IHNlbmQKKyAgICAgICAgd2lsbENhY2hlUmVzcG9u c2Ugd2hpY2ggdXNlcyBpZGVudGlmaWVyIGlmIHJlc291cmNlIGxvYWQgY2FsbGJhY2tzIGFyZW4n dCBiZWluZyBzZW50LgorCiAyMDA5LTAzLTAyICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFyayBSb3dlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9s b2FkZXIvbWFjL1Jlc291cmNlTG9hZGVyTWFjLm1tIGIvV2ViQ29yZS9sb2FkZXIvbWFjL1Jlc291 cmNlTG9hZGVyTWFjLm1tCmluZGV4IGQ2ZWU5MjMuLjEwNzRkODMgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvbG9hZGVyL21hYy9SZXNvdXJjZUxvYWRlck1hYy5tbQorKysgYi9XZWJDb3JlL2xvYWRlci9t YWMvUmVzb3VyY2VMb2FkZXJNYWMubW0KQEAgLTM3LDcgKzM3LDkgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogCiBOU0NhY2hlZFVSTFJlc3BvbnNlKiBSZXNvdXJjZUxvYWRlcjo6d2lsbENhY2hlUmVz cG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBOU0NhY2hlZFVSTFJlc3BvbnNlKiByZXNwb25zZSkKIHsK LSAgICByZXR1cm4gZnJhbWVMb2FkZXIoKS0+Y2xpZW50KCktPndpbGxDYWNoZVJlc3BvbnNlKGRv Y3VtZW50TG9hZGVyKCksIGlkZW50aWZpZXIoKSwgcmVzcG9uc2UpOworICAgIGlmIChtX3NlbmRS ZXNvdXJjZUxvYWRDYWxsYmFja3MpCisgICAgICAgIHJldHVybiBmcmFtZUxvYWRlcigpLT5jbGll bnQoKS0+d2lsbENhY2hlUmVzcG9uc2UoZG9jdW1lbnRMb2FkZXIoKSwgaWRlbnRpZmllcigpLCBy ZXNwb25zZSk7CisgICAgcmV0dXJuIDA7CiB9CiAKIH0K