243286 2022-07-27 23:55:21 -0700 AX: AccessibilityObject::accessibilityVisibleCharacterRange misses the first line of a paragraph split across pages (part two) 2022-07-28 11:17:29 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=242880 InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1887283 0 tyler_w 2022-07-27 23:55:21 -0700 In https://bugs.webkit.org/show_bug.cgi?id=242880, we made a change that prevented this issue in some (in reality, only a few) cases. However, after further testing, I've found other cases that are not fixed. 1887284 1 webkit-bug-importer 2022-07-27 23:55:31 -0700 <rdar://problem/97706360> 1887288 2 461266 tyler_w 2022-07-28 00:06:34 -0700 Created attachment 461266 Patch 1887373 3 461266 cfleizach 2022-07-28 10:22:34 -0700 Comment on attachment 461266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461266&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:845 > + float lastX = elementRect.x(); do we want the MaxX here of the rect rather than the origin? 1887375 4 tyler_w 2022-07-28 10:27:22 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 461266 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461266&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:845 > > + float lastX = elementRect.x(); > > do we want the MaxX here of the rect rather than the origin? I don't think so as maxX includes width, which we expect to not be consistent (because paragraphs will extend different lengths down the line). So it wouldn't be a good indicator that we've crossed a viewport boundary. 1887385 5 ews-feeder 2022-07-28 11:17:27 -0700 Committed 252920@main (f59072f13d29): <https://commits.webkit.org/252920@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461266. 461266 2022-07-28 00:06:34 -0700 2022-07-28 11:17:28 -0700 Patch bug-243286-20220728000633.patch text/plain 4255 tyler_w RnJvbSA2ZWJlZmI0MTlkMmY0ZDQ4ZWFjNWJjNzI3MTEzMmU0MTcxNzU0ZWQzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUeWxlciBXaWxjb2NrIDx0eWxlcl93QGFwcGxlLmNvbT4KRGF0 ZTogV2VkLCAyNyBKdWwgMjAyMiAyMzo1NTo1MCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEFYOiBB Y2Nlc3NpYmlsaXR5T2JqZWN0OjphY2Nlc3NpYmlsaXR5VmlzaWJsZUNoYXJhY3RlclJhbmdlCiBt aXNzZXMgdGhlIGZpcnN0IGxpbmUgb2YgYSBwYXJhZ3JhcGggc3BsaXQgYWNyb3NzIHBhZ2VzIChw YXJ0IHR3bykKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDMyODYK ClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKSW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI0Mjg4MCwgd2UgbWFkZSBhIGNoYW5nZSB0aGF0IHByZXZlbnRlZAp0 aGlzIGlzc3VlIGluIHNvbWUgKGluIHJlYWxpdHksIG9ubHkgYSBmZXcpIGNhc2VzLiBIb3dldmVy LCBhZnRlciBmdXJ0aGVyIHRlc3RpbmcsCkkndmUgZm91bmQgb3RoZXIgY2FzZXMgdGhhdCBhcmUg bm90IGZpeGVkLgoKVGhpcyBwYXRjaCBmaXhlcyB0aGlzIGJ5IGNoZWNraW5nIHRoZSB4LWNvb3Jk aW5hdGUgb2YgdGhlIGVsZW1lbnQgcmVjdCBpbiBlYWNoIGl0ZXJhdGlvbgpvZiB0aGUgbGluZS1i eS1saW5lIHN0YXJ0IGJvdW5kYXJ5IHNocmlua2luZy4gSWYgaXQgaGFzIGNoYW5nZWQgKGkuZS4g YmVjYXVzZSB0aGUgcmVjdCBpcyBub3cKb24gYSBuZXcgInBhZ2UiIG9yIG90aGVyIHZpZXdwb3J0 IGJvdW5kYXJ5KSwgd2Uga25vdyB3ZSBzaG91bGQgc3RvcC4gUHJpb3IgdG8gdGhpcyBwYXRjaCwg d2UKZGlkIG5vdCBzdG9wIGhlcmUsIGFuZCB3b3VsZCBvZnRlbiBzaHJpbmsgb25lIGxpbmUgdG9v IG1hbnkuCgpUaGlzIGJlaGF2aW9yIGNoYW5nZSBpcyBvbmx5IGltcGxlbWVudGVkIGZvciBlbGVt ZW50cyB3aXRoIGEgaG9yaXpvbnRhbCB3cml0aW5nIG1vZGUgKHNpbmNlCmEgdmVydGljYWwgd3Jp dGluZyBtb2RlIHdvdWxkIHJlcXVpcmUgZGlmZmVyZW50IGNvb3JkaW5hdGUgY29tcGFyaXNvbnMp LgoKVGhpcyBjaGFuZ2UgaGFzIGJlZW4gbWFudWFsbHkgdGVzdGVkLgoKKiBTb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwOgooV2ViQ29yZTo6c3R5bGVG cm9tTm9kZSk6CihXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0Ojp2aXNpYmxlQ2hhcmFjdGVy UmFuZ2VJbnRlcm5hbCBjb25zdCk6Ci0tLQogLi4uL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eU9iamVjdC5jcHAgICAgIHwgMzQgKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDM0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRleCBjZGRjZmE1Mjc4N2MuLjAxYjNhZjk5NzFl OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlPYmplY3QuY3BwCkBAIC04MDQsNiArODA0LDIxIEBAIHN0ZDo6b3B0aW9uYWw8U2ltcGxlUmFu Z2U+IEFjY2Vzc2liaWxpdHlPYmplY3Q6OnZpc2libGVDaGFyYWN0ZXJSYW5nZSgpIGNvbnN0CiAg ICAgcmV0dXJuIGNvbXB1dGVkUmFuZ2U7CiB9CiAKKyNpZiBQTEFURk9STShJT1NfRkFNSUxZKQor c3RhdGljIGNvbnN0IFJlbmRlclN0eWxlKiBzdHlsZUZyb21Ob2RlKE5vZGUqIG5vZGUpCit7Cisg ICAgaWYgKGF1dG8qIHRleHROb2RlID0gZHluYW1pY0Rvd25jYXN0PFRleHQ+KG5vZGUpKSB7Cisg ICAgICAgIGlmIChhdXRvKiByZW5kZXJlciA9IHRleHROb2RlLT5yZW5kZXJlcigpKQorICAgICAg ICAgICAgcmV0dXJuICZyZW5kZXJlci0+c3R5bGUoKTsKKyAgICB9CisKKyAgICBpZiAoYXV0byog ZWxlbWVudCA9IGR5bmFtaWNEb3duY2FzdDxFbGVtZW50Pihub2RlKSkKKyAgICAgICAgcmV0dXJu IGVsZW1lbnQtPmNvbXB1dGVkU3R5bGUoKTsKKworICAgIHJldHVybiBudWxscHRyOworfQorI2Vu ZGlmCisKIHN0ZDo6b3B0aW9uYWw8U2ltcGxlUmFuZ2U+IEFjY2Vzc2liaWxpdHlPYmplY3Q6OnZp c2libGVDaGFyYWN0ZXJSYW5nZUludGVybmFsKGNvbnN0IHN0ZDo6b3B0aW9uYWw8U2ltcGxlUmFu Z2U+JiByYW5nZSwgY29uc3QgRmxvYXRSZWN0JiBjb250ZW50UmVjdCwgY29uc3QgSW50UmVjdCYg c3RhcnRpbmdFbGVtZW50UmVjdCkgY29uc3QKIHsKICAgICBpZiAoIXJhbmdlIHx8ICFjb250ZW50 UmVjdC5pbnRlcnNlY3RzKHN0YXJ0aW5nRWxlbWVudFJlY3QpKQpAQCAtODEzLDYgKzgyOCwxMiBA QCBzdGQ6Om9wdGlvbmFsPFNpbXBsZVJhbmdlPiBBY2Nlc3NpYmlsaXR5T2JqZWN0Ojp2aXNpYmxl Q2hhcmFjdGVyUmFuZ2VJbnRlcm5hbChjbwogICAgIGF1dG8gc3RhcnRCb3VuZGFyeSA9IHJhbmdl LT5zdGFydDsKICAgICBhdXRvIGVuZEJvdW5kYXJ5ID0gcmFuZ2UtPmVuZDsKIAorI2lmIFBMQVRG T1JNKElPU19GQU1JTFkpCisgICAgYXV0byogc3R5bGUgPSBzdHlsZUZyb21Ob2RlKG5vZGUoKSk7 CisgICAgLy8gSWYgd2UgY2FuJ3QgZ2V0IHN0eWxlIGZvciB0aGlzIG9iamVjdCwgYXNzdW1lIGEg aG9yaXpvbnRhbCB3cml0aW5nIG1vZGUuCisgICAgYm9vbCBpc0hvcml6b250YWxXcml0aW5nTW9k ZSA9IHN0eWxlID8gc3R5bGUtPmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkgOiB0cnVlOworI2Vu ZGlmCisKICAgICAvLyBPcmlnaW4gaXNuJ3QgY29udGFpbmVkIGluIHZpc2libGUgcmVjdCwgc3Rh cnQgbW92aW5nIGZvcndhcmQgYnkgbGluZS4KICAgICB3aGlsZSAoIWNvbnRlbnRSZWN0LmNvbnRh aW5zKGVsZW1lbnRSZWN0LmxvY2F0aW9uKCkpKSB7CiAgICAgICAgIGF1dG8gbmV4dExpbmVQb3Np dGlvbiA9IG5leHRMaW5lRW5kUG9zaXRpb24oVmlzaWJsZVBvc2l0aW9uKG1ha2VDb250YWluZXJP ZmZzZXRQb3NpdGlvbihzdGFydEJvdW5kYXJ5KSkpOwpAQCAtODIwLDEwICs4NDEsMjMgQEAgc3Rk OjpvcHRpb25hbDxTaW1wbGVSYW5nZT4gQWNjZXNzaWJpbGl0eU9iamVjdDo6dmlzaWJsZUNoYXJh Y3RlclJhbmdlSW50ZXJuYWwoY28KICAgICAgICAgaWYgKCF0ZXN0U3RhcnRCb3VuZGFyeSB8fCAh Y29udGFpbnMoKnJhbmdlLCAqdGVzdFN0YXJ0Qm91bmRhcnkpKQogICAgICAgICAgICAgYnJlYWs7 CiAKKyNpZiBQTEFURk9STShJT1NfRkFNSUxZKQorICAgICAgICBmbG9hdCBsYXN0WCA9IGVsZW1l bnRSZWN0LngoKTsKKyNlbmRpZgorCisgICAgICAgIC8vIHRlc3RTdGFydEJvdW5kYXJ5IGlzIHZh bGlkLCBzbyBjb21taXQgaXQgYW5kIHVwZGF0ZSB0aGUgZWxlbWVudFJlY3QuCiAgICAgICAgIHN0 YXJ0Qm91bmRhcnkgPSAqdGVzdFN0YXJ0Qm91bmRhcnk7CiAgICAgICAgIGVsZW1lbnRSZWN0ID0g Ym91bmRzRm9yUmFuZ2UoU2ltcGxlUmFuZ2Uoc3RhcnRCb3VuZGFyeSwgcmFuZ2UtPmVuZCkpOwog ICAgICAgICBpZiAoZWxlbWVudFJlY3QuaXNFbXB0eSgpIHx8IGVsZW1lbnRSZWN0LngoKSA8IDAg fHwgZWxlbWVudFJlY3QueSgpIDwgMCkKICAgICAgICAgICAgIGJyZWFrOworCisjaWYgUExBVEZP Uk0oSU9TX0ZBTUlMWSkKKyAgICAgICAgLy8gSWYgdGhlIHgtY29vcmRpbmF0ZSBvZiB0aGUgZWxl bWVudCdzIGZyYW1lIGhhcyBncm93biwgd2Ugc2hvdWxkIGJyZWFrIGJlY2F1c2UgdGhhdCBsaWtl bHkgbWVhbnMKKyAgICAgICAgLy8gd2UgaGF2ZSBjcm9zc2VkIGEgdmlld3BvcnQgYm91bmRhcnkg KGUuZy4gbW92ZWQgdG8gYSBuZXcgcGFnZSBpbiBCb29rcykuCisgICAgICAgIC8vIEZJWE1FOiBX ZSBzaG91bGQgaW52ZXN0aWdhdGUgZnVydGhlciB0byB1bmRlcnN0YW5kIGlmIHRoaXMgaXMgdGhl IGNvcnJlY3QgYmVoYXZpb3IgZm9yIGFsbCBwbGF0Zm9ybXMuCisgICAgICAgIGlmIChpc0hvcml6 b250YWxXcml0aW5nTW9kZSAmJiBsYXN0WCA8IGVsZW1lbnRSZWN0LngoKSkKKyAgICAgICAgICAg IGJyZWFrOworI2VuZGlmCiAgICAgfQogCiAgICAgLy8gQ29tcHV0aW5nIHByZXZpb3VzIGxpbmUg c3RhcnQgcG9zaXRpb25zIGlzIGNoZWFwIHJlbGF0aXZlIHRvIGNvbXB1dGluZyBib3VuZHNGb3JS YW5nZSwgc28gY29tcHV0ZSB0aGUgZW5kIGJvdW5kYXJ5IGJ5Cg==