24327 2009-03-03 10:12:40 -0800 Fix hit testing on elements running accelerated transform animations 2009-03-05 11:40:11 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 23359 1 simon.fraser simon.fraser cmarrin oldest_to_newest 112029 0 simon.fraser 2009-03-03 10:12:40 -0800 In implementing 3d hit testing, I broke the hit testing on elements running accelerated animations. This needs to be fixed in a more central location. 112303 1 28287 simon.fraser 2009-03-04 15:26:31 -0800 Created attachment 28287 Patch, changelog 112329 2 28287 eric 2009-03-04 17:27:41 -0800 Comment on attachment 28287 Patch, changelog Since you never seem to use the "has a transform" bool return, why not just have it return a TransformationMatrix object instead of passing one by reference? Seems cleaner to return one to me. Otherwise looks fine. You should add a comment to the ChangeLog that the test case in question only fails when ACCELLERATED_COMPOSITING is turned on. 112335 3 28296 simon.fraser 2009-03-04 18:32:46 -0800 Created attachment 28296 Revised patch 112406 4 28296 hyatt 2009-03-05 11:09:12 -0800 Comment on attachment 28296 Revised patch r=me 112418 5 simon.fraser 2009-03-05 11:40:11 -0800 http://trac.webkit.org/changeset/41455 28287 2009-03-04 15:26:31 -0800 2009-03-04 20:17:41 -0800 Patch, changelog 24327_patch.txt text/plain 3730 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWFjNjU2ZS4uNmRjOGYyMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAwOS0wMy0wNCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQzMjcKKyAgICAgICAgCisgICAgICAgIFdoZW4gbWFwcGluZyBwb2ludHMgYW5kIGhpdCB0 ZXN0aW5nIHRocm91Z2ggdHJhbnNmb3Jtcywgd29yaworICAgICAgICBjb3JyZWN0bHkgd2hlbiBh Y2NsZXJhdGVkIGFuaW1hdGlvbnMgb2YgdHJhbnNmb3JtcyBhcmUgcnVubmluZy4KKyAgICAgICAg CisgICAgICAgIFRlc3RlZCBieSBMYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1oaXQt dGVzdC10cmFuc2Zvcm0uaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjdXJyZW50VHJhbnNmb3JtKToKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6dHJhbnNmb3Jt RnJvbUNvbnRhaW5lcik6CisKIDIwMDktMDMtMDQgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYg LS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggYTllMGQzNi4uOTZhNWNhZiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcApAQCAtMzQxLDYgKzM0MSwyMiBAQCB2b2lkIFJlbmRlckxheWVyOjp1 cGRhdGVUcmFuc2Zvcm0oKQogICAgICAgICBkaXJ0eTNEVHJhbnNmb3JtZWREZXNjZW5kYW50U3Rh dHVzKCk7CiB9CiAKK2Jvb2wgUmVuZGVyTGF5ZXI6OmN1cnJlbnRUcmFuc2Zvcm0oVHJhbnNmb3Jt YXRpb25NYXRyaXgmIHRyYW5zZm9ybSkgY29uc3QKK3sKKyAgICBpZiAoIW1fdHJhbnNmb3JtKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcp CisgICAgaWYgKHJlbmRlcmVyKCktPnN0eWxlKCktPmlzUnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0 aW9uKCkpIHsKKyAgICAgICAgUmVmUHRyPFJlbmRlclN0eWxlPiBzdHlsZSA9IHJlbmRlcmVyKCkt PmFuaW1hdGlvbigpLT5nZXRBbmltYXRlZFN0eWxlRm9yUmVuZGVyZXIocmVuZGVyZXIoKSk7Cisg ICAgICAgIHN0eWxlLT5hcHBseVRyYW5zZm9ybSh0cmFuc2Zvcm0sIHJlbmRlckJveCgpLT5ib3Jk ZXJCb3hSZWN0KCkuc2l6ZSgpLCBSZW5kZXJTdHlsZTo6SW5jbHVkZVRyYW5zZm9ybU9yaWdpbik7 CisgICAgfSBlbHNlCisjZW5kaWYKKyAgICAgICAgdHJhbnNmb3JtID0gKm1fdHJhbnNmb3JtLmdl dCgpOworICAgICAgICAKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogdm9pZCBSZW5kZXJMYXllcjo6 c2V0SGFzVmlzaWJsZUNvbnRlbnQoYm9vbCBiKQogeyAKICAgICBpZiAobV9oYXNWaXNpYmxlQ29u dGVudCA9PSBiICYmICFtX3Zpc2libGVDb250ZW50U3RhdHVzRGlydHkpCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuaAppbmRleCA0ZDBiNGI1Li40ZDgxNTc4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllci5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgK QEAgLTQwMSw2ICs0MDEsMTAgQEAgcHVibGljOgogICAgIGJvb2wgaGFzVHJhbnNmb3JtKCkgY29u c3QgeyByZXR1cm4gcmVuZGVyZXIoKS0+aGFzVHJhbnNmb3JtKCk7IH0KICAgICAvLyBOb3RlIHRo YXQgdGhpcyB0cmFuc2Zvcm0gaGFzIHRoZSB0cmFuc2Zvcm0tb3JpZ2luIGJha2VkIGluLgogICAg IFRyYW5zZm9ybWF0aW9uTWF0cml4KiB0cmFuc2Zvcm0oKSBjb25zdCB7IHJldHVybiBtX3RyYW5z Zm9ybS5nZXQoKTsgfQorICAgIC8vIGN1cnJlbnRUcmFuc2Zvcm0gY29tcHV0ZXMgYSB0cmFuc2Zv cm0gd2hpY2ggdGFrZXMgYWNjZWxlcmF0ZWQgYW5pbWF0aW9ucyBpbnRvIGFjY291bnQuIFRoZQor ICAgIC8vIHJlc3VsdGluZyB0cmFuc2Zvcm0gaGFzIHRyYW5zZm9ybS1vcmlnaW4gYmFrZWQgaW4u IFJldHVybnMgdHJ1ZSBpZiB0aGUgbGF5ZXIgaGFzIGEgdHJhbnNmb3JtLgorICAgIGJvb2wgY3Vy cmVudFRyYW5zZm9ybShUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgdHJhbnNmb3JtKSBjb25zdDsKKyAg ICAKICAgICAvLyBHZXQgdGhlIHBlcnNwZWN0aXZlIHRyYW5zZm9ybSwgd2hpY2ggaXMgYXBwbGll ZCB0byB0cmFuc2Zvcm1lZCBzdWJsYXllcnMuCiAgICAgLy8gUmV0dXJucyB0cnVlIGlmIHRoZSBs YXllciBoYXMgYSAtd2Via2l0LXBlcnNwZWN0aXZlLgogICAgIC8vIE5vdGUgdGhhdCB0aGlzIHRy YW5zZm9ybSBoYXMgdGhlIHBlcnNwZWN0aXZlLW9yaWdpbiBiYWtlZCBpbi4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJPYmplY3QuY3BwCmluZGV4IDE2NzJmZWIuLmYyNjRjNDIgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmNwcApAQCAtMTY4Nyw4ICsxNjg3LDExIEBAIFRyYW5zZm9ybWF0aW9uTWF0cml4 IFJlbmRlck9iamVjdDo6dHJhbnNmb3JtRnJvbUNvbnRhaW5lcihjb25zdCBSZW5kZXJPYmplY3Qq IGNvCiAgICAgVHJhbnNmb3JtYXRpb25NYXRyaXggY29udGFpbmVyVHJhbnNmb3JtOwogICAgIGNv bnRhaW5lclRyYW5zZm9ybS50cmFuc2xhdGUob2Zmc2V0SW5Db250YWluZXIud2lkdGgoKSwgb2Zm c2V0SW5Db250YWluZXIuaGVpZ2h0KCkpOwogICAgIFJlbmRlckxheWVyKiBsYXllcjsKLSAgICBp ZiAoaGFzTGF5ZXIoKSAmJiAobGF5ZXIgPSB0b1JlbmRlckJveCh0aGlzKS0+bGF5ZXIoKSkgJiYg bGF5ZXItPnRyYW5zZm9ybSgpKQotICAgICAgICBjb250YWluZXJUcmFuc2Zvcm0ubXVsdExlZnQo KmxheWVyLT50cmFuc2Zvcm0oKSk7CisgICAgaWYgKGhhc0xheWVyKCkgJiYgKGxheWVyID0gdG9S ZW5kZXJCb3godGhpcyktPmxheWVyKCkpICYmIGxheWVyLT50cmFuc2Zvcm0oKSkgeworICAgICAg ICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCBjdXJUcmFuc2Zvcm07CisgICAgICAgIGxheWVyLT5jdXJy ZW50VHJhbnNmb3JtKGN1clRyYW5zZm9ybSk7CisgICAgICAgIGNvbnRhaW5lclRyYW5zZm9ybS5t dWx0TGVmdChjdXJUcmFuc2Zvcm0pOworICAgIH0KICAgICAKICAgICBpZiAoY29udGFpbmVyT2Jq ZWN0ICYmIGNvbnRhaW5lck9iamVjdC0+c3R5bGUoKS0+aGFzUGVyc3BlY3RpdmUoKSkgewogICAg ICAgICAvLyBQZXJwc2VjdGl2ZSBvbiB0aGUgY29udGFpbmVyIGFmZmVjdHMgdXMsIHNvIHdlIGhh dmUgdG8gZmFjdG9yIGl0IGluIGhlcmUuCg== 28296 2009-03-04 18:32:46 -0800 2009-03-05 11:09:12 -0800 Revised patch 24327_patch.txt text/plain 3629 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmU2MDVjMy4uZjljYzI0MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wMy0wNCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQzMjcKKyAgICAgICAgCisgICAgICAgIFdoZW4gbWFwcGluZyBwb2ludHMgYW5kIGhpdCB0 ZXN0aW5nIHRocm91Z2ggdHJhbnNmb3Jtcywgd29yaworICAgICAgICBjb3JyZWN0bHkgd2hlbiBh Y2NsZXJhdGVkIGFuaW1hdGlvbnMgb2YgdHJhbnNmb3JtcyBhcmUgcnVubmluZy4KKyAgICAgICAg CisgICAgICAgIFRlc3RlZCBieSBMYXlvdXRUZXN0cy9hbmltYXRpb25zL2FuaW1hdGlvbi1oaXQt dGVzdC10cmFuc2Zvcm0uaHRtbCwKKyAgICAgICAgd2hpY2ggb25seSBmYWlsZWQgd2hlbiBBQ0NF TEVSQVRFRF9DT01QT1NJVElORyB3YXMgdHVybmVkIG9uLgorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjdXJyZW50 VHJhbnNmb3JtKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaDoKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9i amVjdDo6dHJhbnNmb3JtRnJvbUNvbnRhaW5lcik6CisKIDIwMDktMDMtMDQgIEFkYW0gTGFuZ2xl eSAgPGFnbEBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCBhOWUwZDM2Li43NjIyMDI5IDEwMDY0NAot LS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0zNDEsNiArMzQxLDIzIEBAIHZvaWQgUmVuZGVyTGF5 ZXI6OnVwZGF0ZVRyYW5zZm9ybSgpCiAgICAgICAgIGRpcnR5M0RUcmFuc2Zvcm1lZERlc2NlbmRh bnRTdGF0dXMoKTsKIH0KIAorVHJhbnNmb3JtYXRpb25NYXRyaXggUmVuZGVyTGF5ZXI6OmN1cnJl bnRUcmFuc2Zvcm0oKSBjb25zdAoreworICAgIGlmICghbV90cmFuc2Zvcm0pCisgICAgICAgIHJl dHVybiBUcmFuc2Zvcm1hdGlvbk1hdHJpeCgpOworCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBP U0lUSU5HKQorICAgIGlmIChyZW5kZXJlcigpLT5zdHlsZSgpLT5pc1J1bm5pbmdBY2NlbGVyYXRl ZEFuaW1hdGlvbigpKSB7CisgICAgICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IGN1cnJUcmFuc2Zv cm07CisgICAgICAgIFJlZlB0cjxSZW5kZXJTdHlsZT4gc3R5bGUgPSByZW5kZXJlcigpLT5hbmlt YXRpb24oKS0+Z2V0QW5pbWF0ZWRTdHlsZUZvclJlbmRlcmVyKHJlbmRlcmVyKCkpOworICAgICAg ICBzdHlsZS0+YXBwbHlUcmFuc2Zvcm0oY3VyclRyYW5zZm9ybSwgcmVuZGVyQm94KCktPmJvcmRl ckJveFJlY3QoKS5zaXplKCksIFJlbmRlclN0eWxlOjpJbmNsdWRlVHJhbnNmb3JtT3JpZ2luKTsK KyAgICAgICAgcmV0dXJuIGN1cnJUcmFuc2Zvcm07CisgICAgfQorI2VuZGlmCisKKyAgICByZXR1 cm4gKm1fdHJhbnNmb3JtOworfQorCiB2b2lkIFJlbmRlckxheWVyOjpzZXRIYXNWaXNpYmxlQ29u dGVudChib29sIGIpCiB7IAogICAgIGlmIChtX2hhc1Zpc2libGVDb250ZW50ID09IGIgJiYgIW1f dmlzaWJsZUNvbnRlbnRTdGF0dXNEaXJ0eSkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmggYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCmluZGV4IDRk MGI0YjUuLjBmMzUzOTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy LmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaApAQCAtNDAxLDYgKzQwMSwx MSBAQCBwdWJsaWM6CiAgICAgYm9vbCBoYXNUcmFuc2Zvcm0oKSBjb25zdCB7IHJldHVybiByZW5k ZXJlcigpLT5oYXNUcmFuc2Zvcm0oKTsgfQogICAgIC8vIE5vdGUgdGhhdCB0aGlzIHRyYW5zZm9y bSBoYXMgdGhlIHRyYW5zZm9ybS1vcmlnaW4gYmFrZWQgaW4uCiAgICAgVHJhbnNmb3JtYXRpb25N YXRyaXgqIHRyYW5zZm9ybSgpIGNvbnN0IHsgcmV0dXJuIG1fdHJhbnNmb3JtLmdldCgpOyB9Cisg ICAgLy8gY3VycmVudFRyYW5zZm9ybSBjb21wdXRlcyBhIHRyYW5zZm9ybSB3aGljaCB0YWtlcyBh Y2NlbGVyYXRlZCBhbmltYXRpb25zIGludG8gYWNjb3VudC4gVGhlCisgICAgLy8gcmVzdWx0aW5n IHRyYW5zZm9ybSBoYXMgdHJhbnNmb3JtLW9yaWdpbiBiYWtlZCBpbi4gSWYgdGhlIGxheWVyIGRv ZXMgbm90IGhhdmUgYSB0cmFuc2Zvcm0sCisgICAgLy8gcmV0dXJucyB0aGUgaWRlbnRpdHkgbWF0 cml4LgorICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IGN1cnJlbnRUcmFuc2Zvcm0oKSBjb25zdDsK KyAgICAKICAgICAvLyBHZXQgdGhlIHBlcnNwZWN0aXZlIHRyYW5zZm9ybSwgd2hpY2ggaXMgYXBw bGllZCB0byB0cmFuc2Zvcm1lZCBzdWJsYXllcnMuCiAgICAgLy8gUmV0dXJucyB0cnVlIGlmIHRo ZSBsYXllciBoYXMgYSAtd2Via2l0LXBlcnNwZWN0aXZlLgogICAgIC8vIE5vdGUgdGhhdCB0aGlz IHRyYW5zZm9ybSBoYXMgdGhlIHBlcnNwZWN0aXZlLW9yaWdpbiBiYWtlZCBpbi4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAgYi9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJPYmplY3QuY3BwCmluZGV4IDE2NzJmZWIuLmViMTk3NzUgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyT2JqZWN0LmNwcApAQCAtMTY4OCw3ICsxNjg4LDcgQEAgVHJhbnNmb3JtYXRpb25NYXRy aXggUmVuZGVyT2JqZWN0Ojp0cmFuc2Zvcm1Gcm9tQ29udGFpbmVyKGNvbnN0IFJlbmRlck9iamVj dCogY28KICAgICBjb250YWluZXJUcmFuc2Zvcm0udHJhbnNsYXRlKG9mZnNldEluQ29udGFpbmVy LndpZHRoKCksIG9mZnNldEluQ29udGFpbmVyLmhlaWdodCgpKTsKICAgICBSZW5kZXJMYXllciog bGF5ZXI7CiAgICAgaWYgKGhhc0xheWVyKCkgJiYgKGxheWVyID0gdG9SZW5kZXJCb3godGhpcykt PmxheWVyKCkpICYmIGxheWVyLT50cmFuc2Zvcm0oKSkKLSAgICAgICAgY29udGFpbmVyVHJhbnNm b3JtLm11bHRMZWZ0KCpsYXllci0+dHJhbnNmb3JtKCkpOworICAgICAgICBjb250YWluZXJUcmFu c2Zvcm0ubXVsdExlZnQobGF5ZXItPmN1cnJlbnRUcmFuc2Zvcm0oKSk7CiAgICAgCiAgICAgaWYg KGNvbnRhaW5lck9iamVjdCAmJiBjb250YWluZXJPYmplY3QtPnN0eWxlKCktPmhhc1BlcnNwZWN0 aXZlKCkpIHsKICAgICAgICAgLy8gUGVycHNlY3RpdmUgb24gdGhlIGNvbnRhaW5lciBhZmZlY3Rz IHVzLCBzbyB3ZSBoYXZlIHRvIGZhY3RvciBpdCBpbiBoZXJlLgo=