243265 2022-07-27 14:12:31 -0700 [WASM-Function-References] Assertion failure when a function returns (ref <idx>) to JS 2022-11-02 17:08:56 -0700 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 247393 1 asumu webkit-unassigned saam webkit-bug-importer ysuzuki oldest_to_newest 1887160 0 asumu 2022-07-27 14:12:31 -0700 A test case like the following will currently raise an assertion error: ``` //@ runWebAssemblySuite("--useWebAssemblyTypedFunctionReferences=true", "--useWebAssemblyGC=false") import * as assert from "../assert.js"; import { compile, instantiate } from "./wast-wrapper.js"; let m1 = instantiate(` (module (type (func)) (type (func (result (ref 0)))) (elem declare funcref (ref.func 0)) (func) (func (export "f") (type 1) (ref.func 0)) ) `); instantiate(` (module (type (func)) (type (func (result (ref 0)))) (func (import "m" "f") (type 1)) ) `, { m: { f: m1.exports.f } }); ``` This will instead raise a parse error if typed funcrefs are turned off (the default). The assertion failure comes from a ref-with-index type not being supported in `WasmToJS.cpp` in processing the result of an exported Wasm function. I think it should be possible to support this case, it just requires checking if the type index points to a function signature or not. For non-function signatures, it should probably error for now. 1888674 1 asumu 2022-08-03 11:24:20 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2983 1888707 2 webkit-bug-importer 2022-08-03 14:13:16 -0700 <rdar://problem/98075013> 1893527 3 ews-feeder 2022-08-24 11:47:47 -0700 Committed 253734@main (0c946f31a451): <https://commits.webkit.org/253734@main> Reviewed commits have been landed. Closing PR #2983 and removing active labels.