24317 2009-03-02 22:43:13 -0800 hitTest() on a multi line input only works through happenstance. 2009-03-03 09:43:57 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 24312 1 simon.fraser simon.fraser adele mitz oldest_to_newest 111971 0 simon.fraser 2009-03-02 22:43:13 -0800 Another, just like bug 24313: Hit testing on a RenderTextControlMultiLine seems to work only because of a side-effect of HitTestResult behavior. What I see happening is this: RenderLayer::hitTest calls hitTest() on the renderer, which goes into RenderTextControlMultiLine::nodeAtPoint(). This ends up setting some text node inside the textarea as the innerNode() on the result. However, RenderTextControlMultiLine::nodeAtPoint() then returns false! So we continue to hit test all the way up to the body. The body's layer ends up being the one hit, but we use the node in the result anyway. This is hurting my karma. See bug 24312. 111972 1 28213 simon.fraser 2009-03-02 23:05:00 -0800 Created attachment 28213 Patch 112008 2 28213 hyatt 2009-03-03 09:05:59 -0800 Comment on attachment 28213 Patch r=me 112016 3 simon.fraser 2009-03-03 09:43:57 -0800 http://trac.webkit.org/changeset/41385 28213 2009-03-02 23:05:00 -0800 2009-03-03 09:05:59 -0800 Patch 24317_patch.txt text/plain 1527 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2EyNjRjMC4uZTdiMzE1MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0wMy0wMiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQzMTcKKyAgICAgICAgCisgICAgICAgIEFsd2F5cyByZXR1cm4gfHRydWV8IGZyb20gUmVu ZGVyVGV4dENvbnRyb2xNdWx0aUxpbmU6Om5vZGVBdFBvaW50KCkgaWYKKyAgICAgICAgdGhlIHN1 cGVyY2xhc3MgZm91bmQgYSBub2RlLCBvdGhlcndpc2Ugd2Ugc2V0IHRoZSBpbm5lck5vZGUgb2Yg dGhlCisgICAgICAgIEhpdFRlc3RSZXN1bHQsIGJ1dCBkb24ndCBhY3R1YWxseSByZXBvcnQgdGhh dCB3ZSBmb3VuZCBhIGhpdC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJv bE11bHRpTGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUZXh0Q29udHJvbE11bHRp TGluZTo6bm9kZUF0UG9pbnQpOgorCisyMDA5LTAzLTAyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlIFBldGVyc29uCiAK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MzEzCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbE11bHRpTGluZS5j cHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbE11bHRpTGluZS5jcHAKaW5k ZXggYTM5NDQ0MC4uOWViM2ZhMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGV4dENvbnRyb2xNdWx0aUxpbmUuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRl eHRDb250cm9sTXVsdGlMaW5lLmNwcApAQCAtODMsMTIgKzgzLDEwIEBAIGJvb2wgUmVuZGVyVGV4 dENvbnRyb2xNdWx0aUxpbmU6Om5vZGVBdFBvaW50KGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiByZXF1 ZXN0LCBIaXRUCiAgICAgaWYgKCFSZW5kZXJUZXh0Q29udHJvbDo6bm9kZUF0UG9pbnQocmVxdWVz dCwgcmVzdWx0LCB4LCB5LCB0eCwgdHksIGhpdFRlc3RBY3Rpb24pKQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKLSAgICBpZiAocmVzdWx0LmlubmVyTm9kZSgpID09IG5vZGUoKSkgeworICAgIGlm IChyZXN1bHQuaW5uZXJOb2RlKCkgPT0gbm9kZSgpKQogICAgICAgICBoaXRJbm5lclRleHRCbG9j ayhyZXN1bHQsIHgsIHksIHR4LCB0eSk7Ci0gICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KIAot ICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogdm9pZCBSZW5kZXJUZXh0 Q29udHJvbE11bHRpTGluZTo6Zm9yd2FyZEV2ZW50KEV2ZW50KiBldmVudCkK