24313 2009-03-02 20:09:20 -0800 hitTest() on a single line input only works through happenstance. 2009-03-02 22:16:19 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 24312 1 simon.fraser simon.fraser mitz oldest_to_newest 111959 0 simon.fraser 2009-03-02 20:09:20 -0800 Hit testing on a RenderTextControlSingleLine seems to work only because of a side-effect of HitTestResult behavior. What I see happening is this. RenderLayer::hitTest calls hitTest() on the renderer, which goes into RenderTextControlSingleLine::nodeAtPoint(). This ends up setting the TextControlInnerTextElement as the innerNode() on the result. However, RenderTextControlSingleLine::nodeAtPoint() then returns false! So we continue to hit test all the way up to the body. The body's layer ends up being the one hit, but we use the node in the result anyway. This is hurting my karma. See bug 24312. 111966 1 28212 simon.fraser 2009-03-02 21:46:48 -0800 Created attachment 28212 Patch I'm pretty sure it was just wrong to test against m_innerBlock, because the superclass could never have set that on the result. 111967 2 simon.fraser 2009-03-02 22:16:19 -0800 http://trac.webkit.org/changeset/41379 28212 2009-03-02 21:46:48 -0800 2009-03-02 22:05:39 -0800 Patch 24313_patch.txt text/plain 1575 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWMwZTNjNy4uMzczOTZjYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0wMy0wMiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjQzMTMKKyAgICAgICAgCisgICAgICAgIElmIFJlbmRlclRleHRDb250cm9sU2luZ2xlTGlu ZTo6bm9kZUF0UG9pbnQoKSBwb2tlcyBhIG5vZGUgaW50byB0aGUKKyAgICAgICAgSGl0VGVzdFJl c3VsdCwgdGhlbiBpdCBoYWQgYmV0dGVyIHdlbGwgcmV0dXJuIHx0cnVlfC4gQW5kIG1faW5uZXJC bG9jaworICAgICAgICBjb3VsZCBuZXZlciBoYXZlIGJlZW4gc2V0IGFzIHRoZSBoaXQgbm9kZSBi eSB0aGUgc3VwZXJjbGFzcywgYmVjYXVzZQorICAgICAgICB0aGUgc3VwZXJjbGFzcyBrbm93cyBu b3RoaW5nIGFib3V0IG1faW5uZXJCbG9jay4KKyAgICAgICAgCisgICAgICAgIEZ1bmN0aW9uYWxp dHkgZXhlcmNpc2VkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJU ZXh0Q29udHJvbFNpbmdsZUxpbmU6Om5vZGVBdFBvaW50KToKKwogMjAwOS0wMy0wMiAgU2FtIFdl aW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGlu ZS5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuY3Bw CmluZGV4IGQ0NTg1OWIuLmNhODg1ZjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcApAQCAtMjcwLDcgKzI3MCw3IEBAIGJvb2wgUmVu ZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lOjpub2RlQXRQb2ludChjb25zdCBIaXRUZXN0UmVxdWVz dCYgcmVxdWVzdCwgSGl0CiAgICAgaWYgKCFSZW5kZXJUZXh0Q29udHJvbDo6bm9kZUF0UG9pbnQo cmVxdWVzdCwgcmVzdWx0LCB4UG9zLCB5UG9zLCB0eCwgdHksIGhpdFRlc3RBY3Rpb24pKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAocmVzdWx0LmlubmVyTm9kZSgpICE9IG5vZGUo KSAmJiByZXN1bHQuaW5uZXJOb2RlKCkgIT0gbV9pbm5lckJsb2NrLmdldCgpKQorICAgIGlmIChy ZXN1bHQuaW5uZXJOb2RlKCkgIT0gbm9kZSgpICYmIHJlc3VsdC5pbm5lck5vZGUoKSAhPSBpbm5l clRleHRFbGVtZW50KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGhpdElubmVyVGV4 dEJsb2NrKHJlc3VsdCwgeFBvcywgeVBvcywgdHgsIHR5KTsK