24307 2009-03-02 16:50:46 -0800 m_highlightedNode should be cleared on hideHighlight 2009-03-02 18:13:02 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan webkit-unassigned oldest_to_newest 111934 0 ojan 2009-03-02 16:50:46 -0800 This makes it consistent with setting it on highlight(). More importantly, the chromium build relies on the null-check at the beginning of drawNodeHighlight as to whether to draw the node highlight. 111941 1 28208 ojan 2009-03-02 17:34:54 -0800 Created attachment 28208 Null m_highlightedNode on hideHighlight() WebCore/ChangeLog | 11 +++++++++++ WebCore/inspector/InspectorController.cpp | 1 + 2 files changed, 12 insertions(+), 0 deletions(-) 111947 2 eric 2009-03-02 18:13:02 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp Committed r41377 28208 2009-03-02 17:34:54 -0800 2009-03-02 17:59:40 -0800 Null m_highlightedNode on hideHighlight() Null-m_highlightedNode-on-hideHighlight-.patch text/plain 1032 ojan YjA4Mzc2NGViMGEyMjM0N2E3OTFmZDZmNDNjM2E1MmI2ZDgwYjdjZgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1NjA5YTQ3Li4wNjYxZjcw IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTAzLTAyICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDMwNworICAgICAgICBO dWxsIG91dCBtX2hpZ2hsaWdodGVkTm9kZSBvbiBoaWRlSGlnaGxpZ2h0KCkuCisJUmFuIHRoZSBX ZWJDb3JlL21hbnVhbC10ZXN0cy9pbnNwZWN0b3IvaGlnaGxpZ2h0LW5vZGVzLmh0bWwuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpoaWRlSGlnaGxpZ2h0KToKKwogMjAwOS0wMy0wMiAg RGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gUm9iZW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9s bGVyLmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCmluZGV4 IDhkYTVlZTYuLmU2NGUwMzUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuY3BwCkBAIC0xMzYxLDYgKzEzNjEsNyBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6Omhp ZGVIaWdobGlnaHQoKQogewogICAgIGlmICghZW5hYmxlZCgpKQogICAgICAgICByZXR1cm47Cisg ICAgbV9oaWdobGlnaHRlZE5vZGUgPSAwOwogICAgIG1fY2xpZW50LT5oaWRlSGlnaGxpZ2h0KCk7 CiB9CiAK