24304 2009-03-02 16:01:46 -0800 REGRESSION (r39864): Hitting the space bar to select an <input type=radio> or push an <input type=button> causes the page to scroll down. 2009-03-17 12:44:46 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar, Regression P2 Normal --- 1 mad darin ap darin igitur mad mario.bensi tal.ayal.cohen oldest_to_newest 111921 0 mad 2009-03-02 16:01:46 -0800 This bug was introduced by http://trac.webkit.org/changeset/39864. The following form helps expose the problem which occurs when you set the focus to the radio button and hit the space bar on your keyboard. The page scrolls... and it shouldn't... right? <form action="http://www.example.com/" method="post"> <input type="text" name="one" /> <input type="radio" name="two" /> <div style="height:5000px;"> </div> <input type="submit" /> </form> 111933 1 darin 2009-03-02 16:49:59 -0800 I tested this on Mac and could not reproduce the problem. Space bar worked fine and did not cause any scrolling. Maybe it's only for non-Mac platforms. The reason this should not happen is that the code in the radio button implementation should call setDefaultHandled(true) and that should cause the scrolling code to not do anything. 111942 2 mad 2009-03-02 17:43:22 -0800 That was my guess (the radio button to call setDefaultHandled(true)), but I couldn't find where that code should be... I'm willing to fix it if I can find where it is :-)... 111945 3 mad 2009-03-02 17:54:19 -0800 Actually, I thought it could be there, but a comment says it shouldn't... for some reason... WebKit\WebCore\html\HTMLInputElement.cpp HTMLInputElement::defaultEventHandler() [...] case RADIO: setActive(true, true); // No setDefaultHandled() - IE dispatches a keypress in this case. return; This code was added as part of: http://trac.webkit.org/changeset/28620 111975 4 ap 2009-03-03 00:10:07 -0800 If we were to call setDefaultHandled(true) in keydown event handler, then keypress wouldn't be dispatched, not matching IE. 112045 5 igitur 2009-03-03 10:57:55 -0800 Similar thing happens with I use the space bar to press a button. Does this warrant a separate issue to be filed? 112051 6 darin 2009-03-03 11:22:24 -0800 I think it would be fine to have one bug that covers both. 113352 7 ap 2009-03-12 02:41:07 -0700 <rdar://problem/6674180> 113961 8 28672 adele 2009-03-16 17:46:00 -0700 Created attachment 28672 initial version of patch 113962 9 adele 2009-03-16 17:46:59 -0700 Darin came up with an initial patch (see attached). We were calling the base class early in too many cases. 113963 10 darin 2009-03-16 17:47:50 -0700 Adele and I figured out that the real problem here is that HTMLInputElement goes out of its way to give the default event handler a crack at the event before it handles the event. For <input type="text"> that's OK, but not for other input types. This will be easy to fix. 114073 11 darin 2009-03-17 12:24:13 -0700 Testing the patch on the Mac now to make sure it doesn’t cause any behavior regressions. If not, I’ll put it up for review. 114078 12 darin 2009-03-17 12:44:46 -0700 http://trac.webkit.org/changeset/41781 Contrary to what the title said, this did *not* affect <button>. If there are problems with <button> elements those are a separate bug. 28672 2009-03-16 17:46:00 -0700 2009-03-16 17:46:00 -0700 initial version of patch patch.txt text/plain 1244 adele SW5kZXg6IGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaHRtbC9IVE1M SW5wdXRFbGVtZW50LmNwcAkocmV2aXNpb24gNDE3MzgpCisrKyBodG1sL0hUTUxJbnB1dEVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTE1LDggKzExMTUsMTAgQEAgdm9pZCBIVE1MSW5w dXRFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbAogICAgICAgICByZXR1cm47CiAgICAgfQogICAg IAotICAgIC8vIExldCB0aGUga2V5IGhhbmRsaW5nIGRvbmUgaW4gTm9kZSB0YWtlIHByZWNlZGVu Y2Ugb3ZlciB0aGUgZXZlbnQgaGFuZGxpbmcgaGVyZSBmb3IgZWRpdGFibGUgdGV4dCBmaWVsZHMK LSAgICBpZiAoIWNsaWNrRGVmYXVsdEZvcm1CdXR0b24pIHsKKyAgICAvLyBDYWxsIHRoZSBiYXNl IGV2ZW50IGhhbmRsZXIgYmVmb3JlIGFueSBvZiBvdXIgb3duIGV2ZW50IGhhbmRsaW5nIGZvciBh bG1vc3QgYWxsIGV2ZW50cyBpbiB0ZXh0IGZpZWxkcy4KKyAgICAvLyBUaGlzIGlzIGhlbHBmdWwg YmVjYXVzZSB3ZSB3YW50IGVkaXRpbmcga2V5Ym9hcmQgaGFuZGxpbmcgdG8gdGFrZSBwcmVjZWRl bmNlIG92ZXIgb3VyIGtleWJvYXJkIGhhbmRsaW5nLgorICAgIGJvb2wgY2FsbEJhc2VDbGFzc0Vh cmx5ID0gaXNUZXh0RmllbGQoKSAmJiAhY2xpY2tEZWZhdWx0Rm9ybUJ1dHRvbjsKKyAgICBpZiAo Y2FsbEJhc2VDbGFzc0Vhcmx5KSB7CiAgICAgICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnRXaXRo U3RhdGU6OmRlZmF1bHRFdmVudEhhbmRsZXIoZXZ0KTsKICAgICAgICAgaWYgKGV2dC0+ZGVmYXVs dEhhbmRsZWQoKSkKICAgICAgICAgICAgIHJldHVybjsKQEAgLTEzMzksNiArMTM0MSw5IEBAIHZv aWQgSFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGwKICAgICAgICAgaWYgKGV2dC0+ aXNNb3VzZUV2ZW50KCkgfHwgZXZ0LT5pc0RyYWdFdmVudCgpIHx8IGV2dC0+aXNXaGVlbEV2ZW50 KCkpCiAgICAgICAgICAgICBzbGlkZXItPmZvcndhcmRFdmVudChldnQpOwogICAgIH0KKworICAg IGlmICghY2FsbEJhc2VDbGFzc0Vhcmx5KQorICAgICAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50 V2l0aFN0YXRlOjpkZWZhdWx0RXZlbnRIYW5kbGVyKGV2dCk7CiB9CiAKIGJvb2wgSFRNTElucHV0 RWxlbWVudDo6aXNVUkxBdHRyaWJ1dGUoQXR0cmlidXRlICphdHRyKSBjb25zdAo=