24297 2009-03-02 11:05:55 -0800 Purify UMRs in TransparencyWin for Chromium 2009-04-09 12:45:26 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 brettw brettw oldest_to_newest 111857 0 brettw 2009-03-02 11:05:55 -0800 Chromium bug: http://code.google.com/p/chromium/issues/detail?id=8219 Uninitialized memory read in WebCore::TransparencyWin::compositeOpaqueComposite(void) Error Location third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:3 90 WebCore::TransparencyWin::compositeOpaqueComposite(void) third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1 69 WebCore::TransparencyWin::~TransparencyWin(void) webkit/tools/webcore_unit_tests/transparencywin_unittest.cpp:239 WebCore::TransparencyWin_OpaqueCompositeLayer_Test::TestBody(void) testing/gtest/src/gtest.cc:2010 testing::Test::Run(void) ^^^ Alloc Location ... skia/corecg/skmemory_stdlib.cpp:260 sk_malloc_flags(UINT,UINT) skia/sgl/skbitmap.cpp:412 SkBitmap::HeapAllocator::allocPixelRef(SkBitmap *,SkColorTable *) skia/sgl/skbitmap.cpp:311 SkBitmap::allocPixels(Allocator::SkBitmap *,SkColorTable *) skia/include/skbitmap.h:210 SkBitmap::allocPixels(SkColorTable *) third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1 16 WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers(IntSize::WebCore const&,bool) third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:3 63 WebCore::TransparencyWin::initializeNewContext(void) third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:2 34 WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer(void) third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:2 16 WebCore::TransparencyWin::setupLayer(void) third_party/webkit/webcore/platform/graphics/chromium/transparencywin.cpp:1 88 WebCore::TransparencyWin::init(GraphicsContext::WebCore *,LayerMode::TransparencyWin::WebCore,TransformMode::TransparencyWin::WebCo re,IntRect::WebCore const&) webkit/tools/webcore_unit_tests/transparencywin_unittest.cpp:234 WebCore::TransparencyWin_OpaqueCompositeLayer_Test::TestBody(void) testing/gtest/src/gtest.cc:2010 testing::Test::Run(void) 111859 1 28187 brettw 2009-03-02 11:15:25 -0800 Created attachment 28187 Patch 111866 2 28187 fishd 2009-03-02 11:32:10 -0800 Comment on attachment 28187 Patch LGTM, but this file is misnamed. It should be named TransparencyChromiumWin.cpp. 111867 3 fishd 2009-03-02 11:32:45 -0800 also, please be sure to add a bug link in the ChangeLog before committing. 28187 2009-03-02 11:15:25 -0800 2009-03-02 11:32:10 -0800 Patch purify.diff text/plain 1685 brettw ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWRmNjI1MS4uZTgzM2RlNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wMy0wMiAgQnJldHQgV2lsc29u ICA8YnJldHR3QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggdW5pbml0aWFsaXplZCBtZW1v cnkgcmVhZHMgaW4gdGhlIENocm9taXVtIFdpbmRvd3MgdHJhbnNwYXJlbmN5CisgICAgICAgIGNv ZGUgdGhhdCB3ZXJlIGlkZW50aWZpZWQgYnkgUHVyaWZ5LAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v VHJhbnNwYXJlbmN5V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRyYW5zcGFyZW5jeVdpbjo6 T3duZWRCdWZmZXJzOjpPd25lZEJ1ZmZlcnMpOgorICAgICAgICAoV2ViQ29yZTo6VHJhbnNwYXJl bmN5V2luOjppbml0aWFsaXplTmV3Q29udGV4dCk6CisKIDIwMDktMDMtMDIgIEFkYW0gVHJlYXQg IDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXggZm9yIFF0 IHBvcnQuICBSZW1vdmUgdW5uZWNlc3NhcnkgYXNzZXJ0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UcmFuc3BhcmVuY3lXaW4uY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UcmFuc3BhcmVuY3lXaW4uY3BwCmluZGV4IGYyNjEx YWYuLjhhODJkMmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vVHJhbnNwYXJlbmN5V2luLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL1RyYW5zcGFyZW5jeVdpbi5jcHAKQEAgLTExNCw2ICsxMTQsNyBAQCBwdWJsaWM6CiAg ICAgICAgIGlmIChuZWVkUmVmZXJlbmNlQnVmZmVyKSB7CiAgICAgICAgICAgICBtX3JlZmVyZW5j ZUJpdG1hcC5zZXRDb25maWcoU2tCaXRtYXA6OmtBUkdCXzg4ODhfQ29uZmlnLCBzaXplLndpZHRo KCksIHNpemUuaGVpZ2h0KCkpOwogICAgICAgICAgICAgbV9yZWZlcmVuY2VCaXRtYXAuYWxsb2NQ aXhlbHMoKTsKKyAgICAgICAgICAgIG1fcmVmZXJlbmNlQml0bWFwLmVyYXNlQVJHQigwLCAwLCAw LCAwKTsKICAgICAgICAgfQogICAgIH0KIApAQCAtMzUzLDcgKzM1NCw5IEBAIHZvaWQgVHJhbnNw YXJlbmN5V2luOjppbml0aWFsaXplTmV3Q29udGV4dCgpCiAgICAgICAgIC8vIGFsbCBsYXllciBt b2RlcyB3aWxsIGNsZWFyIGl0IGluIHRoZWlyIGluaXRpYWxpemF0aW9uLgogICAgICAgICBtX2xh eWVyQnVmZmVyID0gbV9jYWNoZWRCdWZmZXJzLT5kZXN0Qml0bWFwKCk7CiAgICAgICAgIG1fZHJh d0NvbnRleHQgPSBtX2NhY2hlZEJ1ZmZlcnMtPmRlc3RCaXRtYXAoKS0+Y29udGV4dCgpOworICAg ICAgICBiaXRtYXBGb3JDb250ZXh0KCptX2RyYXdDb250ZXh0KS5lcmFzZUFSR0IoMCwgMCwgMCwg MCk7CiAgICAgICAgIG1fcmVmZXJlbmNlQml0bWFwID0gbV9jYWNoZWRCdWZmZXJzLT5yZWZlcmVu Y2VCaXRtYXAoKTsKKyAgICAgICAgbV9yZWZlcmVuY2VCaXRtYXAtPmVyYXNlQVJHQigwLCAwLCAw LCAwKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAo=