24296 2009-03-02 10:36:08 -0800 prepare-ChangeLog fails to find function names when multiline quoted text is used in a JavaScript file 2009-03-02 13:38:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/Console.js?rev=41352#L397 P2 Normal --- 1 timothy timothy aroben ddkilzer oldest_to_newest 111850 0 timothy 2009-03-02 10:36:08 -0800 The Console.js file in WebCore/inspector has multiline quoted text, and prepare-ChangeLog fails to find function names in this case. 111852 1 28182 timothy 2009-03-02 10:37:34 -0800 Created attachment 28182 Proposed Patch 111885 2 28182 ddkilzer 2009-03-02 13:09:08 -0800 Comment on attachment 28182 Proposed Patch r=me 111891 3 timothy 2009-03-02 13:38:25 -0800 Landed in r41363. 28182 2009-03-02 10:37:34 -0800 2009-03-02 13:09:08 -0800 Proposed Patch 0001--Allow-for-multiline-quoted-text-in-JavaScrip.patch text/plain 2443 timothy RnJvbSAxNzQ4OTZkMzRlZGU1ZGM5MjRjNzIxNGJmZDAxZmZmY2JjYWE1YTNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBNb24sIDIgTWFyIDIwMDkgMTA6MzY6NDUgLTA4MDAKU3ViamVjdDogW1BBVENIXSAgICAg ICAgIEFsbG93IGZvciBtdWx0aWxpbmUgcXVvdGVkIHRleHQgaW4gSmF2YVNjcmlwdCBmaWxlcyB3 aGVuIGxvb2tpbmcgZm9yIGZ1bmN0aW9uIG5hbWVzLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQyOTYKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCgogICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKLS0tCiBXZWJL aXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJL aXRUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nIHwgICAxMSArKysrKysrKysrLQogMiBm aWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBh YzA4ZWNhLi42MTMzNmI3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIv V2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMDIgIFRpbW90 aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IGZvciBtdWx0 aWxpbmUgcXVvdGVkIHRleHQgaW4gSmF2YVNjcmlwdCBmaWxlcyB3aGVuIGxvb2tpbmcgZm9yIGZ1 bmN0aW9uIG5hbWVzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNDI5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKwogMjAwOS0wMy0wMSAgQ2hyaXMg RmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9s aXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5n ZUxvZyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5kZXggNTVhODhh Yy4uM2VjZjE4OSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5n ZUxvZworKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC05Mjks NiArOTI5LDcgQEAgc3ViIGdldF9mdW5jdGlvbl9saW5lX3Jhbmdlc19mb3JfamF2YXNjcmlwdCgk JCkKICAgICBteSBAcmFuZ2VzOwogCiAgICAgbXkgJGluQ29tbWVudCA9IDA7CisgICAgbXkgJGlu UXVvdGVkVGV4dCA9ICIiOwogICAgIG15ICRwYXJlbnRoZXNlc0RlcHRoID0gMDsKICAgICBteSAk YnJhY2VzRGVwdGggPSAwOwogCkBAIC05NDYsNiArOTQ3LDEzIEBAIHN1YiBnZXRfZnVuY3Rpb25f bGluZV9yYW5nZXNfZm9yX2phdmFzY3JpcHQoJCQpCiAgICAgICAgICAgICAkaW5Db21tZW50ID0g MDsKICAgICAgICAgfQogCisgICAgICAgICMgSGFuZGxlIGNvbnRpbnVlZCBxdW90ZWQgdGV4dC4K KyAgICAgICAgaWYgKCRpblF1b3RlZFRleHQgbmUgIiIpIHsKKyAgICAgICAgICAgIG5leHQgaWYg L1xcJC87CisgICAgICAgICAgICBzLShbXlxcXXxcXC4pKj8kaW5RdW90ZWRUZXh0LS07CisgICAg ICAgICAgICAkaW5RdW90ZWRUZXh0ID0gIiI7CisgICAgICAgIH0KKwogICAgICAgICAjIEhhbmRs ZSBjb21tZW50cyBhbmQgcXVvdGVkIHRleHQuCiAgICAgICAgIHdoaWxlIChtLSgvXCp8Ly98XCd8 XCIpLSkgeyAjIFwnIGFuZCBcIiBrZWVwIGVtYWNzIHBlcmwgbW9kZSBoYXBweQogICAgICAgICAg ICAgbXkgJG1hdGNoID0gJDE7CkBAIC05NTgsNyArOTY2LDggQEAgc3ViIGdldF9mdW5jdGlvbl9s aW5lX3Jhbmdlc19mb3JfamF2YXNjcmlwdCgkJCkKICAgICAgICAgICAgICAgICBzLS8vLiotLTsK ICAgICAgICAgICAgIH0gZWxzZSB7ICMgJyBvciAiCiAgICAgICAgICAgICAgICAgaWYgKCFzLSRt YXRjaChbXlxcXXxcXC4pKj8kbWF0Y2gtLSkgewotICAgICAgICAgICAgICAgICAgICB3YXJuICJt aXNtYXRjaGVkIHF1b3RlcyBhdCBsaW5lICQuIGluICRmaWxlTmFtZVxuIjsKKyAgICAgICAgICAg ICAgICAgICAgJGluUXVvdGVkVGV4dCA9ICRtYXRjaCBpZiAvXFwkLzsKKyAgICAgICAgICAgICAg ICAgICAgd2FybiAibWlzbWF0Y2hlZCBxdW90ZXMgYXQgbGluZSAkLiBpbiAkZmlsZU5hbWVcbiIg aWYgJGluUXVvdGVkVGV4dCBlcSAiIjsKICAgICAgICAgICAgICAgICAgICAgcy0kbWF0Y2guKi0t OwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KLS0gCjEuNi4xLjIKCg==