24284 2009-03-02 02:11:43 -0800 Qt build environment simplifying 2009-05-11 10:58:44 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 ossy webkit-unassigned laszlo.gombos oldest_to_newest 111795 0 ossy 2009-03-02 02:11:43 -0800 In Qt build environment (pri and pro) files there are several duplicated values. I would like to remove them in the interest of clear and simplify code. 111797 1 28159 ossy 2009-03-02 02:34:00 -0800 Created attachment 28159 proposed patch jsc.pro -------- Also defined in JavaScriptCore.pri: (bindings and bindings/c are not exists) -INCLUDEPATH += $$PWD \ - $$PWD/parser \ - $$PWD/bindings \ - $$PWD/bindings/c \ - $$PWD/wtf \ - $$PWD/jit \ - $$PWD/bytecode Also defined in WebKit.pri: -DEFINES += BUILDING_QT__ -CONFIG(release) { - DEFINES += NDEBUG USE_SYSTEM_MALLOC -} WebCore.pro ------------ Also defined in JavaScriptCore.pri: -INCLUDEPATH += $$PWD $$PWD/../JavaScriptCore $$PWD/../JavaScriptCore/ForwardingHeaders \ - $$PWD/../JavaScriptCore/interpreter \ - $$PWD/../JavaScriptCore/bytecode \ - $$PWD/../JavaScriptCore/debugger \ - $$PWD/../JavaScriptCore/parser \ - $$PWD/../JavaScriptCore/runtime \ - $$PWD/../JavaScriptCore/bindings \ - $$PWD/../JavaScriptCore/wrec \ - $$PWD/../JavaScriptCore/jit \ - $$PWD/../JavaScriptCore/wtf \ Also defined in WebCore.pro: - $$PWD/loader \ - $$PWD/bridge/qt - $$PWD/bridge \ 120619 2 28159 zecke 2009-05-11 03:46:21 -0700 Comment on attachment 28159 proposed patch Looks like a nice cleanup. 120674 3 zecke 2009-05-11 09:23:03 -0700 Please remove the WARNING NO... from the ChangeLog in the future. Landed in r43494. 120694 4 ossy 2009-05-11 10:58:44 -0700 (In reply to comment #3) > Please remove the WARNING NO... from the ChangeLog in the future. Landed in > r43494. OK, I'll do it next time. Thanks. 28159 2009-03-02 02:34:00 -0800 2009-05-11 03:46:21 -0700 proposed patch qt-clear.patch text/plain 5352 ossy SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQxMzUzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDMtMDIgIENzYWJhIE9z enRyb2dvbmFjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTI0Mjg0CisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS5wcmk6IGNvZGluZyBz dHlsZSBtb2RpZmllZAorICAgICAgICAqIGpzYy5wcm86IGR1cGxpY2F0ZWQgdmFsdWVzIHJlbW92 ZWQgZnJvbSBJTkNMVURFUEFUSCwgREVGSU5FUworCiAyMDA5LTAzLTAxICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY2MzU2ODg+ IE1vdmUgSEFWRV9EVFJBQ0UgY2hlY2sgdG8gQmFzZS54Y2NvbmZpZwpJbmRleDogSmF2YVNjcmlw dENvcmUvSmF2YVNjcmlwdENvcmUucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLnByaQkocmV2aXNpb24gNDEyNDQpCisrKyBKYXZhU2NyaXB0Q29yZS9KYXZh U2NyaXB0Q29yZS5wcmkJKHdvcmtpbmcgY29weSkKQEAgLTEsOSArMSwyNCBAQAogIyBKYXZhU2Ny aXB0Q29yZSAtIFF0NCBidWlsZCBpbmZvCiBWUEFUSCArPSAkJFBXRAogCi1JTkNMVURFUEFUSCAr PSB0bXAKLUlOQ0xVREVQQVRIICs9ICQkUFdEICQkUFdEL3BhcnNlciAkJFBXRC9ieXRlY29tcGls ZXIgJCRQV0QvZGVidWdnZXIgJCRQV0QvcnVudGltZSAkJFBXRC93dGYgJCRQV0Qvd3RmL3VuaWNv ZGUgJCRQV0QvaW50ZXJwcmV0ZXIgJCRQV0Qvaml0ICQkUFdEL3Byb2ZpbGVyICQkUFdEL3dyZWMg JCRQV0QvQVBJICQkUFdELy4uIFwKLSAgICAgICAgICAgICAgICQkUFdEL0ZvcndhcmRpbmdIZWFk ZXJzICQkUFdEL2J5dGVjb2RlICQkUFdEL2Fzc2VtYmxlcgorSU5DTFVERVBBVEggKz0gdG1wIFwK KyAgICAgICAgICAgICAgICQkUFdEIFwKKyAgICAgICAgICAgICAgICQkUFdEL3BhcnNlciBcCisg ICAgICAgICAgICAgICAkJFBXRC9ieXRlY29tcGlsZXIgXAorICAgICAgICAgICAgICAgJCRQV0Qv ZGVidWdnZXIgXAorICAgICAgICAgICAgICAgJCRQV0QvcnVudGltZSBcCisgICAgICAgICAgICAg ICAkJFBXRC93dGYgXAorICAgICAgICAgICAgICAgJCRQV0Qvd3RmL3VuaWNvZGUgXAorICAgICAg ICAgICAgICAgJCRQV0QvaW50ZXJwcmV0ZXIgXAorICAgICAgICAgICAgICAgJCRQV0Qvaml0IFwK KyAgICAgICAgICAgICAgICQkUFdEL3Byb2ZpbGVyIFwKKyAgICAgICAgICAgICAgICQkUFdEL3dy ZWMgXAorICAgICAgICAgICAgICAgJCRQV0QvQVBJIFwKKyAgICAgICAgICAgICAgICQkUFdELy4u IFwKKyAgICAgICAgICAgICAgICQkUFdEL0ZvcndhcmRpbmdIZWFkZXJzIFwKKyAgICAgICAgICAg ICAgICQkUFdEL2J5dGVjb2RlIFwKKyAgICAgICAgICAgICAgICQkUFdEL2Fzc2VtYmxlciBcCisK IERFRklORVMgKz0gQlVJTERJTkdfUVRfXwogCiBpc0VtcHR5KEdFTkVSQVRFRF9TT1VSQ0VTX0RJ Uik6R0VORVJBVEVEX1NPVVJDRVNfRElSID0gdG1wCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9qc2Mu cHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2pzYy5wcm8JKHJldmlzaW9uIDQxMjQ0 KQorKysgSmF2YVNjcmlwdENvcmUvanNjLnBybwkod29ya2luZyBjb3B5KQpAQCAtMywyMSArMyw5 IEBAIFRBUkdFVCA9IGpzYwogREVTVERJUiA9IC4KIFNPVVJDRVMgPSBqc2MuY3BwCiBRVCAtPSBn dWkKLUlOQ0xVREVQQVRIICs9ICQkUFdEIFwKLSAgICAkJFBXRC9wYXJzZXIgXAotICAgICQkUFdE L2JpbmRpbmdzIFwKLSAgICAkJFBXRC9iaW5kaW5ncy9jIFwKLSAgICAkJFBXRC93dGYgXAotICAg ICQkUFdEL2ppdCBcCi0gICAgJCRQV0QvYnl0ZWNvZGUKIENPTkZJRyAtPSBhcHBfYnVuZGxlCi1E RUZJTkVTICs9IEJVSUxESU5HX1FUX18KIENPTkZJRyArPSBidWlsZGluZy1saWJzCiAKLUNPTkZJ RyhyZWxlYXNlKSB7Ci0gICAgREVGSU5FUyArPSBOREVCVUcgVVNFX1NZU1RFTV9NQUxMT0MKLX0K LQogaW5jbHVkZSgkJFBXRC8uLi9XZWJLaXQucHJpKQogCiBDT05GSUcgKz0gbGlua19wa2djb25m aWcKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiA0MTM1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDMtMDIgIENzYWJhIE9zenRyb2dvbmFjICA8b3N6aUBp bmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV0FSTklORzogTk8gVEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0Mjg0CisKKyAgICAg ICAgKiBXZWJDb3JlLnBybzogZHVwbGljYXRlZCB2YWx1ZXMgcmVtb3ZlZCBmcm9tIElOQ0xVREVQ QVRICisKIDIwMDktMDMtMDIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgog CiAgICAgICAgIFNob3cgZXhjZXB0aW9uIG1lc3NhZ2VzIGFnYWluIHdoZW4gZXZhbHVhdGluZyBi YWQgZXhwcmVzc2lvbnMgaW4gdGhlCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUucHJvCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHJldmlzaW9uIDQxMjQ0KQorKysgV2ViQ29yZS9X ZWJDb3JlLnBybwkod29ya2luZyBjb3B5KQpAQCAtMTIyLDE3ICsxMjIsNiBAQCB1bml4fHdpbjMy LSo6IWVtYmVkZGVkOiF3aW5jZSo6IXN5bWJpYW4gCiAKIERFRklORVMgKz0gV1RGX1VTRV9KQVZB U0NSSVBUQ09SRV9CSU5ESU5HUz0xIFdURl9DSEFOR0VTPTEKIAotSU5DTFVERVBBVEggKz0gJCRQ V0QgJCRQV0QvLi4vSmF2YVNjcmlwdENvcmUgJCRQV0QvLi4vSmF2YVNjcmlwdENvcmUvRm9yd2Fy ZGluZ0hlYWRlcnMgXAotICAgICAgICAgICAgICAgJCRQV0QvLi4vSmF2YVNjcmlwdENvcmUvaW50 ZXJwcmV0ZXIgXAotICAgICAgICAgICAgICAgJCRQV0QvLi4vSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUgXAotICAgICAgICAgICAgICAgJCRQV0QvLi4vSmF2YVNjcmlwdENvcmUvZGVidWdnZXIgXAot ICAgICAgICAgICAgICAgJCRQV0QvLi4vSmF2YVNjcmlwdENvcmUvcGFyc2VyIFwKLSAgICAgICAg ICAgICAgICQkUFdELy4uL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUgXAotICAgICAgICAgICAgICAg JCRQV0QvLi4vSmF2YVNjcmlwdENvcmUvYmluZGluZ3MgXAotICAgICAgICAgICAgICAgJCRQV0Qv Li4vSmF2YVNjcmlwdENvcmUvd3JlYyBcCi0gICAgICAgICAgICAgICAkJFBXRC8uLi9KYXZhU2Ny aXB0Q29yZS9qaXQgXAotICAgICAgICAgICAgICAgJCRQV0QvLi4vSmF2YVNjcmlwdENvcmUvd3Rm IFwKLQogaW5jbHVkZSgkJFBXRC8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkp CiAKIFJFU09VUkNFUyArPSBcCkBAIC0xNDUsMjAgKzEzNCwxNSBAQCBJTkNMVURFUEFUSCArPSBc CiAgICAgJCRQV0QvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3JtcyBcCiAgICAgJCRQV0QvcGxh dGZvcm0vZ3JhcGhpY3MvcXQgXAogICAgICQkUFdEL3N2Zy9ncmFwaGljcy9xdCBcCi0gICAgJCRQ V0QvbG9hZGVyIFwKICAgICAkJFBXRC9wYWdlL3F0IFwKICAgICAkJFBXRC8uLi9XZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQgXAotICAgICQkUFdELy4uL1dlYktpdC9xdC9BcGkgXAotICAgICQkUFdE L2JyaWRnZS9xdAogCiAjIE1ha2Ugc3VyZSBzdG9yYWdlLyBhcHBlYXJzIGJlZm9yZSBKYXZhU2Ny aXB0Q29yZS8uIEJvdGggcHJvdmlkZSBMb2NhbFN0b3JhZ2UuaAogIyBidXQgdGhlIGhlYWRlciBm cm9tIHRoZSBmb3JtZXIgaW5jbHVkZSBwYXRoIGlzIGluY2x1ZGVkIGFjcm9zcyBkaXJlY3Rvcmll cyB3aGlsZQogIyBMb2NhbFN0b3JhZ2UuaCBpcyBpbmNsdWRlZCBvbmx5IGZyb20gZmlsZXMgd2l0 aGluIHRoZSBzYW1lIGRpcmVjdG9yeQogSU5DTFVERVBBVEggPSAkJFBXRC9zdG9yYWdlICQkSU5D TFVERVBBVEgKIAotSU5DTFVERVBBVEggKz0gICQkUFdEIFwKLSAgICAgICAgICAgICAgICAkJFBX RC9Gb3J3YXJkaW5nSGVhZGVycyBcCi0gICAgICAgICAgICAgICAgJCRQV0QvLi4gXAorSU5DTFVE RVBBVEggKz0gICQkUFdEL0ZvcndhcmRpbmdIZWFkZXJzIFwKICAgICAgICAgICAgICAgICAkJFBX RC9wbGF0Zm9ybSBcCiAgICAgICAgICAgICAgICAgJCRQV0QvcGxhdGZvcm0vYW5pbWF0aW9uIFwK ICAgICAgICAgICAgICAgICAkJFBXRC9wbGF0Zm9ybS9uZXR3b3JrIFwKQEAgLTE3Niw3ICsxNjAs NiBAQCBJTkNMVURFUEFUSCArPSAgJCRQV0QgXAogICAgICAgICAgICAgICAgICQkUFdEL2RvbSBc CiAgICAgICAgICAgICAgICAgJCRQV0QvcGFnZSBcCiAgICAgICAgICAgICAgICAgJCRQV0QvcGFn ZS9hbmltYXRpb24gXAotICAgICAgICAgICAgICAgICQkUFdEL2JyaWRnZSBcCiAgICAgICAgICAg ICAgICAgJCRQV0QvZWRpdGluZyBcCiAgICAgICAgICAgICAgICAgJCRQV0QvcmVuZGVyaW5nIFwK ICAgICAgICAgICAgICAgICAkJFBXRC9yZW5kZXJpbmcvc3R5bGUgXApAQCAtMTkyLDggKzE3NSw4 IEBAIElOQ0xVREVQQVRIICs9ICAkJFBXRCBcCiAgICAgICAgICAgICAgICAgJCRQV0QvcGx1Z2lu cyBcCiAgICAgICAgICAgICAgICAgJCRQV0QvYnJpZGdlIFwKICAgICAgICAgICAgICAgICAkJFBX RC9icmlkZ2UvYyBcCi0gICAgICAgICAgICAgICAgJCRQV0QvYnJpZGdlL3F0IFwKLSAgICAgICAg ICAgICAgICAkJEdFTkVSQVRFRF9TT1VSQ0VTX0RJUgorICAgICAgICAgICAgICAgICQkUFdEL2Jy aWRnZS9xdAorSU5DTFVERVBBVEggKj0gICQkR0VORVJBVEVEX1NPVVJDRVNfRElSCiAKIFFUICs9 IG5ldHdvcmsKIGxlc3NUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDQpOiBRVCArPSB4bWwK