24283 2009-03-01 20:58:12 -0800 QWebPage::acceptNavigationRequest type is not QWebPage::NavigationTypeReload when QWebPage::reload() is called 2014-02-03 03:50:32 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID Qt P2 Normal --- 1 ben ben kent.hansen manyoso staikos tonikitoo zack oldest_to_newest 111777 0 ben 2009-03-01 20:58:12 -0800 After calling QWebPage::reload() QWebPage::acceptNavigationRequest() is called, but the type is not WebPage::NavigationTypeReload, but is QWebPage::Other In FrameLoader.cpp FrameLoader::reload should it always call setTriggeringAction()? Currently it is only calling it if request.httpMethod() == "POST". This causes dispatchDecidePolicyForNavigationAction to to only now that it is a reload when it is a post. Below it the initial patch that solves this. If this is correct I can turn this into a proper patch. --- a/src/3rdparty/webkit/WebCore/loader/FrameLoader.cpp +++ b/src/3rdparty/webkit/WebCore/loader/FrameLoader.cpp @@ -2456,9 +2456,10 @@ void FrameLoader::reload(bool endToEndReload) // If we're about to re-post, set up action so the application can warn the user. if (request.httpMethod() == "POST") loader->setTriggeringAction(NavigationAction(request.url(), NavigationTypeFormResubmitted)); + else + loader->setTriggeringAction(NavigationAction(request.url(), + endToEndReload ? FrameLoadTypeReloadFromOrigin : FrameLoadTypeReload, 0)); loader->setOverrideEncoding(m_documentLoader->overrideEncoding()); loadWithDocumentLoader(loader.get(), endToEndReload ? FrameLoadTypeReloadFromOrigin : FrameLoadTypeReload, 0); } 111853 1 28183 ben 2009-03-02 10:40:18 -0800 Created attachment 28183 Fix with test 113425 2 manyoso 2009-03-12 11:21:06 -0700 This looks correct in principle to me although I wonder if it'll cause a behavior change in Safari. Would feel better if Darin or someone more familiar with loader could look at it. 113435 3 manyoso 2009-03-12 11:47:39 -0700 After talking with ap and anttik on IRC we agreed the patch should be amended to use NavigationType instead of FrameLoadType enum in the NavigationAction ctor. Also, you should amend the in-code comment to explain what is happening and why. Finally, can you give a real world case where an application would need to be able to distinguish between Reload and Other for purposes of deciding the navigation policy as this might have unintended consequences for other API's and their clients. (e.g. why the Qt port needs to distinguish this) 198970 4 kent.hansen 2010-03-12 02:52:28 -0800 Any plans to proceed with this patch? 199015 5 ben 2010-03-12 06:50:22 -0800 I want to say I wrote this patch when trying to implement the reload and shift-reload feature for arora. 975798 6 jturcotte 2014-02-03 03:50:32 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 28183 2009-03-02 10:40:18 -0800 2010-06-11 10:13:15 -0700 Fix with test loaderreloadtype.patch text/plain 5242 ben RnJvbSBlZTk2YWZlMzc0ZDEwZmU1OWFlYzJkNTRhNThjMWU0ZGM5N2FiYTZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxiZW5qYW1pbi5tZXllckB0b3Jj aG1vYmlsZS5jb20+CkRhdGU6IE1vbiwgMiBNYXIgMjAwOSAxMzowNToxMSAtMDUwMApTdWJqZWN0 OiBBbGx3YXlzIHNldCB0aGUgdHJpZ2dlcmluZyBhY3Rpb24gaW4gRnJhbWVMb2FkZXI6OnJlbG9h ZCgpCiBUaGlzIHdpbGwgY2F1c2UgZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0 aW9uKCkgdG8gaGF2ZSB0aGUKIFJlbG9hZCB0eXBlIHJhdGhlciB0aGVuIGZhbGxpbmcgYmFjayB0 byBPdGhlciB3aGVuIG5vdGhpbmcgaXMgc2V0LgoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrCiBXZWJDb3JlL2xvYWRlci9G cmFtZUxvYWRlci5jcHAgICAgICAgICAgICB8ICAgIDMgKysKIFdlYktpdC9xdC9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKwogV2ViS2l0L3F0L3Rl c3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAgfCAgIDMwICsrKysrKysrKysrKysrKysrKysr KysrKystLS0KIDQgZmlsZXMgY2hhbmdlZCwgNTcgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMo LSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBXZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdGVzdGZpbGUu aHRtbAoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggZWUxMmQxMC4uNmU3MDNjNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMy0wMiAgQmVuamFt aW4gQyBNZXllciAgPGJlbmphbWluLm1leWVyQHRvcmNobW9iaWxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGx3YXlzIHNldCB0aGUgdHJp Z2dlcmluZyBhY3Rpb24gaW4gRnJhbWVMb2FkZXI6OnJlbG9hZCgpCisgICAgICAgIFRoaXMgd2ls bCBjYXVzZSBkaXNwYXRjaERlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oKSB0byBoYXZl IHRoZQorICAgICAgICBSZWxvYWQgdHlwZSByYXRoZXIgdGhlbiBmYWxsaW5nIGJhY2sgdG8gT3Ro ZXIgd2hlbiBub3RoaW5nIGlzIHNldC4KKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VT IEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6cmVsb2FkKToKKwogMjAwOS0wMy0wMiAgQWRh bSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gUm9iZW4gYW5kIHByZXZpb3VzbHkgYnkgRXJpYyBTZWlkZWwgYW5kIFNpbW9uIEZy YXNlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1dlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCBlNjBmNzVhLi40ODc4MzQ2IDEwMDY0NAot LS0gYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwCkBAIC0yNTc1LDYgKzI1NzUsOSBAQCB2b2lkIEZyYW1lTG9hZGVyOjpy ZWxvYWQoYm9vbCBlbmRUb0VuZFJlbG9hZCkKICAgICAvLyBJZiB3ZSdyZSBhYm91dCB0byByZS1w b3N0LCBzZXQgdXAgYWN0aW9uIHNvIHRoZSBhcHBsaWNhdGlvbiBjYW4gd2FybiB0aGUgdXNlci4K ICAgICBpZiAocmVxdWVzdC5odHRwTWV0aG9kKCkgPT0gIlBPU1QiKQogICAgICAgICBsb2FkZXIt PnNldFRyaWdnZXJpbmdBY3Rpb24oTmF2aWdhdGlvbkFjdGlvbihyZXF1ZXN0LnVybCgpLCBOYXZp Z2F0aW9uVHlwZUZvcm1SZXN1Ym1pdHRlZCkpOworICAgIGVsc2UKKyAgICAgICAgbG9hZGVyLT5z ZXRUcmlnZ2VyaW5nQWN0aW9uKE5hdmlnYXRpb25BY3Rpb24ocmVxdWVzdC51cmwoKSwKKyAgICAg ICAgICAgICAgICAgICAgZW5kVG9FbmRSZWxvYWQgPyBGcmFtZUxvYWRUeXBlUmVsb2FkRnJvbU9y aWdpbiA6IEZyYW1lTG9hZFR5cGVSZWxvYWQsIDApKTsKIAogICAgIGxvYWRlci0+c2V0T3ZlcnJp ZGVFbmNvZGluZyhtX2RvY3VtZW50TG9hZGVyLT5vdmVycmlkZUVuY29kaW5nKCkpOwogICAgIApk aWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5k ZXggNzQwNjhlMC4uZjc2ZTgzNyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysg Yi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMDMtMDIgIEJlbmph bWluIEMgTWV5ZXIgIDxiZW5qYW1pbi5tZXllckB0b3JjaG1vYmlsZS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsd2F5cyBzZXQgdGhlIHRy aWdnZXJpbmcgYWN0aW9uIGluIEZyYW1lTG9hZGVyOjpyZWxvYWQoKQorICAgICAgICBUaGlzIHdp bGwgY2F1c2UgZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKCkgdG8gaGF2 ZSB0aGUKKyAgICAgICAgUmVsb2FkIHR5cGUgcmF0aGVyIHRoZW4gZmFsbGluZyBiYWNrIHRvIE90 aGVyIHdoZW4gbm90aGluZyBpcyBzZXQuCisKKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS8uZ2l0 aWdub3JlOiBBZGRlZC4KKyAgICAgICAgKiB0ZXN0cy9xd2VicGFnZS90ZXN0ZmlsZS5odG1sOiBD b3BpZWQgZnJvbSBCdWdzU2l0ZS9kYXRhL21haWwuCisgICAgICAgICogdGVzdHMvcXdlYnBhZ2Uv dHN0X3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKE5hdmlnYXRpb25SZXF1ZXN0T3ZlcnJpZGU6Ok5h dmlnYXRpb25SZXF1ZXN0T3ZlcnJpZGUpOgorICAgICAgICAoTmF2aWdhdGlvblJlcXVlc3RPdmVy cmlkZTo6YWNjZXB0TmF2aWdhdGlvblJlcXVlc3QpOgorICAgICAgICAodHN0X1FXZWJQYWdlOjpy ZWxvYWQpOgorCiAyMDA5LTAyLTI1ICBLYXZpbmRyYSBQYWxhcmFqYSAgPGthdmluZHJhLnBhbGFy YWphQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlm ZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90ZXN0ZmlsZS5odG1sIGIvV2ViS2l0 L3F0L3Rlc3RzL3F3ZWJwYWdlL3Rlc3RmaWxlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uZTY5ZGUyOQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdl L3RzdF9xd2VicGFnZS5jcHAgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdl LmNwcAppbmRleCA2ZjJjZTNiLi43MGM4Njg0IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMv cXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAorKysgYi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2Uv dHN0X3F3ZWJwYWdlLmNwcApAQCAtMTA1LDYgKzEwNSw3IEBAIHByaXZhdGUgc2xvdHM6CiAgICAg dm9pZCBjdXJzb3JNb3ZlbWVudHMoKTsKICAgICB2b2lkIHRleHRTZWxlY3Rpb24oKTsKICAgICB2 b2lkIHRleHRFZGl0aW5nKCk7CisgICAgdm9pZCByZWxvYWQoKTsKIAogcHJpdmF0ZToKIApAQCAt MTUzLDE1ICsxNTQsMjUgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmNsZWFudXBUZXN0Q2FzZSgpCiBj bGFzcyBOYXZpZ2F0aW9uUmVxdWVzdE92ZXJyaWRlIDogcHVibGljIFFXZWJQYWdlCiB7CiBwdWJs aWM6Ci0gICAgTmF2aWdhdGlvblJlcXVlc3RPdmVycmlkZShRV2ViVmlldyogcGFyZW50LCBib29s IGluaXRpYWxWYWx1ZSkgOiBRV2ViUGFnZShwYXJlbnQpLCBtX2FjY2VwdE5hdmlnYXRpb25SZXF1 ZXN0KGluaXRpYWxWYWx1ZSkge30KKyAgICBOYXZpZ2F0aW9uUmVxdWVzdE92ZXJyaWRlKFFXZWJW aWV3KiBwYXJlbnQsIGJvb2wgaW5pdGlhbFZhbHVlKQorICAgICAgICA6IFFXZWJQYWdlKHBhcmVu dCkKKyAgICAgICAgLCBtX2FjY2VwdE5hdmlnYXRpb25SZXF1ZXN0KGluaXRpYWxWYWx1ZSkKKyAg ICAgICAgLCBtX2ZyYW1lKDApIHt9CiAKICAgICBib29sIG1fYWNjZXB0TmF2aWdhdGlvblJlcXVl c3Q7CisKKyAgICBRV2ViRnJhbWUqIG1fZnJhbWU7CisgICAgUU5ldHdvcmtSZXF1ZXN0IG1fcmVx dWVzdDsKKyAgICBRV2ViUGFnZTo6TmF2aWdhdGlvblR5cGUgbV90eXBlOworCiBwcm90ZWN0ZWQ6 CiAgICAgdmlydHVhbCBib29sIGFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0KFFXZWJGcmFtZSogZnJh bWUsIGNvbnN0IFFOZXR3b3JrUmVxdWVzdCAmcmVxdWVzdCwgUVdlYlBhZ2U6Ok5hdmlnYXRpb25U eXBlIHR5cGUpIHsKLSAgICAgICAgUV9VTlVTRUQoZnJhbWUpOwotICAgICAgICBRX1VOVVNFRChy ZXF1ZXN0KTsKLSAgICAgICAgUV9VTlVTRUQodHlwZSk7CisgICAgICAgIG1fZnJhbWUgPSBmcmFt ZTsKKyAgICAgICAgbV9yZXF1ZXN0ID0gcmVxdWVzdDsKKyAgICAgICAgbV90eXBlID0gdHlwZTsK IAorICAgICAgICBpZiAobV9hY2NlcHROYXZpZ2F0aW9uUmVxdWVzdCkKKyAgICAgICAgICAgIFFX ZWJQYWdlOjphY2NlcHROYXZpZ2F0aW9uUmVxdWVzdChmcmFtZSwgcmVxdWVzdCwgdHlwZSk7CiAg ICAgICAgIHJldHVybiBtX2FjY2VwdE5hdmlnYXRpb25SZXF1ZXN0OwogICAgIH0KIH07CkBAIC05 NzgsNiArOTg5LDE3IEBAIHZvaWQgdHN0X1FXZWJQYWdlOjp0ZXh0RWRpdGluZygpCiAgICAgZGVs ZXRlIHBhZ2U7CiB9CiAKK3ZvaWQgdHN0X1FXZWJQYWdlOjpyZWxvYWQoKQoreworICAgIFFTaWdu YWxTcHkgbG9hZFNweShtX3ZpZXcsIFNJR05BTChsb2FkRmluaXNoZWQoYm9vbCkpKTsKKworICAg IE5hdmlnYXRpb25SZXF1ZXN0T3ZlcnJpZGUqIG5ld1BhZ2UgPSBuZXcgTmF2aWdhdGlvblJlcXVl c3RPdmVycmlkZShtX3ZpZXcsIHRydWUpOworICAgIG1fdmlldy0+c2V0UGFnZShuZXdQYWdlKTsK KyAgICBtX3ZpZXctPmxvYWQoUVVybDo6ZnJvbUxvY2FsRmlsZShRRGlyOjpjdXJyZW50UGF0aCgp ICsgIi90ZXN0ZmlsZS5odG1sIikpOworICAgIFFUUllfQ09NUEFSRShsb2FkU3B5LmNvdW50KCks IDEpOworICAgIG1fdmlldy0+cmVsb2FkKCk7CisgICAgUVRSWV9DT01QQVJFKG5ld1BhZ2UtPm1f dHlwZSwgUVdlYlBhZ2U6Ok5hdmlnYXRpb25UeXBlUmVsb2FkKTsKK30KIAogUVRFU1RfTUFJTih0 c3RfUVdlYlBhZ2UpCiAjaW5jbHVkZSAidHN0X3F3ZWJwYWdlLm1vYyIKLS0gCjEuNS42LjMKCg==