242798 2022-07-15 07:50:39 -0700 Inline element with a block ::before following a floated element is cleared 2022-08-03 08:34:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 erik+webkit zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1884030 0 460925 erik+webkit 2022-07-15 07:50:39 -0700 Created attachment 460925 Floated block followed by an inline element. Elements with `float: right` followed by an inline container (set to `clear: both`) with ::before pseudo-element set to `display: block` inside it make the inline element truly cleared. If `clear: both` is omitted, all works fine. If there is no `::before` block pseudoelement, it works fine. (Works fine = consistently with other browsers and previously observed behavior.) Chrome, Firefox and Safari Technology Preview 142 render it the same way, with content immediately after the floated element wrapping around it. Safari Technology Preview 147+ and Safari 16.0 force the element to be cleared. See my attached example. I think this is because the ::before block pseudo-element gets put outside its parent inline element. I'm not sure if this is necessarily a bug. I couldn't test other versions of Safari, as they're impossible to download... 1885958 1 webkit-bug-importer 2022-07-22 07:51:14 -0700 <rdar://problem/97436662> 1888495 2 zalan 2022-08-02 14:01:16 -0700 > I think this is because the ::before block pseudo-element gets put outside > its parent inline element. I'm not sure if this is necessarily a bug. I > couldn't test other versions of Safari, as they're impossible to download... Thank you for the test reduction. I think 'clear' confuses our inline layout and inflates the formatting context root's height. Looking into it now. 1888557 3 461368 zalan 2022-08-02 18:44:46 -0700 Created attachment 461368 Patch 1888631 4 ews-feeder 2022-08-03 08:34:43 -0700 Committed 253076@main (2c461c54b9fa): <https://commits.webkit.org/253076@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461368. 460925 2022-07-15 07:50:39 -0700 2022-07-15 07:50:39 -0700 Floated block followed by an inline element. safari_clear_both.html text/html 958 erik+webkit PGh0bWw+CjxoZWFkPgoJPHN0eWxlPgoJCW1haW4gewoJCQl3aWR0aDogNTAwcHg7CgkJCW1hcmdp bjogMCBhdXRvOwoJCX0KCQlkaXYuZmxvYXRlZCB7CgkJCWZsb2F0OiByaWdodDsKCQkJYmFja2dy b3VuZDogZ3JlZW47CgkJCXdpZHRoOiAyNTBweDsKCQkJaGVpZ2h0OiAyNTBweDsKCQl9CgkJZGl2 LmZsb2F0ZWQgKyBwIHsKCQkJZGlzcGxheTogaW5saW5lOwoJCQljbGVhcjogYm90aDsgLyogaW4g bmV3IFNhZmFyaSwgdG8gbWF0Y2ggb3RoZXIgYnJvd3NlcnMsIGBjbGVhcjogYm90aGAgY2Fubm90 IHNldCAqLwoJCX0KCQlkaXYuZmxvYXRlZCArIHA6OmJlZm9yZSB7CgkJCWRpc3BsYXk6IGJsb2Nr OwoJCQljb250ZW50OiAnJzsKCQkJbWFyZ2luLXRvcDogMmVtOwoJCQltYXJnaW4tYm90dG9tOiAy ZW07CgkJfQoJPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4KCTxtYWluPgoJCTxwPkxvcmVtIGlwc3Vt IGRvbG9yIHNpdCBhbWV0LCBjb25zZWN0ZXR1ciBhZGlwaXNjaW5nIGVsaXQsIHNlZCBkbyBlaXVz bW9kIHRlbXBvciBpbmNpZGlkdW50IHV0IGxhYm9yZSBldCBkb2xvcmUgbWFnbmEgYWxpcXVhLiBV dCBlbmltIGFkIG1pbmltIHZlbmlhbSwgcXVpcyBub3N0cnVkIGV4ZXJjaXRhdGlvbiB1bGxhbWNv IGxhYm9yaXMgbmlzaSB1dCBhbGlxdWlwIGV4IGVhIGNvbW1vZG8gY29uc2VxdWF0LjwvcD4KCQk8 ZGl2IGNsYXNzPSJmbG9hdGVkIj48L2Rpdj4KCQk8cD5EdWlzIGF1dGUgaXJ1cmUgZG9sb3IgaW4g cmVwcmVoZW5kZXJpdCBpbiB2b2x1cHRhdGUgdmVsaXQgZXNzZSBjaWxsdW0gZG9sb3JlIGV1IGZ1 Z2lhdCBudWxsYSBwYXJpYXR1ci4gRXhjZXB0ZXVyIHNpbnQgb2NjYWVjYXQgY3VwaWRhdGF0IG5v biBwcm9pZGVudCwgc3VudCBpbiBjdWxwYSBxdWkgb2ZmaWNpYSBkZXNlcnVudCBtb2xsaXQgYW5p bSBpZCBlc3QgbGFib3J1bS48L3A+Cgk8L21haW4+CjwvYm9keT4KPC9odG1sPg== 461368 2022-08-02 18:44:46 -0700 2022-08-03 08:34:44 -0700 Patch bug-242798-20220802184445.patch text/plain 4057 zalan RnJvbSAwODI1YTYwNTViMGNjZTlmODZmMjliMDVkZmE5M2JjOGE5ZDE1MDExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJ1anRhcyA8emFsYW5AYXBwbGUuY29tPgpEYXRlOiBU dWUsIDIgQXVnIDIwMjIgMTg6MzU6MjggLTA3MDAKU3ViamVjdDogW1BBVENIXSBJbmxpbmUgZWxl bWVudCB3aXRoIGEgYmxvY2sgOjpiZWZvcmUgZm9sbG93aW5nIGEgZmxvYXRlZAogZWxlbWVudCBp cyBjbGVhcmVkIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDI3OTgK IDxyZGFyOi8vcHJvYmxlbS85NzQzNjY2Mj4KClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoK VGhpcyBwYXRjaCBkaXNhYmxlcyB0aGUgSUZDIGNvZGVwYXRoIGZvciBpbmxpbmUgY29udGVudCB3 aGVuIHRoZSBmb3JtYXR0aW5nIGNvbnRleHQgaGFzIHRoZSBjb21iaW5hdGlvbiBvZiBpbnRydXNp dmUgZmxvYXQgYW5kIG5vbi1saW5lLWJyZWFrIGlubGluZSBsZXZlbCBlbGVtZW50IHdpdGggImNs ZWFyIi4KCklGQyBoYXMgcGFydGlhbCAiY2xlYXIiIGltcGxlbWVudGF0aW9uLgoxLiByMjY4MjAy IGVuYWJsZWQgImNsZWFyIiBzcGVjaWZpY2FsbHkgZm9yIDxicj4KMi4gcjI5MDg2OCAod2hlcmUg ZmxvYXRzIGdvdCBlbmFibGVkKSBmYWlsZWQgdG8gY2hlY2sgYWdhaW5zdCB0aGUgcmVzdCBvZiB0 aGUgbm9uLWxpbmUtYnJlYWsgdHlwZSBvZiBjb250ZW50IGZvciBjbGVhci4KCiogTGF5b3V0VGVz dHMvZmFzdC9ibG9jay9mbG9hdC9jbGVhci1zdHJldGNoZXMtYmxvY2staGVpZ2h0LWluY29ycmVj dC1leHBlY3RlZC5odG1sOiBBZGRlZC4KKiBMYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Ns ZWFyLXN0cmV0Y2hlcy1ibG9jay1oZWlnaHQtaW5jb3JyZWN0Lmh0bWw6IEFkZGVkLgoqIFNvdXJj ZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkNvdmVyYWdlLmNw cDoKKFdlYkNvcmU6OkxheW91dEludGVncmF0aW9uOjpjYW5Vc2VGb3JMaW5lTGF5b3V0V2l0aFJl YXNvbik6Ci0tLQogLi4uL2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJhZ2UuY3Bw IHwgIDcgKysrKysrLQogLi4udGNoZXMtYmxvY2staGVpZ2h0LWluY29ycmVjdC1leHBlY3RlZC5o dG1sIHwgIDEgKwogLi4ubGVhci1zdHJldGNoZXMtYmxvY2staGVpZ2h0LWluY29ycmVjdC5odG1s IHwgMTkgKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9i bG9jay9mbG9hdC9jbGVhci1zdHJldGNoZXMtYmxvY2staGVpZ2h0LWluY29ycmVjdC1leHBlY3Rl ZC5odG1sCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9mbG9hdC9j bGVhci1zdHJldGNoZXMtYmxvY2staGVpZ2h0LWluY29ycmVjdC5odG1sCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJh Z2UuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0 aW9uQ292ZXJhZ2UuY3BwCmluZGV4IDFlNjU0OGQ1ODFjNi4uYThjMTk4Yjc0MThkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25D b3ZlcmFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91 dEludGVncmF0aW9uQ292ZXJhZ2UuY3BwCkBAIC00ODQsOSArNDg0LDE0IEBAIE9wdGlvblNldDxB dm9pZGFuY2VSZWFzb24+IGNhblVzZUZvckxpbmVMYXlvdXRXaXRoUmVhc29uKGNvbnN0IFJlbmRl ckJsb2NrRmxvdyYKICAgICAgICAgU0VUX1JFQVNPTl9BTkRfUkVUVVJOX0lGX05FRURFRChGbG93 SXNQYWdpbmF0ZWQsIHJlYXNvbnMsIGluY2x1ZGVSZWFzb25zKTsKICAgICAvLyBUaGlzIGN1cnJl bnRseSBjb3ZlcnMgPGJsb2NrZmxvdz4jdGV4dDwvYmxvY2tmbG93PiwgPGJsb2NrZmxvdz4jdGV4 dDxicj48L2Jsb2NrZmxvdz4gYW5kIG11dGlwbGUgKHNpYmxpbmcpIFJlbmRlclRleHQgY2FzZXMu CiAgICAgLy8gVGhlIDxibG9ja2Zsb3c+PGlubGluZT4jdGV4dDwvaW5saW5lPjwvYmxvY2tmbG93 PiBjYXNlIGlzIGFsc28gcG9wdWxhciBhbmQgc2hvdWxkIGJlIHJlbGF0aXZlbHkgZWFzeSB0byBj b3Zlci4KKyAgICBhdXRvIGNvbnRlbnRIYXNGbG9hdCA9IGZsb3cuY29udGFpbnNGbG9hdHMoKTsK ICAgICBmb3IgKGF1dG8gd2Fsa2VyID0gSW5saW5lV2Fsa2VyKGZsb3cpOyAhd2Fsa2VyLmF0RW5k KCk7IHdhbGtlci5hZHZhbmNlKCkpIHsKLSAgICAgICAgaWYgKGF1dG8gY2hpbGRSZWFzb25zID0g Y2FuVXNlRm9yQ2hpbGQoKndhbGtlci5jdXJyZW50KCksIGluY2x1ZGVSZWFzb25zKSkKKyAgICAg ICAgYXV0byYgY2hpbGQgPSAqd2Fsa2VyLmN1cnJlbnQoKTsKKyAgICAgICAgaWYgKGF1dG8gY2hp bGRSZWFzb25zID0gY2FuVXNlRm9yQ2hpbGQoY2hpbGQsIGluY2x1ZGVSZWFzb25zKSkKICAgICAg ICAgICAgIEFERF9SRUFTT05TX0FORF9SRVRVUk5fSUZfTkVFREVEKGNoaWxkUmVhc29ucywgcmVh c29ucywgaW5jbHVkZVJlYXNvbnMpOworICAgICAgICBhdXRvIG5vbkxpbmVCcmVha0JveFdpdGhG bG9hdENsZWFyID0gY29udGVudEhhc0Zsb2F0ICYmICFpczxSZW5kZXJMaW5lQnJlYWs+KGNoaWxk KSAmJiBSZW5kZXJTdHlsZTo6dXNlZENsZWFyKGNoaWxkKSAhPSBVc2VkQ2xlYXI6Ok5vbmU7Cisg ICAgICAgIGlmIChub25MaW5lQnJlYWtCb3hXaXRoRmxvYXRDbGVhcikKKyAgICAgICAgICAgIFNF VF9SRUFTT05fQU5EX1JFVFVSTl9JRl9ORUVERUQoRmxvd0hhc1Vuc3VwcG9ydGVkRmxvYXQsIHJl YXNvbnMsIGluY2x1ZGVSZWFzb25zKTsKICAgICB9CiAgICAgYXV0byBzdHlsZVJlYXNvbnMgPSBj YW5Vc2VGb3JTdHlsZShmbG93LCBpbmNsdWRlUmVhc29ucyk7CiAgICAgaWYgKHN0eWxlUmVhc29u cykKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvY2xlYXItc3RyZXRj aGVzLWJsb2NrLWhlaWdodC1pbmNvcnJlY3QtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvYmxvY2svZmxvYXQvY2xlYXItc3RyZXRjaGVzLWJsb2NrLWhlaWdodC1pbmNvcnJlY3QtZXhw ZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLjdjODli NTQ1YzVhYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQv Y2xlYXItc3RyZXRjaGVzLWJsb2NrLWhlaWdodC1pbmNvcnJlY3QtZXhwZWN0ZWQuaHRtbApAQCAt MCwwICsxIEBACis8ZGl2PjwvZGl2PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ibG9j ay9mbG9hdC9jbGVhci1zdHJldGNoZXMtYmxvY2staGVpZ2h0LWluY29ycmVjdC5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9ibG9jay9mbG9hdC9jbGVhci1zdHJldGNoZXMtYmxvY2staGVpZ2h0LWlu Y29ycmVjdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uNDE4 OWJhN2ZjYTY2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9mbG9h dC9jbGVhci1zdHJldGNoZXMtYmxvY2staGVpZ2h0LWluY29ycmVjdC5odG1sCkBAIC0wLDAgKzEs MTkgQEAKKzxzdHlsZT4KKy5jb250YWluZXIgeworICB3aWR0aDogNTAwcHg7CisgIGJhY2tncm91 bmQtY29sb3I6IHJlZDsKK30KKworLmZsb2F0ZWQgeworICBmbG9hdDogbGVmdDsKKyAgYmFja2dy b3VuZC1jb2xvcjogdHJhbnNwYXJlbnQ7CisgIHdpZHRoOiAxMDBweDsKKyAgaGVpZ2h0OiAxMDBw eDsKK30KKworLmNsZWFyLWFmdGVyIHsKKyAgY2xlYXI6IGJvdGg7Cit9CisKKzwvc3R5bGU+Cis8 ZGl2IGNsYXNzPWNvbnRhaW5lcj48ZGl2PjwvZGl2PjxkaXYgY2xhc3M9ImZsb2F0ZWQiPjwvZGl2 PjxzcGFuIGNsYXNzPWNsZWFyLWFmdGVyPjwvc3Bhbj48L2Rpdj4KXCBObyBuZXdsaW5lIGF0IGVu ZCBvZiBmaWxlCg==