24276 2009-03-01 13:55:49 -0800 Dropdown / select boxes do not consider the windows task bar in Chrome 2009-03-09 17:23:04 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED http://www.joeterranova.net/code/breakchrome.php P4 Minor --- 1 kimworking kimworking oldest_to_newest 111739 0 kimworking 2009-03-01 13:55:49 -0800 What steps will reproduce the problem? 1. Open Chrome 2. Go to http://www.joeterranova.net/code/breakchrome.php 3. Scroll to the bottom 4. Click the select box. What is the expected result? There's enough room to open the select box downward, but it is taken up by the Windows taskbar. The dropdown should either be shown over the taskbar, or opened upward instead. Also tracked in the Chromium bug tracker at http://code.google.com/p/chromium/issues/detail?id=127 What happens instead? The dropdown opens downward, under the taskbar. Therefore, not all choices are visible. Screenshot attached so you can see the orientation of things. Might not happen the same way if your taskbar is for example larger or smaller. 111742 1 28150 kimworking 2009-03-01 14:02:52 -0800 Created attachment 28150 Patch Patch where workarea of the screen are used instead of screen size 111743 2 28151 kimworking 2009-03-01 14:08:56 -0800 Created attachment 28151 Patch which fixed the dropdown rendering problem Patch where the available screen size are used instead of the actual screen size 112915 3 28151 fishd 2009-03-09 17:20:14 -0700 Comment on attachment 28151 Patch which fixed the dropdown rendering problem LGTM, nice fix! In the future, please add your full name and email address to the ChangeLog. Also, it is a good idea to add a descriptive summary to the ChangeLog and include a link to this bug in there. Thanks for the fix! 112917 4 fishd 2009-03-09 17:23:04 -0700 Landed as http://trac.webkit.org/changeset/41542 28150 2009-03-01 14:02:52 -0800 2009-03-01 14:08:56 -0800 Patch chromiumdropdown.txt text/plain 686 kimworking SW5kZXg6IFBvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQb3B1cE1lbnVDaHJv bWl1bS5jcHAJKHJldmlzaW9uIDQxMzIyKQorKysgUG9wdXBNZW51Q2hyb21pdW0uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zMzcsNyArMzM3LDcgQEAgdm9pZCBQb3B1cENvbnRhaW5lcjo6c2hvd1Bv cHVwKEZyYW1lVmlldwogICAgIGlmIChjaHJvbWVDbGllbnQpIHsKICAgICAgICAgLy8gSWYgdGhl IHBvcHVwIHdvdWxkIGV4dGVuZCBwYXN0IHRoZSBib3R0b20gb2YgdGhlIHNjcmVlbiwgb3BlbiB1 cHdhcmRzCiAgICAgICAgIC8vIGluc3RlYWQuCi0gICAgICAgIEZsb2F0UmVjdCBzY3JlZW4gPSBz Y3JlZW5SZWN0KHZpZXcpOworICAgICAgICBGbG9hdFJlY3Qgc2NyZWVuID0gc2NyZWVuQXZhaWxh YmxlUmVjdCh2aWV3KTsKICAgICAgICAgSW50UmVjdCB3aWRnZXRSZWN0ID0gY2hyb21lQ2xpZW50 LT53aW5kb3dUb1NjcmVlbihmcmFtZVJlY3QoKSk7CiAgICAgICAgIGlmICh3aWRnZXRSZWN0LmJv dHRvbSgpID4gc3RhdGljX2Nhc3Q8aW50PihzY3JlZW4uYm90dG9tKCkpKQogICAgICAgICAgICAg d2lkZ2V0UmVjdC5tb3ZlKDAsIC0od2lkZ2V0UmVjdC5oZWlnaHQoKSArIHNlbGVjdEhlaWdodCkp Owo= 28151 2009-03-01 14:08:56 -0800 2009-03-09 17:20:14 -0700 Patch which fixed the dropdown rendering problem chromiumdropdown.txt text/plain 1293 kimworking SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTM0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDMtMDEgIGtpYyAgPHNldCBFTUFJTF9BRERSRVNTIGVudmly b25tZW50IHZhcmlhYmxlPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAg ICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6UG9wdXBDb250YWluZXI6OnNob3dQb3B1cCk6CisKIDIwMDktMDMtMDEgIERhdmlk IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhl eSBQcm9za3VyeWFrb3YuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVu dUNocm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Bv cHVwTWVudUNocm9taXVtLmNwcAkocmV2aXNpb24gNDEzMjIpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM3LDcg KzMzNyw3IEBAIHZvaWQgUG9wdXBDb250YWluZXI6OnNob3dQb3B1cChGcmFtZVZpZXcKICAgICBp ZiAoY2hyb21lQ2xpZW50KSB7CiAgICAgICAgIC8vIElmIHRoZSBwb3B1cCB3b3VsZCBleHRlbmQg cGFzdCB0aGUgYm90dG9tIG9mIHRoZSBzY3JlZW4sIG9wZW4gdXB3YXJkcwogICAgICAgICAvLyBp bnN0ZWFkLgotICAgICAgICBGbG9hdFJlY3Qgc2NyZWVuID0gc2NyZWVuUmVjdCh2aWV3KTsKKyAg ICAgICAgRmxvYXRSZWN0IHNjcmVlbiA9IHNjcmVlbkF2YWlsYWJsZVJlY3Qodmlldyk7CiAgICAg ICAgIEludFJlY3Qgd2lkZ2V0UmVjdCA9IGNocm9tZUNsaWVudC0+d2luZG93VG9TY3JlZW4oZnJh bWVSZWN0KCkpOwogICAgICAgICBpZiAod2lkZ2V0UmVjdC5ib3R0b20oKSA+IHN0YXRpY19jYXN0 PGludD4oc2NyZWVuLmJvdHRvbSgpKSkKICAgICAgICAgICAgIHdpZGdldFJlY3QubW92ZSgwLCAt KHdpZGdldFJlY3QuaGVpZ2h0KCkgKyBzZWxlY3RIZWlnaHQpKTsK