<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>242757</bug_id>
          
          <creation_ts>2022-07-14 10:52:29 -0700</creation_ts>
          <short_desc>JavaScriptCore source files are missing includes when compiling them in a non-unified build</short_desc>
          <delta_ts>2022-09-27 10:43:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Trivial</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Argyrios Kyrtzidis">akyrtzi</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1883678</commentid>
    <comment_count>0</comment_count>
    <who name="Argyrios Kyrtzidis">akyrtzi</who>
    <bug_when>2022-07-14 10:52:29 -0700</bug_when>
    <thetext>Due to unified sources bundling there are implicit dependencies between implementation files and if the files get compiled on their own it leads to compiler or linker errors, due to missing includes.

It would be good to add the missing includes so they can compile on their own, which is beneficial even for the unified build because adding/removing files changes the unified source partitions and can expose these errors later on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1883681</commentid>
    <comment_count>1</comment_count>
    <who name="Argyrios Kyrtzidis">akyrtzi</who>
    <bug_when>2022-07-14 11:06:10 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/2419</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1885722</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-07-21 10:53:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/97389174&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1901564</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-09-27 10:43:48 -0700</bug_when>
    <thetext>Committed 254924@main (01ab6c22fca2): &lt;https://commits.webkit.org/254924@main&gt;

Reviewed commits have been landed. Closing PR #2419 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>