24274 2009-03-01 13:23:47 -0800 [Qt] WebKit Qt build fails on Mac with Qt 4.4.2 2009-03-27 05:47:43 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 elbunce webkit-unassigned elbunce hausmann oldest_to_newest 111726 0 elbunce 2009-03-01 13:23:47 -0800 WebKit Qt build fails on Mac with Qt 4.4.2 built with: $ ./WebKitTools/Scripts/build-webkit --qt --debug The first failure is: ../../../WebCore/platform/text/mac/StringImplMac.mm -o tmp/StringImplMac.o ../../../WebCore/platform/mac/FoundationExtras.h: In function ‘objc_object* HardRetain(objc_object*)’: ../../../WebCore/platform/mac/FoundationExtras.h:35: error: ‘CFRetain’ was not declared in this scope ../../../WebCore/platform/mac/FoundationExtras.h: In function ‘void HardRelease(objc_object*)’: ../../../WebCore/platform/mac/FoundationExtras.h:41: error: ‘CFRelease’ was not declared in this scope ../../../WebCore/platform/mac/FoundationExtras.h: In function ‘objc_object* HardRetainWithNSRelease(objc_object*)’: ../../../WebCore/platform/mac/FoundationExtras.h:57: warning: no ‘-release’ method found ../../../WebCore/platform/mac/FoundationExtras.h:57: warning: (Messages without a matching method signature ../../../WebCore/platform/mac/FoundationExtras.h:57: warning: will be assumed to return ‘id’ and accept ../../../WebCore/platform/mac/FoundationExtras.h:57: warning: ‘...’ as arguments.) ../../../WebCore/platform/mac/FoundationExtras.h: At global scope: ../../../WebCore/platform/mac/FoundationExtras.h:66: error: ‘HardAutorelease’ declared as an ‘inline’ variable ../../../WebCore/platform/mac/FoundationExtras.h:66: error: ‘CFTypeRef’ was not declared in this scope ../../../WebCore/platform/mac/FoundationExtras.h:67: error: expected ‘,’ or ‘;’ before ‘{’ token ../../../WebCore/platform/text/mac/StringImplMac.mm: In member function ‘WebCore::StringImpl::operator NSString*()’: ../../../WebCore/platform/text/mac/StringImplMac.mm:30: error: ‘HardAutorelease’ cannot be used as a function make[1]: *** [tmp/StringImplMac.o] Error 1 This was caused by the migration by the Mac port to use FoundationExtras.h (which didn't include the <Foundation/Foundation.h> header). After fixing that problem we get: ../../../WebCore/plugins/mac/PluginViewMac.cpp: ../../../WebCore/plugins/mac/PluginViewMac.cpp:72: error: ‘JSC::JSValue’ has not been declared ../../../WebCore/plugins/mac/PluginViewMac.cpp:79: error: ‘OSWindowRef’ does not name a type make[1]: *** [tmp/PluginViewMac.o] Error 1 The JSC::JSValue error is caused by the in-progress migration through the new JSC::JSValuePtr rework. The second is caused by the typedef being different between Qt 4.4.x (WindowPtr) and Qt 4.5 (OSWindowRef). 111727 1 28146 elbunce 2009-03-01 13:26:00 -0800 Created attachment 28146 Fixed the Qt 4.4 Mac build with netscape plugins enabled. 111728 2 elbunce 2009-03-01 13:28:24 -0800 This was against svn r41344. 115468 3 28997 elbunce 2009-03-26 18:31:35 -0700 Created attachment 28997 Fixed the Qt 4.4 Mac build with netscape plugins enabled. WebCore/platform/mac/FoundationExtras.h was fixed by svn r41939. Fixes the remaining Qt 4.4 issue. Fixes the general compilation issue caused by the JSC::JSValuePtr transition. 115521 4 28997 hausmann 2009-03-27 05:47:30 -0700 Comment on attachment 28997 Fixed the Qt 4.4 Mac build with netscape plugins enabled. Thanks 115522 5 hausmann 2009-03-27 05:47:43 -0700 Landed in r42033 28146 2009-03-01 13:26:00 -0800 2009-03-26 18:31:35 -0700 Fixed the Qt 4.4 Mac build with netscape plugins enabled. qt44-build.patch text/plain 1704 elbunce SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTM0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDMtMDEgIEVyaWsgQnVuY2UgIDxrZGVAYnVuY2UudXM+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlGaXhlZCB0aGUgUXQgNC40 IE1hYyBidWlsZCB3aXRoIG5ldHNjYXBlIHBsdWdpbnMgZW5hYmxlZC4KKworICAgICAgICAqIHBs YXRmb3JtL21hYy9Gb3VuZGF0aW9uRXh0cmFzLmg6CisgICAgICAgICogcGx1Z2lucy9tYWMvUGx1 Z2luVmlld01hYy5jcHA6CisKIDIwMDktMDMtMDEgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL21hYy9Gb3VuZGF0aW9uRXh0cmFzLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbGF0Zm9ybS9tYWMvRm91bmRhdGlvbkV4dHJhcy5oCShyZXZpc2lvbiA0MTMzMykK KysrIFdlYkNvcmUvcGxhdGZvcm0vbWFjL0ZvdW5kYXRpb25FeHRyYXMuaAkod29ya2luZyBjb3B5 KQpAQCAtMjMsNiArMjMsOCBAQAogICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisjaW5jbHVkZSA8Rm91 bmRhdGlvbi9Gb3VuZGF0aW9uLmg+CisKIC8vIG5pbC1jaGVja2VkIENGUmV0YWluL0NGUmVsZWFz ZSBjb3ZlcnMgZm9yIE9iamVjdGl2ZS1DIGlkcwogCiAvLyBVc2UgQ0ZSZXRhaW4sIENGUmVsZWFz ZSwgSGFyZFJldGFpbiwgb3IgSGFyZFJlbGVhc2UgaW5zdGVhZCBvZgpJbmRleDogV2ViQ29yZS9w bHVnaW5zL21hYy9QbHVnaW5WaWV3TWFjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdp bnMvbWFjL1BsdWdpblZpZXdNYWMuY3BwCShyZXZpc2lvbiA0MTMzMykKKysrIFdlYkNvcmUvcGx1 Z2lucy9tYWMvUGx1Z2luVmlld01hYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5LDE0ICs2OSwx OCBAQCB1c2luZyBKU0M6OkV4ZWNTdGF0ZTsKIHVzaW5nIEpTQzo6SW50ZXJwcmV0ZXI7CiB1c2lu ZyBKU0M6OkpTTG9jazsKIHVzaW5nIEpTQzo6SlNPYmplY3Q7Ci11c2luZyBKU0M6OkpTVmFsdWU7 Cit1c2luZyBKU0M6OkpTVmFsdWVQdHI7CiB1c2luZyBKU0M6OlVTdHJpbmc7CiAKICNpZiBQTEFU Rk9STShRVCkKICNpbmNsdWRlIDxRV2lkZ2V0PgogI2luY2x1ZGUgPFFLZXlFdmVudD4KIFFUX0JF R0lOX05BTUVTUEFDRQorI2lmIFFUX1ZFUlNJT04gPCAweDA0MDUwMAorZXh0ZXJuIFFfR1VJX0VY UE9SVCBXaW5kb3dQdHIgcXRfbWFjX3dpbmRvd19mb3IoY29uc3QgUVdpZGdldCAqdyk7CisjZWxz ZQogZXh0ZXJuIFFfR1VJX0VYUE9SVCBPU1dpbmRvd1JlZiBxdF9tYWNfd2luZG93X2Zvcihjb25z dCBRV2lkZ2V0ICp3KTsKKyNlbmRpZgogUVRfRU5EX05BTUVTUEFDRQogI2VuZGlmCiAK 28997 2009-03-26 18:31:35 -0700 2009-03-27 05:47:30 -0700 Fixed the Qt 4.4 Mac build with netscape plugins enabled. qt44-build.2.patch text/plain 1217 elbunce SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MjAyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDktMDMtMjYgIEVyaWsgTC4gQnVuY2UgIDxlbGJ1bmNlQHhlbmRv bS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4ZWQgdGhlIFF0IDQuNCBNYWMgYnVpbGQgd2l0aCBuZXRzY2FwZSBwbHVnaW5zIGVuYWJsZWQu CisKKyAgICAgICAgKiBwbHVnaW5zL21hYy9QbHVnaW5WaWV3TWFjLmNwcDoKKwogMjAwOS0wMy0y NiAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTm8gYWRkaXRpb25h bCByZXZpZXcsIGNvbW1pdHRpbmcgcHJldmlvdXNseSByZXZpZXdlZCBmaWxlcyBmb3IgYnVpbGQg Zml4IG9ubHkuCkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvbWFjL1BsdWdpblZpZXdNYWMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy9tYWMvUGx1Z2luVmlld01hYy5jcHAJKHJldmlz aW9uIDQyMDA4KQorKysgV2ViQ29yZS9wbHVnaW5zL21hYy9QbHVnaW5WaWV3TWFjLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjksMTQgKzY5LDE4IEBAIHVzaW5nIEpTQzo6RXhlY1N0YXRlOwogdXNp bmcgSlNDOjpJbnRlcnByZXRlcjsKIHVzaW5nIEpTQzo6SlNMb2NrOwogdXNpbmcgSlNDOjpKU09i amVjdDsKLXVzaW5nIEpTQzo6SlNWYWx1ZTsKK3VzaW5nIEpTQzo6SlNWYWx1ZVB0cjsKIHVzaW5n IEpTQzo6VVN0cmluZzsKIAogI2lmIFBMQVRGT1JNKFFUKQogI2luY2x1ZGUgPFFXaWRnZXQ+CiAj aW5jbHVkZSA8UUtleUV2ZW50PgogUVRfQkVHSU5fTkFNRVNQQUNFCisjaWYgUVRfVkVSU0lPTiA8 IDB4MDQwNTAwCitleHRlcm4gUV9HVUlfRVhQT1JUIFdpbmRvd1B0ciBxdF9tYWNfd2luZG93X2Zv cihjb25zdCBRV2lkZ2V0ICp3KTsKKyNlbHNlCiBleHRlcm4gUV9HVUlfRVhQT1JUIE9TV2luZG93 UmVmIHF0X21hY193aW5kb3dfZm9yKGNvbnN0IFFXaWRnZXQgKncpOworI2VuZGlmCiBRVF9FTkRf TkFNRVNQQUNFCiAjZW5kaWYKIAo=