242726 2022-07-13 17:01:12 -0700 git-webkit setup crashes when the macOS keychain is locked 2023-01-18 11:17:56 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 242647 https://bugs.webkit.org/show_bug.cgi?id=242647 InRadar P2 Normal --- 239082 1 emw webkit-unassigned ap jbedard webkit-bug-importer oldest_to_newest 1883464 0 emw 2022-07-13 17:01:12 -0700 If your session does not have a keychain unlocked (e.g. you're connected via ssh), git-webkit setup crashes without an actionable message: Provide github.com username and access token to create and update pull requests Username: emw-apple Token: Store username and token in system keyring for https://api.github.com? ([Yes]/No): Storing credentials... Traceback (most recent call last): File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/keyring/backends/macOS/__init__.py", line 38, in set_password api.set_generic_password(self.keychain, service, username, password) File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/keyring/backends/macOS/api.py", line 161, in set_generic_password Error.raise_for_status(status) File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/keyring/backends/macOS/api.py", line 114, in raise_for_status raise cls(status, "Unknown Error") keyring.backends.macOS.api.Error: (-25308, 'Unknown Error') During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/Volumes/Data/OpenSource/Tools/Scripts/git-webkit", line 69, in <module> sys.exit(program.main( File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 148, in main return parsed.main( File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py", line 552, in main result = cls.git(args, repository, **kwargs) File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py", line 388, in git username, password = rmt.credentials() File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 313, in credentials return self.tracker.credentials(required=required, validate=validate, save_in_keyring=save_in_keyring) File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py", line 135, in credentials return webkitcorepy.credentials( File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py", line 121, in credentials keyring.set_password(url, 'username', username) File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/keyring/core.py", line 60, in set_password get_keyring().set_password(service_name, username, password) File "/Volumes/Data/OpenSource/Tools/Scripts/libraries/autoinstalled/python-3-x86_64/keyring/backends/macOS/__init__.py", line 42, in set_password raise PasswordSetError("Can't store password on keychain: " "{}".format(e)) keyring.errors.PasswordSetError: Can't store password on keychain: (-25308, 'Unknown Error') It should either run `security unlock` directly for you, or fail more gracefully. 1883829 1 ap 2022-07-14 14:46:51 -0700 There will still be trouble opening GitHub.com when on ssh, but one could take a token from their keychain on another computer. 1885496 2 webkit-bug-importer 2022-07-20 17:02:17 -0700 <rdar://problem/97348286> 1926330 3 ryanhaddad 2023-01-18 11:17:56 -0800 Duping to https://bugs.webkit.org/show_bug.cgi?id=242647, which is effectively the same issue. *** This bug has been marked as a duplicate of bug 242647 ***