<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24261</bug_id>
          
          <creation_ts>2009-02-28 08:42:13 -0800</creation_ts>
          <short_desc>Fix custom V8 bindings scrubbing errors.</short_desc>
          <delta_ts>2009-03-03 21:41:54 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dimitri Glazkov (Google)">dglazkov</reporter>
          <assigned_to name="Dimitri Glazkov (Google)">dglazkov</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>111623</commentid>
    <comment_count>0</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-28 08:42:13 -0800</bug_when>
    <thetext>fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html was failing because of me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111624</commentid>
    <comment_count>1</comment_count>
      <attachid>28117</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-28 08:48:04 -0800</bug_when>
    <thetext>Created attachment 28117
Fix V8 custom binding scrubbing error, v1.

 WebCore/ChangeLog                                  |   16 ++++++++++++++++
 .../v8/custom/V8CSSStyleDeclarationCustom.cpp      |   19 +++++++------------
 2 files changed, 23 insertions(+), 12 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111632</commentid>
    <comment_count>2</comment_count>
      <attachid>28117</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2009-02-28 10:38:28 -0800</bug_when>
    <thetext>Comment on attachment 28117
Fix V8 custom binding scrubbing error, v1.

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111667</commentid>
    <comment_count>3</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-28 21:00:35 -0800</bug_when>
    <thetext>CSSStyleDeclaration fix landed as http://trac.webkit.org/changeset/41324.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111668</commentid>
    <comment_count>4</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-28 21:04:33 -0800</bug_when>
    <thetext>These revealed that I mistakenly replaced v8::Null() with v8::Undefined().

LayoutTests/fast/dom/TreeWalker/TreeWalker-currentNode.html
LayoutTests/traversal/exception-forwarding.html
LayoutTests/traversal/stay-within-root.html
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111669</commentid>
    <comment_count>5</comment_count>
      <attachid>28133</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-28 21:07:55 -0800</bug_when>
    <thetext>Created attachment 28133
Fix erroneous traversal return values, v1.

 WebCore/ChangeLog                                  |   17 +++++++++++++++++
 .../bindings/v8/custom/V8NodeIteratorCustom.cpp    |    2 +-
 WebCore/bindings/v8/custom/V8TreeWalkerCustom.cpp  |    2 +-
 3 files changed, 19 insertions(+), 2 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111671</commentid>
    <comment_count>6</comment_count>
      <attachid>28133</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2009-02-28 21:22:26 -0800</bug_when>
    <thetext>Comment on attachment 28133
Fix erroneous traversal return values, v1.

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>111961</commentid>
    <comment_count>7</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-03-02 20:23:40 -0800</bug_when>
    <thetext>TreeWalker/NodeIterator fix landed as http://trac.webkit.org/changeset/41325.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112132</commentid>
    <comment_count>8</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-03-03 21:22:00 -0800</bug_when>
    <thetext>I am ashamed to admit I mixed up return types in V8Binding.h.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112133</commentid>
    <comment_count>9</comment_count>
      <attachid>28256</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-03-03 21:28:07 -0800</bug_when>
    <thetext>Created attachment 28256
Fix return types in helper converters in V8Binding.h

 WebCore/ChangeLog               |   13 +++++++++++++
 WebCore/bindings/v8/V8Binding.h |    4 ++--
 2 files changed, 15 insertions(+), 2 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>112134</commentid>
    <comment_count>10</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-03-03 21:41:54 -0800</bug_when>
    <thetext>Return type fix landed as http://trac.webkit.org/changeset/41415.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28117</attachid>
            <date>2009-02-28 08:48:04 -0800</date>
            <delta_ts>2009-02-28 10:38:28 -0800</delta_ts>
            <desc>Fix V8 custom binding scrubbing error, v1.</desc>
            <filename>Fix-V8-custom-binding-scrubbing-error-v1..patch</filename>
            <type>text/plain</type>
            <size>3560</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">NDZmNmY2ZDQ3ZGJiMmFmZmFmNDRlMzcxZTdiMDQyNGM2MDAxODg4MQpkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzZWI0MjAzLi5mOTRjMjk1
IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE5IEBACisyMDA5LTAyLTI4ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj
aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MjYxCisgICAg
ICAgIEZpeCBWOCBjdXN0b20gYmluZGluZyBzY3J1YmJpbmcgZXJyb3IuCisKKyAgICAgICAgVGVz
dDogZmFzdC9kb20vQ1NTU3R5bGVEZWNsYXJhdGlvbi9jc3MtcHJvcGVydGllcy1jYXNlLXNlbnNp
dGl2ZS5odG1sCisKKyAgICAgICAgKiBXZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6
CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q1NTU3R5bGVEZWNsYXJhdGlvbkN1c3Rv
bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjc3NQcm9wZXJ0eU5hbWUpOiAgUmVtb3ZlIGR1Ymlv
dXMgY2hlY2tzLCBsZWZ0IG92ZXIgZnJvbQorICAgICAgICAgICAgaW5jb21wbGV0ZSBjb252ZXJz
aW9uIG9mIHBhcmFtZXRlciBmcm9tIHBvaW50ZXIgdG8gcGFzcy1ieS1yZWYuCisgICAgICAgIChX
ZWJDb3JlOjpOQU1FRF9QUk9QRVJUWV9HRVRURVIpOiBJbml0aWFsaXplIHBhcmFtZXRlci4KKyAg
ICAgICAgKFdlYkNvcmU6Ok5BTUVEX1BST1BFUlRZX1NFVFRFUik6IERpdHRvLgorCiAyMDA5LTAy
LTI4ICBBZGFtIEJlcmdrdmlzdCA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24uY29tPgogCiAgICAg
ICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9XZWJDb3Jl
L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOENTU1N0eWxlRGVjbGFyYXRpb25DdXN0b20uY3BwIGIvV2Vi
Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDU1NTdHlsZURlY2xhcmF0aW9uQ3VzdG9tLmNwcApp
bmRleCA3YmVmNDFkLi5jODZmOTI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1
c3RvbS9WOENTU1N0eWxlRGVjbGFyYXRpb25DdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGlu
Z3MvdjgvY3VzdG9tL1Y4Q1NTU3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAKQEAgLTg4LDggKzg4
LDcgQEAgc3RhdGljIGJvb2wgaGFzQ1NTUHJvcGVydHlOYW1lUHJlZml4KGNvbnN0IFN0cmluZyYg
cHJvcGVydHlOYW1lLCBjb25zdCBjaGFyKiBwcmUKIC8vIG5vdCB0aGUgcHJvcGVydHkgbmFtZSB3
YXMgcHJlZml4ZWQgd2l0aCAncG9zLScgb3IgJ3BpeGVsLScuCiBzdGF0aWMgU3RyaW5nIGNzc1By
b3BlcnR5TmFtZShjb25zdCBTdHJpbmcmIHByb3BlcnR5TmFtZSwgYm9vbCYgaGFkUGl4ZWxPclBv
c1ByZWZpeCkKIHsKLSAgICBpZiAoaGFkUGl4ZWxPclBvc1ByZWZpeCkKLSAgICAgICAgaGFkUGl4
ZWxPclBvc1ByZWZpeCA9IGZhbHNlOworICAgIGhhZFBpeGVsT3JQb3NQcmVmaXggPSBmYWxzZTsK
IAogICAgIHVuc2lnbmVkIGxlbmd0aCA9IHByb3BlcnR5TmFtZS5sZW5ndGgoKTsKICAgICBpZiAo
IWxlbmd0aCkKQEAgLTEwNCwyMCArMTAzLDE2IEBAIHN0YXRpYyBTdHJpbmcgY3NzUHJvcGVydHlO
YW1lKGNvbnN0IFN0cmluZyYgcHJvcGVydHlOYW1lLCBib29sJiBoYWRQaXhlbE9yUG9zUHJlCiAg
ICAgICAgIGkgKz0gMzsKICAgICBlbHNlIGlmIChoYXNDU1NQcm9wZXJ0eU5hbWVQcmVmaXgocHJv
cGVydHlOYW1lLCAicGl4ZWwiKSkgewogICAgICAgICBpICs9IDU7Ci0gICAgICAgIGlmIChoYWRQ
aXhlbE9yUG9zUHJlZml4KQotICAgICAgICAgICAgaGFkUGl4ZWxPclBvc1ByZWZpeCA9IHRydWU7
CisgICAgICAgIGhhZFBpeGVsT3JQb3NQcmVmaXggPSB0cnVlOwogICAgIH0gZWxzZSBpZiAoaGFz
Q1NTUHJvcGVydHlOYW1lUHJlZml4KHByb3BlcnR5TmFtZSwgInBvcyIpKSB7CiAgICAgICAgIGkg
Kz0gMzsKLSAgICAgICAgaWYgKGhhZFBpeGVsT3JQb3NQcmVmaXgpCi0gICAgICAgICAgICBoYWRQ
aXhlbE9yUG9zUHJlZml4ID0gdHJ1ZTsKKyAgICAgICAgaGFkUGl4ZWxPclBvc1ByZWZpeCA9IHRy
dWU7CiAgICAgfSBlbHNlIGlmIChoYXNDU1NQcm9wZXJ0eU5hbWVQcmVmaXgocHJvcGVydHlOYW1l
LCAid2Via2l0IikKICAgICAgICAgICAgIHx8IGhhc0NTU1Byb3BlcnR5TmFtZVByZWZpeChwcm9w
ZXJ0eU5hbWUsICJraHRtbCIpCiAgICAgICAgICAgICB8fCBoYXNDU1NQcm9wZXJ0eU5hbWVQcmVm
aXgocHJvcGVydHlOYW1lLCAiYXBwbGUiKSkKICAgICAgICAgbmFtZS5hcHBlbmQoJy0nKTsKLSAg
ICBlbHNlIHsKLSAgICAgICAgaWYgKFdURjo6aXNBU0NJSVVwcGVyKHByb3BlcnR5TmFtZVswXSkp
Ci0gICAgICAgICAgICByZXR1cm4gU3RyaW5nKCk7Ci0gICAgfQorICAgIGVsc2UgaWYgKFdURjo6
aXNBU0NJSVVwcGVyKHByb3BlcnR5TmFtZVswXSkpCisgICAgICAgIHJldHVybiBTdHJpbmcoKTsK
IAogICAgIG5hbWUuYXBwZW5kKFdURjo6dG9BU0NJSUxvd2VyKHByb3BlcnR5TmFtZVtpKytdKSk7
CiAKQEAgLTE0NCw3ICsxMzksNyBAQCBOQU1FRF9QUk9QRVJUWV9HRVRURVIoQ1NTU3R5bGVEZWNs
YXJhdGlvbikKICAgICAvLyBTZWFyY2ggdGhlIHN0eWxlIGRlY2xhcmF0aW9uLgogICAgIENTU1N0
eWxlRGVjbGFyYXRpb24qIGltcCA9IFY4UHJveHk6OlRvTmF0aXZlT2JqZWN0PENTU1N0eWxlRGVj
bGFyYXRpb24+KFY4Q2xhc3NJbmRleDo6Q1NTU1RZTEVERUNMQVJBVElPTiwgaW5mby5Ib2xkZXIo
KSk7CiAKLSAgICBib29sIGhhZFBpeGVsT3JQb3NQcmVmaXg7CisgICAgYm9vbCBoYWRQaXhlbE9y
UG9zUHJlZml4ID0gZmFsc2U7CiAgICAgU3RyaW5nIHByb3BlcnR5TmFtZSA9IGNzc1Byb3BlcnR5
TmFtZSh0b1dlYkNvcmVTdHJpbmcobmFtZSksIGhhZFBpeGVsT3JQb3NQcmVmaXgpOwogCiAgICAg
Ly8gRG8gbm90IGhhbmRsZSBub24tcHJvcGVydHkgbmFtZXMuCkBAIC0xNzYsNyArMTcxLDcgQEAg
TkFNRURfUFJPUEVSVFlfU0VUVEVSKENTU1N0eWxlRGVjbGFyYXRpb24pCiAgICAgSU5DX1NUQVRT
KCJET00uQ1NTU3R5bGVEZWNsYXJhdGlvbi5OYW1lZFByb3BlcnR5U2V0dGVyIik7CiAgICAgQ1NT
U3R5bGVEZWNsYXJhdGlvbiogaW1wID0gVjhQcm94eTo6VG9OYXRpdmVPYmplY3Q8Q1NTU3R5bGVE
ZWNsYXJhdGlvbj4oVjhDbGFzc0luZGV4OjpDU1NTVFlMRURFQ0xBUkFUSU9OLCBpbmZvLkhvbGRl
cigpKTsKIAotICAgIGJvb2wgaGFkUGl4ZWxPclBvc1ByZWZpeDsKKyAgICBib29sIGhhZFBpeGVs
T3JQb3NQcmVmaXggPSBmYWxzZTsKICAgICBTdHJpbmcgcHJvcCA9IGNzc1Byb3BlcnR5TmFtZSh0
b1dlYkNvcmVTdHJpbmcobmFtZSksIGhhZFBpeGVsT3JQb3NQcmVmaXgpOwogICAgIGlmICghQ1NT
U3R5bGVEZWNsYXJhdGlvbjo6aXNQcm9wZXJ0eU5hbWUocHJvcCkpCiAgICAgICAgIHJldHVybiBu
b3RIYW5kbGVkQnlJbnRlcmNlcHRvcigpOwo=
</data>
<flag name="review"
          id="13727"
          type_id="1"
          status="+"
          setter="fishd"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28133</attachid>
            <date>2009-02-28 21:07:55 -0800</date>
            <delta_ts>2009-02-28 21:22:26 -0800</delta_ts>
            <desc>Fix erroneous traversal return values, v1.</desc>
            <filename>Fix-erroneous-traversal-return-values-v1..patch</filename>
            <type>text/plain</type>
            <size>2075</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">NTk5MjgyNjlkNDY3NDljNzMxM2U4YWM5OTMzYTYzZTU2OTM5MzAyOApkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMTYxZmUzLi42YjhjZTU5
IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSw1ICsxLDIyIEBACiAyMDA5LTAyLTI4ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj
aHJvbWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MjYxCisgICAg
ICAgIEZpeCBWOCBjdXN0b20gYmluZGluZyBzY3J1YmJpbmcgZXJyb3IuCisKKyAgICAgICAgVGVz
dDogZmFzdC9kb20vVHJlZVdhbGtlci9UcmVlV2Fsa2VyLWN1cnJlbnROb2RlLmh0bWwKKyAgICAg
ICAgVGVzdDogdHJhdmVyc2FsL2V4Y2VwdGlvbi1mb3J3YXJkaW5nLmh0bWwKKyAgICAgICAgVGVz
VDogdHJhdmVyc2FsL3N0YXktd2l0aGluLXJvb3QuaHRtbAorCisgICAgICAgICogYmluZGluZ3Mv
djgvY3VzdG9tL1Y4Q1NTU3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHA6CisgICAgICAgICogYmlu
ZGluZ3MvdjgvY3VzdG9tL1Y4Tm9kZUl0ZXJhdG9yQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OnRvVjgpOiBSZXBsYWNlIHY4OjpVbmRlZmluZWQoKSByZXR1cm4gdmFsdWUgd2l0aCB2ODo6
TnVsbCgpLgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOFRyZWVXYWxrZXJDdXN0b20u
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6dG9WOCk6IERpdHRvLgorCisyMDA5LTAyLTI4ICBEaW1p
dHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQg
YnkgRGFyaW4gRmlzaGVyLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0yNDI2MQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v
VjhOb2RlSXRlcmF0b3JDdXN0b20uY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhO
b2RlSXRlcmF0b3JDdXN0b20uY3BwCmluZGV4IDg1MjY5ZjMuLjQ4ZTZiOGYgMTAwNjQ0Ci0tLSBh
L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm9kZUl0ZXJhdG9yQ3VzdG9tLmNwcAorKysg
Yi9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE5vZGVJdGVyYXRvckN1c3RvbS5jcHAKQEAg
LTUxLDcgKzUxLDcgQEAgc3RhdGljIGlubGluZSB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOChQ
YXNzUmVmUHRyPE5vZGU+IG9iamVjdCwgRXhjZXB0aW9uQ29kZQogICAgICAgICByZXR1cm4gdGhy
b3dFcnJvcihzdGF0ZS0+ZXhjZXB0aW9uKCkpOwogCiAgICAgaWYgKCFvYmplY3QpCi0gICAgICAg
IHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CisgICAgICAgIHJldHVybiB2ODo6TnVsbCgpOwogCiAg
ICAgcmV0dXJuIFY4UHJveHk6Ok5vZGVUb1Y4T2JqZWN0KG9iamVjdC5nZXQoKSk7CiB9CmRpZmYg
LS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFRyZWVXYWxrZXJDdXN0b20uY3Bw
IGIvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhUcmVlV2Fsa2VyQ3VzdG9tLmNwcAppbmRl
eCAwOGZkNjZiLi5iYWY0OWMwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv
bS9WOFRyZWVXYWxrZXJDdXN0b20uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t
L1Y4VHJlZVdhbGtlckN1c3RvbS5jcHAKQEAgLTQ5LDcgKzQ5LDcgQEAgc3RhdGljIGlubGluZSB2
ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdG9WOChQYXNzUmVmUHRyPE5vZGU+IG9iamVjdCwgU2NyaXB0
U3RhdGUqIHMKICAgICAgICAgcmV0dXJuIHRocm93RXJyb3Ioc3RhdGUtPmV4Y2VwdGlvbigpKTsK
IAogICAgIGlmICghb2JqZWN0KQotICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOworICAg
ICAgICByZXR1cm4gdjg6Ok51bGwoKTsKIAogICAgIHJldHVybiBWOFByb3h5OjpOb2RlVG9WOE9i
amVjdChvYmplY3QuZ2V0KCkpOwogfQo=
</data>
<flag name="review"
          id="13739"
          type_id="1"
          status="+"
          setter="fishd"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>28256</attachid>
            <date>2009-03-03 21:28:07 -0800</date>
            <delta_ts>2009-03-03 21:29:51 -0800</delta_ts>
            <desc>Fix return types in helper converters in V8Binding.h</desc>
            <filename>Fix-return-types-in-helper-converters-in-V8Binding.h.patch</filename>
            <type>text/plain</type>
            <size>1304</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">NTgxOTQ5YjVkNGM0ZDMyOWQyYzYxM2MzMTllMmZhZDc4MGRmZmYwYQpkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMGExNzI5Li5mNDdiNTA5
IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE2IEBACisyMDA5LTAzLTAzICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj
aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MjYxCisgICAg
ICAgIEZpeCByZXR1cm4gdHlwZXMuCisKKyAgICAgICAgVGVzdDogTGF5b3V0VGVzdHMvZG9tL3N2
Zy9sZXZlbDMveHBhdGgvWFBhdGhFdmFsdWF0b3JfZXZhbHVhdGVfVFlQRV9FUlIuc3ZnCisKKyAg
ICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OnRvSW50
MzIpOiBjaGFuZ2UgcmV0dXJuIHR5cGUgdG8gaW50CisgICAgICAgIChXZWJDb3JlOjp0b0Zsb2F0
KTogY2hhbmdlIHJldHVybiB0eXBlIHRvIGZsb2F0LgorCiAyMDA5LTAzLTAzICBBbmRlcnMgQ2Fy
bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9obiBT
dWxsaXZhbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmggYi9X
ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oCmluZGV4IGM5ZGMxNTguLjYzNDdhNWYgMTAw
NjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysrIGIvV2ViQ29yZS9i
aW5kaW5ncy92OC9WOEJpbmRpbmcuaApAQCAtMzgsMTIgKzM4LDEyIEBACiBuYW1lc3BhY2UgV2Vi
Q29yZSB7CiAKICAgICAvLyBGSVhNRTogUmVtb3ZlIG9uY2UgbWlncmF0aW9uIGlzIGNvbXBsZXRl
Ci0gICAgaW5saW5lIGJvb2wgdG9JbnQzMih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUpCisg
ICAgaW5saW5lIGludCB0b0ludDMyKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSkKICAgICB7
CiAgICAgICAgIHJldHVybiBUb0ludDMyKHZhbHVlKTsKICAgICB9CiAKLSAgICBpbmxpbmUgYm9v
bCB0b0Zsb2F0KHY4OjpMb2NhbDx2ODo6VmFsdWU+IHZhbHVlKQorICAgIGlubGluZSBmbG9hdCB0
b0Zsb2F0KHY4OjpMb2NhbDx2ODo6VmFsdWU+IHZhbHVlKQogICAgIHsKICAgICAgICAgcmV0dXJu
IHN0YXRpY19jYXN0PGZsb2F0Pih2YWx1ZS0+TnVtYmVyVmFsdWUoKSk7CiAgICAgfQo=
</data>
<flag name="review"
          id="13817"
          type_id="1"
          status="+"
          setter="fishd"
    />
          </attachment>
      

    </bug>

</bugzilla>