242579 2022-07-10 15:00:13 -0700 VM should embed Interpreter. 2022-07-12 16:58:03 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mcatanzaro mcatanzaro webkit-bug-importer oldest_to_newest 1881984 0 mark.lam 2022-07-10 15:00:13 -0700 1. The Interpreter class is empty for release non-cloop builds. 2. There is always a 1:1 pairing between VM and Interpreter. So, there's no point in malloc'ing the Interpreter separately. 1881987 1 mark.lam 2022-07-10 15:04:49 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2281 1882040 2 ews-feeder 2022-07-11 03:31:10 -0700 Committed 252338@main (16e1928aae2e): <https://commits.webkit.org/252338@main> Reviewed commits have been landed. Closing PR #2281 and removing active labels. 1882041 3 webkit-bug-importer 2022-07-11 03:32:17 -0700 <rdar://problem/96817609> 1882699 4 mcatanzaro 2022-07-12 15:38:59 -0700 fyi, this broke the cloop build. It's a shame we don't have an EWS for it. Follow-up incoming. 1882700 5 mark.lam 2022-07-12 15:40:31 -0700 (In reply to Michael Catanzaro from comment #4) > fyi, this broke the cloop build. It's a shame we don't have an EWS for it. > Follow-up incoming. How did this break the CLoop? I deliberately tested for it. The jsc-i386 bot builds CLoop AFAIK. When I checked (before landing), all was well. Please share your details about what actually broke. 1882702 6 mcatanzaro 2022-07-12 15:51:40 -0700 (In reply to Michael Catanzaro from comment #4) > Follow-up incoming. This will probably be tomorrow. It should just be: diff --git a/Source/JavaScriptCore/CMakeLists.txt b/Source/JavaScriptCore/CMakeLists.txt index aef0678e66f3..ee5d8a509284 100644 --- a/Source/JavaScriptCore/CMakeLists.txt +++ b/Source/JavaScriptCore/CMakeLists.txt @@ -840,6 +840,7 @@ set(JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS interpreter/CallFrame.h interpreter/CallFrameInlines.h interpreter/CalleeBits.h + interpreter/CLoopStack.h interpreter/EntryFrame.h interpreter/FrameTracers.h interpreter/Interpreter.h but I need to confirm, and am testing something else right now. 1882704 7 mcatanzaro 2022-07-12 15:52:11 -0700 (In reply to Mark Lam from comment #5) > Please share your details about what actually broke. In file included from /home/mcatanzaro/Projects/WebKit/WebKitBuild/JSCOnly/JavaScriptCore/PrivateHeaders/JavaScriptCore/VM.h:41, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/JSCOnly/JavaScriptCore/PrivateHeaders/JavaScriptCore/ExceptionScope.h:28, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/JSCOnly/JavaScriptCore/PrivateHeaders/JavaScriptCore/CatchScope.h:28, from /home/mcatanzaro/Projects/WebKit/WebKitBuild/JSCOnly/JavaScriptCore/PrivateHeaders/JavaScriptCore/JSCJSValueInlines.h:28, from /home/mcatanzaro/Projects/WebKit/Tools/TestWebKitAPI/Tests/JavaScriptCore/PropertySlot.cpp:28: /home/mcatanzaro/Projects/WebKit/WebKitBuild/JSCOnly/JavaScriptCore/PrivateHeaders/JavaScriptCore/Interpreter.h:39:10: fatal error: CLoopStack.h: No such file or directory 39 | #include "CLoopStack.h" | ^~~~~~~~~~~~~~ compilation terminated. 1882705 8 mcatanzaro 2022-07-12 15:52:54 -0700 (In reply to Mark Lam from comment #5) > How did this break the CLoop? I deliberately tested for it. The jsc-i386 > bot builds CLoop AFAIK. When I checked (before landing), all was well. Maybe it doesn't build TestWebKitAPI? 1882706 9 mark.lam 2022-07-12 15:56:00 -0700 (In reply to Michael Catanzaro from comment #8) > (In reply to Mark Lam from comment #5) > > How did this break the CLoop? I deliberately tested for it. The jsc-i386 > > bot builds CLoop AFAIK. When I checked (before landing), all was well. > > Maybe it doesn't build TestWebKitAPI? Yeah, it's a jsc build bot. Locally, I also only tested building jsc. Is this build failure manifesting when building TestWebKitAPI? 1882707 10 mcatanzaro 2022-07-12 15:56:45 -0700 Yes, the problem is the header is not available to TestWebKitAPI. My patch works... I'll submit a PR. 1882708 11 mcatanzaro 2022-07-12 16:00:31 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/2349 1882755 12 ews-feeder 2022-07-12 16:58:00 -0700 Committed 252400@main (40e49bb53218): <https://commits.webkit.org/252400@main> Reviewed commits have been landed. Closing PR #2349 and removing active labels.