24256 2009-02-27 16:26:55 -0800 Add a preference flag to force software animation 2009-03-03 10:55:50 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin simon.fraser oldest_to_newest 111578 0 cmarrin 2009-02-27 16:26:55 -0800 A flag to always force software animation, even when accelerated compositing is enabled would be useful in testing. 111580 1 28107 cmarrin 2009-02-27 16:41:46 -0800 Created attachment 28107 Patch 111584 2 28107 simon.fraser 2009-02-27 16:57:03 -0800 Comment on attachment 28107 Patch > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 41308) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,19 @@ > +2009-02-27 Chris Marrin <cmarrin@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + https://bugs.webkit.org/show_bug.cgi?id=24256 > + > + Added a WebCoreForceSoftwareAnimation flag. > + > + WARNING: NO TEST CASES ADDED OR CHANGED Remove this before committing. > Index: WebCore/platform/graphics/mac/GraphicsLayerCA.mm > =================================================================== > +static bool forceSoftwareAnimation() > +{ > + static int forceSoftwareAnimation = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebCoreForceSoftwareAnimation"]; > + return forceSoftwareAnimation; > +} Feel free to change this and the other static ints to static bools. I have no idea why they are ints. r=me with those changes. 112044 3 cmarrin 2009-03-03 10:55:50 -0800 Sending WebCore/ChangeLog Sending WebCore/platform/graphics/mac/GraphicsLayerCA.mm Transmitting file data .. Committed revision 41397. 28107 2009-02-27 16:41:46 -0800 2009-02-27 16:57:03 -0800 Patch 24256.patch text/plain 2685 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTMwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDItMjcgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDI1NgorCisgICAgICAgIEFk ZGVkIGEgV2ViQ29yZUZvcmNlU29mdHdhcmVBbmltYXRpb24gZmxhZy4KKworICAgICAgICBXQVJO SU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL21hYy9HcmFwaGljc0xheWVyQ0EubW06CisgICAgICAgIChXZWJDb3JlOjpmb3Jj ZVNvZnR3YXJlQW5pbWF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDQTo6 c2V0T3BhY2l0eSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ0E6OmFuaW1hdGVU cmFuc2Zvcm0pOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckNBOjphbmltYXRlRmxv YXQpOgorCiAyMDA5LTAyLTI3ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NMYXllckNBLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzTGF5ZXJDQS5tbQkocmV2aXNpb24g NDEzMDgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFwaGljc0xheWVyQ0Eu bW0JKHdvcmtpbmcgY29weSkKQEAgLTI2NSw2ICsyNjUsMTIgQEAgc3RhdGljIGJvb2wgY2FWYWx1 ZUZ1bmN0aW9uU3VwcG9ydGVkKCkKICAgICByZXR1cm4gc0hhdmVWYWx1ZUZ1bmN0aW9uOwogfQog CitzdGF0aWMgYm9vbCBmb3JjZVNvZnR3YXJlQW5pbWF0aW9uKCkKK3sKKyAgICBzdGF0aWMgaW50 IGZvcmNlU29mdHdhcmVBbmltYXRpb24gPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRl ZmF1bHRzXSBib29sRm9yS2V5OkAiV2ViQ29yZUZvcmNlU29mdHdhcmVBbmltYXRpb24iXTsKKyAg ICByZXR1cm4gZm9yY2VTb2Z0d2FyZUFuaW1hdGlvbjsKK30KKwogYm9vbCBHcmFwaGljc0xheWVy OjpncmFwaGljc0NvbnRleHRzRmxpcHBlZCgpCiB7CiAgICAgcmV0dXJuIHRydWU7CkBAIC04MDks NiArODE1LDkgQEAgdm9pZCBHcmFwaGljc0xheWVyQ0E6OnNldEJhY2tmYWNlVmlzaWJpbAogCiBi b29sIEdyYXBoaWNzTGF5ZXJDQTo6c2V0T3BhY2l0eShmbG9hdCBvcGFjaXR5LCBjb25zdCBBbmlt YXRpb24qIHRyYW5zaXRpb24sIGRvdWJsZSBiZWdpblRpbWUpCiB7CisgICAgaWYgKGZvcmNlU29m dHdhcmVBbmltYXRpb24oKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAKICAgICBm bG9hdCBjbGFtcGVkT3BhY2l0eSA9IG1heCgwLjBmLCBtaW4ob3BhY2l0eSwgMS4wZikpOwogICAg IAogICAgIGJvb2wgb3BhY2l0aWVzRGlmZmVyID0gKG1fb3BhY2l0eSAhPSBjbGFtcGVkT3BhY2l0 eSk7CkBAIC04OTksNyArOTA4LDcgQEAgdm9pZCBHcmFwaGljc0xheWVyQ0E6OnNldE5lZWRzRGlz cGxheUluUgogCiBib29sIEdyYXBoaWNzTGF5ZXJDQTo6YW5pbWF0ZVRyYW5zZm9ybShjb25zdCBU cmFuc2Zvcm1WYWx1ZUxpc3QmIHZhbHVlTGlzdCwgY29uc3QgSW50U2l6ZSYgc2l6ZSwgY29uc3Qg QW5pbWF0aW9uKiBhbmltLCBkb3VibGUgYmVnaW5UaW1lLCBib29sIGlzVHJhbnNpdGlvbikKIHsK LSAgICBpZiAoIWFuaW0gfHwgYW5pbS0+aXNFbXB0eU9yWmVyb0R1cmF0aW9uKCkgfHwgdmFsdWVM aXN0LnNpemUoKSA8IDIpCisgICAgaWYgKGZvcmNlU29mdHdhcmVBbmltYXRpb24oKSB8fCAhYW5p bSB8fCBhbmltLT5pc0VtcHR5T3JaZXJvRHVyYXRpb24oKSB8fCB2YWx1ZUxpc3Quc2l6ZSgpIDwg MikKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAKICAgICBUcmFuc2Zvcm1WYWx1ZUxp c3Q6OkZ1bmN0aW9uTGlzdCBmdW5jdGlvbkxpc3Q7CkBAIC0xMDE2LDcgKzEwMjUsNyBAQCBib29s IEdyYXBoaWNzTGF5ZXJDQTo6YW5pbWF0ZVRyYW5zZm9ybShjCiAKIGJvb2wgR3JhcGhpY3NMYXll ckNBOjphbmltYXRlRmxvYXQoQW5pbWF0ZWRQcm9wZXJ0eUlEIHByb3BlcnR5LCBjb25zdCBGbG9h dFZhbHVlTGlzdCYgdmFsdWVMaXN0LCBjb25zdCBBbmltYXRpb24qIGFuaW1hdGlvbiwgZG91Ymxl IGJlZ2luVGltZSkKIHsKLSAgICBpZiAodmFsdWVMaXN0LnNpemUoKSA8IDIpCisgICAgaWYgKGZv cmNlU29mdHdhcmVBbmltYXRpb24oKSB8fCB2YWx1ZUxpc3Quc2l6ZSgpIDwgMikKICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgICAgICAKICAgICAvLyBpZiB0aGVyZSBpcyBhbHJlYWR5IGlzIGFu IGFuaW1hdGlvbiBmb3IgdGhpcyBwcm9wZXJ0eSBhbmQgaXQgaGFzbid0IGNoYW5nZWQsIGlnbm9y ZSBpdC4K