24254 2009-02-27 16:05:26 -0800 [GTK] spacebar doesn't scroll down 2009-03-12 06:22:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 0 pochu27 webkit-unassigned gustavo oldest_to_newest 111570 0 pochu27 2009-02-27 16:05:26 -0800 Pressing space on webkit should scroll down the webview, but for the GTK port it doesn't. 113313 1 28518 gustavo 2009-03-11 20:34:37 -0700 Created attachment 28518 proposed fix It seems to me like we should look forward to do some rework on our scrolling code as a whole. I know Xan has been doing an awesome work on this front, but maybe we need to look at the big picture a bit more. 113364 2 28524 gustavo 2009-03-12 05:17:33 -0700 Created attachment 28524 proposed fix Addressing comments by alp and xan on IRC. 113370 3 28526 gustavo 2009-03-12 06:05:56 -0700 Created attachment 28526 makes space scroll down, and shift+space scroll up Addressed more comments by Xan on IRC. 113372 4 28526 alp 2009-03-12 06:12:29 -0700 Comment on attachment 28526 makes space scroll down, and shift+space scroll up r=me but please fix the ChangeLog entry to not mention backspace 113374 5 gustavo 2009-03-12 06:22:57 -0700 Landed as r41622. 28518 2009-03-11 20:34:37 -0700 2009-03-12 05:17:33 -0700 proposed fix spacebar.patch text/plain 2013 gustavo RnJvbSA3OTljZDhjZmYwNDNjZjY2NjQ3NGMxZTc2MzhhNmVhOTFkMGUxOWY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDEyIE1hciAyMDA5IDAwOjI3OjU2IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g MjAwOS0wMy0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KCiAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDI1NAogICAgICAgIFtHVEtdIHNwYWNlYmFyIGRvZXNu J3Qgc2Nyb2xsIGRvd24KCiAgICAgICAgTWFrZSBzcGFjZWJhciBhbmQgYmFja3NwYWNlIGtleXMg c2Nyb2xsIGxpa2UgcGFnZSB1cCBhbmQgZG93bgogICAgICAgIHJlc3BlY3RpdmVseSB3b3VsZC4K CiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6Ci0tLQogV2ViS2l0L2d0ay9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAgfCAgICA2ICsrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxOCBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hh bmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggM2JhZGE0Ny4uZTBmYWM5MSAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAwOS0wMy0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25z QGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQyNTQKKyAgICAg ICAgW0dUS10gc3BhY2ViYXIgZG9lc24ndCBzY3JvbGwgZG93bgorCisgICAgICAgIE1ha2Ugc3Bh Y2ViYXIgYW5kIGJhY2tzcGFjZSBrZXlzIHNjcm9sbCBsaWtlIHBhZ2UgdXAgYW5kIGRvd24KKyAg ICAgICAgcmVzcGVjdGl2ZWx5IHdvdWxkLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwOgorCiAyMDA5LTAzLTEwICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwCmluZGV4IGQ4NzYzNWYuLjQ1NTEzZTUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwCkBAIC00NTAsNiArNDUwLDEyIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2Vi X3ZpZXdfa2V5X3ByZXNzX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEtleSoKICAg ICBjYXNlIEdES19MZWZ0OgogICAgICAgICB2aWV3LT5zY3JvbGxCeShJbnRTaXplKC1jU2Nyb2xs YmFyUGl4ZWxzUGVyTGluZVN0ZXAsIDApKTsKICAgICAgICAgcmV0dXJuIFRSVUU7CisgICAgY2Fz ZSBHREtfc3BhY2U6CisgICAgICAgIHZpZXctPnNjcm9sbEJ5KEludFNpemUoMCwgdmlldy0+dmlz aWJsZUhlaWdodCgpKSk7CisgICAgICAgIHJldHVybiBUUlVFOworICAgIGNhc2UgR0RLX0JhY2tT cGFjZToKKyAgICAgICAgdmlldy0+c2Nyb2xsQnkoSW50U2l6ZSgwLCAtdmlldy0+dmlzaWJsZUhl aWdodCgpKSk7CisgICAgICAgIHJldHVybiBUUlVFOwogICAgIGNhc2UgR0RLX0hvbWU6CiAgICAg ICAgIGZyYW1lLT5zZWxlY3Rpb24oKS0+bW9kaWZ5KGFsdGVyYXRpb24sIFNlbGVjdGlvbkNvbnRy b2xsZXI6OkJBQ0tXQVJELCBEb2N1bWVudEJvdW5kYXJ5LCB0cnVlKTsKICAgICAgICAgcmV0dXJu IFRSVUU7Ci0tIAoxLjYuMgoK 28524 2009-03-12 05:17:33 -0700 2009-03-12 06:05:56 -0700 proposed fix spacebar.patch text/plain 2032 gustavo RnJvbSBhZTc4ZmQxMWU1M2E5MzEzOTQyODEyN2E1YjcwNDg1MWFmYWFhOWUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDEyIE1hciAyMDA5IDA5OjE2OjA0IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g MjAwOS0wMy0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KCiAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDI1NAogICAgICAgIFtHVEtdIHNwYWNlYmFyIGRvZXNu J3Qgc2Nyb2xsIGRvd24KCiAgICAgICAgTWFrZSBzcGFjZWJhciBhbmQgYmFja3NwYWNlIGtleXMg c2Nyb2xsIGxpa2UgcGFnZSB1cCBhbmQgZG93bgogICAgICAgIHJlc3BlY3RpdmVseSB3b3VsZC4K CiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6Ci0tLQogV2ViS2l0L2d0ay9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAgfCAgICA2ICsrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxOCBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hh bmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggM2JhZGE0Ny4uZTBmYWM5MSAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAwOS0wMy0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25z QGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQyNTQKKyAgICAg ICAgW0dUS10gc3BhY2ViYXIgZG9lc24ndCBzY3JvbGwgZG93bgorCisgICAgICAgIE1ha2Ugc3Bh Y2ViYXIgYW5kIGJhY2tzcGFjZSBrZXlzIHNjcm9sbCBsaWtlIHBhZ2UgdXAgYW5kIGRvd24KKyAg ICAgICAgcmVzcGVjdGl2ZWx5IHdvdWxkLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwOgorCiAyMDA5LTAzLTEwICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwCmluZGV4IGQ4NzYzNWYuLmQxNWEyODggMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwCkBAIC00NTAsNiArNDUwLDEyIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2Vi X3ZpZXdfa2V5X3ByZXNzX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEtleSoKICAg ICBjYXNlIEdES19MZWZ0OgogICAgICAgICB2aWV3LT5zY3JvbGxCeShJbnRTaXplKC1jU2Nyb2xs YmFyUGl4ZWxzUGVyTGluZVN0ZXAsIDApKTsKICAgICAgICAgcmV0dXJuIFRSVUU7CisgICAgY2Fz ZSBHREtfc3BhY2U6CisgICAgICAgIGlmIChldmVudC0+c3RhdGUgJiBHREtfU0hJRlRfTUFTSykK KyAgICAgICAgICAgIHZpZXctPnNjcm9sbEJ5KEludFNpemUoMCwgLXZpZXctPnZpc2libGVIZWln aHQoKSkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB2aWV3LT5zY3JvbGxCeShJbnRTaXpl KDAsIHZpZXctPnZpc2libGVIZWlnaHQoKSkpOworICAgICAgICByZXR1cm4gVFJVRTsKICAgICBj YXNlIEdES19Ib21lOgogICAgICAgICBmcmFtZS0+c2VsZWN0aW9uKCktPm1vZGlmeShhbHRlcmF0 aW9uLCBTZWxlY3Rpb25Db250cm9sbGVyOjpCQUNLV0FSRCwgRG9jdW1lbnRCb3VuZGFyeSwgdHJ1 ZSk7CiAgICAgICAgIHJldHVybiBUUlVFOwotLSAKMS42LjIKCg== 28526 2009-03-12 06:05:56 -0700 2009-03-12 06:12:29 -0700 makes space scroll down, and shift+space scroll up spacebar.patch text/plain 2052 gustavo RnJvbSBjMDZjNTRhNjliZjk0OGJkOTA4NmYxNzMwZjIxNWIxYWQ0ZWRiNjdjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBUaHUsIDEyIE1hciAyMDA5IDA5OjE2OjA0IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g MjAwOS0wMy0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KCiAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDI1NAogICAgICAgIFtHVEtdIHNwYWNlYmFyIGRvZXNu J3Qgc2Nyb2xsIGRvd24KCiAgICAgICAgTWFrZSBzcGFjZWJhciBhbmQgYmFja3NwYWNlIGtleXMg c2Nyb2xsIGxpa2UgcGFnZSB1cCBhbmQgZG93bgogICAgICAgIHJlc3BlY3RpdmVseSB3b3VsZC4K CiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6Ci0tLQogV2ViS2l0L2d0ay9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAgfCAgICA2ICsrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxOCBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hh bmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggM2JhZGE0Ny4uZTBmYWM5MSAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAwOS0wMy0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25z QGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQyNTQKKyAgICAg ICAgW0dUS10gc3BhY2ViYXIgZG9lc24ndCBzY3JvbGwgZG93bgorCisgICAgICAgIE1ha2Ugc3Bh Y2ViYXIgYW5kIGJhY2tzcGFjZSBrZXlzIHNjcm9sbCBsaWtlIHBhZ2UgdXAgYW5kIGRvd24KKyAg ICAgICAgcmVzcGVjdGl2ZWx5IHdvdWxkLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwOgorCiAyMDA5LTAzLTEwICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwCmluZGV4IGQ4NzYzNWYuLjFhYzNjYjYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwCkBAIC00NTAsNiArNDUwLDEyIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2Vi X3ZpZXdfa2V5X3ByZXNzX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEtleSoKICAg ICBjYXNlIEdES19MZWZ0OgogICAgICAgICB2aWV3LT5zY3JvbGxCeShJbnRTaXplKC1jU2Nyb2xs YmFyUGl4ZWxzUGVyTGluZVN0ZXAsIDApKTsKICAgICAgICAgcmV0dXJuIFRSVUU7CisgICAgY2Fz ZSBHREtfc3BhY2U6CisgICAgICAgIGlmICgoZXZlbnQtPnN0YXRlICYgR0RLX1NISUZUX01BU0sp ID09IEdES19TSElGVF9NQVNLKQorICAgICAgICAgICAgdmlldy0+c2Nyb2xsQnkoSW50U2l6ZSgw LCAtdmlldy0+dmlzaWJsZUhlaWdodCgpKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHZp ZXctPnNjcm9sbEJ5KEludFNpemUoMCwgdmlldy0+dmlzaWJsZUhlaWdodCgpKSk7CisgICAgICAg IHJldHVybiBUUlVFOwogICAgIGNhc2UgR0RLX0hvbWU6CiAgICAgICAgIGZyYW1lLT5zZWxlY3Rp b24oKS0+bW9kaWZ5KGFsdGVyYXRpb24sIFNlbGVjdGlvbkNvbnRyb2xsZXI6OkJBQ0tXQVJELCBE b2N1bWVudEJvdW5kYXJ5LCB0cnVlKTsKICAgICAgICAgcmV0dXJuIFRSVUU7Ci0tIAoxLjYuMgoK