24252 2009-02-27 15:19:50 -0800 Assert when hit testing a 3d transform that is null 2009-03-02 11:49:59 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dino dino cmarrin f.tomalty simon.fraser oldest_to_newest 111565 0 dino 2009-02-27 15:19:50 -0800 WebCore::TransformationMatrix::isInvertible() bombs out if you hit test a transform that doesn't exist. 111582 1 28108 dino 2009-02-27 16:49:19 -0800 Created attachment 28108 fix for crash 111583 2 28108 simon.fraser 2009-02-27 16:54:50 -0800 Comment on attachment 28108 fix for crash > diff --git a/LayoutTests/transforms/no_transform_hit_testing-expected.txt b/LayoutTests/transforms/no_transform_hit_testing-expected.txt > new file mode 100644 > index 0000000..57ff5af > --- /dev/null > +++ b/LayoutTests/transforms/no_transform_hit_testing-expected.txt > @@ -0,0 +1,5 @@ > +Testing hittest on a layer with null transform > + > +https://bugs.webkit.org/show_bug.cgi?id=24252 > + > +transformed elementdid not crash Make that "Did not crash, to test PASSED" > diff --git a/LayoutTests/transforms/no_transform_hit_testing.html b/LayoutTests/transforms/no_transform_hit_testing.html > + <script type="text/javascript" charset="utf-8"> > + if (window.layoutTestController) { > + layoutTestController.dumpAsText(); > + layoutTestController.waitUntilDone(); I don't think this needs to wait if you run the test from onload. Also, I don't think it needs to be a text test. > + function runTest() > + { > + if (window.layoutTestController) { > + eventSender.mouseMoveTo(100, 50); > + eventSender.mouseDown(); > + eventSender.mouseUp(); > + eventSender.mouseDown(); > + eventSender.mouseUp(); Just call document.elementFromPoint(...) so it works in Safari too. > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 9c59011..1a22d7a 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,16 @@ > +2009-02-27 Dean Jackson <dino@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Fix asserting when hit testing an element that > + has no transform. > + https://bugs.webkit.org/show_bug.cgi?id=24252 I think this needs to explain the crash. Something like: "renderer()->hasTransform() returns true for elements with perspective, but no transform, so test for transform when hit testing". r=me wit those changes. 111585 3 dino 2009-02-27 17:08:17 -0800 New test used elementFromPoint and will work outside of test system Committed r41309 M WebCore/ChangeLog M WebCore/rendering/RenderLayer.cpp M LayoutTests/ChangeLog A LayoutTests/transforms/no_transform_hit_testing.html next commit adds the file I forgot :( 111587 4 dino 2009-02-27 17:13:38 -0800 Committed r41311 A LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.checksum A LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png M LayoutTests/ChangeLog 111776 5 simon.fraser 2009-03-01 20:03:56 -0800 *** Bug 24277 has been marked as a duplicate of this bug. *** 28108 2009-02-27 16:49:19 -0800 2009-02-27 16:54:50 -0800 fix for crash crash.patch text/plain 4015 dino ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3NjgwYzg5Li43NmIyYjhkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDIt MjcgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0IGZvciBjcmFzaCAtIHRyYW5zZm9y bSBpcyBudWxsIGluIGhpdCB0ZXN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNDI1MgorCisgICAgICAgICogdHJhbnNmb3Jtcy9ub190cmFuc2Zv cm1faGl0X3Rlc3RpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiB0cmFuc2Zvcm1z L25vX3RyYW5zZm9ybV9oaXRfdGVzdGluZy5odG1sOiBBZGRlZC4KKwogMjAwOS0wMi0yNyAgRGF2 aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxl eGV5IFByb3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3RyYW5zZm9ybXMvbm9f dHJhbnNmb3JtX2hpdF90ZXN0aW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3RyYW5zZm9y bXMvbm9fdHJhbnNmb3JtX2hpdF90ZXN0aW5nLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi41N2ZmNWFmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvdHJhbnNmb3Jtcy9ub190cmFuc2Zvcm1faGl0X3Rlc3RpbmctZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsNSBAQAorVGVzdGluZyBoaXR0ZXN0IG9uIGEgbGF5ZXIgd2l0aCBudWxsIHRyYW5zZm9y bQorCitodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQyNTIKKwordHJh bnNmb3JtZWQgZWxlbWVudGRpZCBub3QgY3Jhc2gKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Ry YW5zZm9ybXMvbm9fdHJhbnNmb3JtX2hpdF90ZXN0aW5nLmh0bWwgYi9MYXlvdXRUZXN0cy90cmFu c2Zvcm1zL25vX3RyYW5zZm9ybV9oaXRfdGVzdGluZy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLmY4ZTliYzkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy90 cmFuc2Zvcm1zL25vX3RyYW5zZm9ybV9oaXRfdGVzdGluZy5odG1sCkBAIC0wLDAgKzEsNTggQEAK KzxodG1sPgorPGhlYWQ+CisgIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtdHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KKyAgPHRpdGxlPlRlc3RpbmcgaGl0dGVzdCBv biBhIGxheWVyIHdpdGggbnVsbCB0cmFuc2Zvcm08L3RpdGxlPgorICA8c3R5bGUgdHlwZT0idGV4 dC9jc3MiIG1lZGlhPSJzY3JlZW4iPgorICAgICN4IHsKKyAgICAgIHBvc2l0aW9uOiBhYnNvbHV0 ZTsKKyAgICAgIHRvcDogODBweDsKKyAgICAgIGxlZnQ6IDIwcHg7CisgICAgICB3aWR0aDogNDAw cHg7CisgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgYmFja2dyb3VuZC1jb2xvcjogI2RkZjsK KyAgICAgIC13ZWJraXQtcGVyc3BlY3RpdmU6IDgwMDsKKyAgICB9CisKKyAgICAjeDpob3ZlciB7 CisgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiAjZGZmOworICAgIH0KKyAgICAKKyAgICAjcmVzdWx0 cyB7CisgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgICB0b3A6IDIwMHB4OworICAgIH0K KyAgPC9zdHlsZT4KKyAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0 Zi04Ij4KKyAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci53YWl0VW50aWxEb25lKCk7CisgICAgIH0KKworICAgICBmdW5jdGlvbiBydW5UZXN0KCkK KyAgICAgeworICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAg ICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDEwMCwgNTApOworICAgICAgICAgZXZlbnRTZW5k ZXIubW91c2VEb3duKCk7CisgICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgICAg ICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAo KTsKKyAgICAgICB9CisKKyAgICAgICB2YXIgcmVzdWx0cyA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJyZXN1bHRzIik7CisgICAgICAgcmVzdWx0cy5pbm5lclRleHQgPSAiZGlkIG5vdCBjcmFz aCI7CisKKyAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICB9CisKKyAgPC9zY3JpcHQ+ Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+CisgIDxoMT5UZXN0aW5nIGhpdHRl c3Qgb24gYSBsYXllciB3aXRoIG51bGwgdHJhbnNmb3JtPC9oMT4KKyAgPHA+aHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MjUyPC9wPgorCisgIDxwIGlkPSJ4Ij50cmFu c2Zvcm1lZCBlbGVtZW50PC9wPgorICAKKyAgPHAgaWQ9InJlc3VsdHMiPmZhaWw8L3A+Cis8L2Jv ZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDljNTkwMTEuLjFhMjJkN2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDItMjcg IERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhc3NlcnRpbmcgd2hlbiBoaXQgdGVzdGluZyBh biBlbGVtZW50IHRoYXQKKyAgICAgICAgaGFzIG5vIHRyYW5zZm9ybS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MjUyCisKKyAgICAgICAgVGVzdDog dHJhbnNmb3Jtcy9ub190cmFuc2Zvcm1faGl0X3Rlc3RpbmcuaHRtbAorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpo aXRUZXN0TGF5ZXIpOgorCiAyMDA5LTAyLTI3ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgSHlhdHQuCmRpZmYgLS1naXQg YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5jcHAKaW5kZXggNTMwNDk4Ny4uODU1NTc2YiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcApAQCAtMjA3OCw3ICsyMDc4LDcgQEAgUmVuZGVyTGF5ZXIqIFJlbmRlckxheWVy OjpoaXRUZXN0TGF5ZXIoUmVuZGVyTGF5ZXIqIHJvb3RMYXllciwgY29uc3QgSGl0VGVzdFJlcXUK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IEludFJlY3QmIGhp dFRlc3RSZWN0LCBjb25zdCBJbnRQb2ludCYgaGl0VGVzdFBvaW50LCBib29sIGFwcGxpZWRUcmFu c2Zvcm0pCiB7CiAgICAgLy8gQXBwbHkgYSB0cmFuc2Zvcm0gaWYgd2UgaGF2ZSBvbmUuCi0gICAg aWYgKHJlbmRlcmVyKCktPmhhc1RyYW5zZm9ybSgpICYmICFhcHBsaWVkVHJhbnNmb3JtKSB7Cisg ICAgaWYgKHRyYW5zZm9ybSgpICYmICFhcHBsaWVkVHJhbnNmb3JtKSB7CiAgICAgICAgIC8vIElm IHRoZSB0cmFuc2Zvcm0gY2FuJ3QgYmUgaW52ZXJ0ZWQsIHRoZW4gZG9uJ3QgaGl0IHRlc3QgdGhp cyBsYXllciBhdCBhbGwuCiAgICAgICAgIGlmICghbV90cmFuc2Zvcm0tPmlzSW52ZXJ0aWJsZSgp KQogICAgICAgICAgICAgcmV0dXJuIDA7Cg==