24248 2009-02-27 13:42:56 -0800 REGRESSION: Pixel test regressions from "fixed overflow not painted in normal order" (r41203) 2009-03-09 11:46:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED Regression P1 Normal --- 1 tony hyatt oldest_to_newest 111540 0 tony 2009-02-27 13:42:56 -0800 This has caused the following pixel test results to regress: LayoutTests/fast/overflow/004.html LayoutTests/fast/overflow/hidden-scrollbar-resize.html LayoutTests/fast/overflow/hit-test-overflow-controls.html 004.html seems pretty minor (the border moved) hidden-scrollbar-resize.html is clearly wrong. The scrollbars shouldn't be visible but they are. hit-test-overflow-controls.html seems to show the resizer corner border not being clipped properly. I can see some tearing if I resize the text area smaller. The original bug was https://bugs.webkit.org/show_bug.cgi?id=23740 112425 1 28316 hyatt 2009-03-05 12:28:21 -0800 Created attachment 28316 Patch 112426 2 28316 eric 2009-03-05 12:31:53 -0800 Comment on attachment 28316 Patch LGTM. 112428 3 28317 hyatt 2009-03-05 12:34:00 -0800 Created attachment 28317 Patch 112430 4 28317 eric 2009-03-05 12:35:22 -0800 Comment on attachment 28317 Patch Looks even better. :) 112433 5 hyatt 2009-03-05 12:37:25 -0800 Fixed in r41458. 112873 6 tony 2009-03-09 11:46:23 -0700 LayoutTests/fast/overflow/004.html seems to still be different from before this change (the border in the middle moved a few pixels). 28316 2009-03-05 12:28:21 -0800 2009-03-05 12:34:00 -0800 Patch patch.txt text/plain 1471 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQxNDU3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDMt MDUgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDI0OAorCisgICAgICAgIE1ha2Ugc3VyZSBw YWludGluZyBvZiBvdmVyZmxvdyBjb250cm9scyBjaGVja3MgdGhhdCB2aXNpYmlsaXR5OnZpc2li bGUgaXMgc2V0IG9uIHRoZSBibG9jayBiZWZvcmUKKyAgICAgICAgcGFpbnRpbmcuICBQaXhlbCB0 ZXN0cyBjYXVnaHQgdGhpcyByZWdyZXNzaW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpwYWludCk6CisKIDIwMDktMDMtMDUgIFlvbmcgTGkg IDx5b25nLmxpQHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBG cmFzZXIuCkluZGV4OiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJl bmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDQxNDIyKQorKysgcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU3MSw3ICsxNTcxLDcgQEAgdm9pZCBS ZW5kZXJCbG9jazo6cGFpbnQoUGFpbnRJbmZvJiBwYWludAogICAgIC8vIE91ciBzY3JvbGxiYXIg d2lkZ2V0cyBwYWludCBleGFjdGx5IHdoZW4gd2UgdGVsbCB0aGVtIHRvLCBzbyB0aGF0IHRoZXkg d29yayBwcm9wZXJseSB3aXRoCiAgICAgLy8gei1pbmRleC4gIFdlIHBhaW50IGFmdGVyIHdlIHBh aW50ZWQgdGhlIGJhY2tncm91bmQvYm9yZGVyLCBzbyB0aGF0IHRoZSBzY3JvbGxiYXJzIHdpbGwK ICAgICAvLyBzaXQgYWJvdmUgdGhlIGJhY2tncm91bmQvYm9yZGVyLgotICAgIGlmIChoYXNPdmVy Zmxvd0NsaXAoKSAmJiAocGhhc2UgPT0gUGFpbnRQaGFzZUJsb2NrQmFja2dyb3VuZCB8fCBwaGFz ZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmQpKQorICAgIGlmIChoYXNPdmVyZmxv d0NsaXAoKSAmJiBzdHlsZSgpLT52aXNpYmlsaXR5KCkgPT0gVklTSUJMRSAmJiAocGhhc2UgPT0g UGFpbnRQaGFzZUJsb2NrQmFja2dyb3VuZCB8fCBwaGFzZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9j a0JhY2tncm91bmQpKQogICAgICAgICBsYXllcigpLT5wYWludE92ZXJmbG93Q29udHJvbHMocGFp bnRJbmZvLmNvbnRleHQsIHR4LCB0eSwgcGFpbnRJbmZvLnJlY3QpOwogfQogCg== 28317 2009-03-05 12:34:00 -0800 2009-03-05 12:35:22 -0800 Patch patch.txt text/plain 2359 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQxNDU3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMDMt MDUgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNDI0OAorCisgICAgICAgIE1ha2Ugc3VyZSBwYWludGluZyBvZiBvdmVyZmxv dyBjb250cm9scyBjaGVja3MgdGhhdCB2aXNpYmlsaXR5OnZpc2libGUgaXMgc2V0IG9uIHRoZSBi bG9jayBiZWZvcmUKKyAgICAgICAgcGFpbnRpbmcuICBQaXhlbCB0ZXN0cyBjYXVnaHQgdGhpcyBy ZWdyZXNzaW9uLgorCisgICAgICAgIE1ha2Ugc3VyZSByZXNpemVyIHBhaW50aW5nIHB1c2hlcyBh IGNsaXAgb2YgdGhlIGNvcm5lciByZWN0LiAgSXQgd2FzIHJlbHlpbmcgb24gdGhlIGNsaXAgbGF5 ZXJzIGhhcHBlbmVkCisgICAgICAgIHRvIGRvIHRvIHRoZWlyIGJvdW5kcyAod2hpY2ggaGFkIG5v dGhpbmcgdG8gZG8gd2l0aCBvdmVyZmxvdykuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy QmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OnBhaW50KToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy TGF5ZXI6OnBhaW50UmVzaXplcik6CisKIDIwMDktMDMtMDUgIFlvbmcgTGkgIDx5b25nLmxpQHRv cmNobW9iaWxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4 OiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9SZW5k ZXJCbG9jay5jcHAJKHJldmlzaW9uIDQxNDIyKQorKysgcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTU3MSw3ICsxNTcxLDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6 cGFpbnQoUGFpbnRJbmZvJiBwYWludAogICAgIC8vIE91ciBzY3JvbGxiYXIgd2lkZ2V0cyBwYWlu dCBleGFjdGx5IHdoZW4gd2UgdGVsbCB0aGVtIHRvLCBzbyB0aGF0IHRoZXkgd29yayBwcm9wZXJs eSB3aXRoCiAgICAgLy8gei1pbmRleC4gIFdlIHBhaW50IGFmdGVyIHdlIHBhaW50ZWQgdGhlIGJh Y2tncm91bmQvYm9yZGVyLCBzbyB0aGF0IHRoZSBzY3JvbGxiYXJzIHdpbGwKICAgICAvLyBzaXQg YWJvdmUgdGhlIGJhY2tncm91bmQvYm9yZGVyLgotICAgIGlmIChoYXNPdmVyZmxvd0NsaXAoKSAm JiAocGhhc2UgPT0gUGFpbnRQaGFzZUJsb2NrQmFja2dyb3VuZCB8fCBwaGFzZSA9PSBQYWludFBo YXNlQ2hpbGRCbG9ja0JhY2tncm91bmQpKQorICAgIGlmIChoYXNPdmVyZmxvd0NsaXAoKSAmJiBz dHlsZSgpLT52aXNpYmlsaXR5KCkgPT0gVklTSUJMRSAmJiAocGhhc2UgPT0gUGFpbnRQaGFzZUJs b2NrQmFja2dyb3VuZCB8fCBwaGFzZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmQp KQogICAgICAgICBsYXllcigpLT5wYWludE92ZXJmbG93Q29udHJvbHMocGFpbnRJbmZvLmNvbnRl eHQsIHR4LCB0eSwgcGFpbnRJbmZvLnJlY3QpOwogfQogCkluZGV4OiByZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHJldmlz aW9uIDQxNDA4KQorKysgcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTc3MSw2ICsxNzcxLDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRSZXNpemVyKEdyYXBo aWNzQwogICAgIC8vIENsaXBwaW5nIHdpbGwgZXhjbHVkZSB0aGUgcmlnaHQgYW5kIGJvdHRvbSBl ZGdlcyBvZiB0aGlzIGZyYW1lLgogICAgIGlmIChtX2hCYXIgfHwgbV92QmFyKSB7CiAgICAgICAg IGNvbnRleHQtPnNhdmUoKTsKKyAgICAgICAgY29udGV4dC0+Y2xpcChhYnNSZWN0KTsKICAgICAg ICAgSW50UmVjdCBsYXJnZXJDb3JuZXIgPSBhYnNSZWN0OwogICAgICAgICBsYXJnZXJDb3JuZXIu c2V0U2l6ZShJbnRTaXplKGxhcmdlckNvcm5lci53aWR0aCgpICsgMSwgbGFyZ2VyQ29ybmVyLmhl aWdodCgpICsgMSkpOwogICAgICAgICBjb250ZXh0LT5zZXRTdHJva2VDb2xvcihDb2xvcihtYWtl UkdCKDIxNywgMjE3LCAyMTcpKSk7Cg==