24242 2009-02-27 11:44:39 -0800 WebHTMLView's setCusor() uses the wrong point for elementAtPoint 2009-02-27 12:03:32 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 111504 0 simon.fraser 2009-02-27 11:44:39 -0800 setCusor() has this code: NSPoint localPoint = [htmlView convertPoint:point fromView:nil]; NSDictionary *dict = [htmlView elementAtPoint:point allowShadowContent:NO]; localPoint is never used. 111509 1 28094 simon.fraser 2009-02-27 11:56:06 -0800 Created attachment 28094 Patch, changelog I don't know how to test this. 111510 2 28094 andersca 2009-02-27 11:57:00 -0800 Comment on attachment 28094 Patch, changelog r=me 111511 3 simon.fraser 2009-02-27 12:03:32 -0800 http://trac.webkit.org/changeset/41293 28094 2009-02-27 11:56:06 -0800 2009-02-27 11:57:00 -0800 Patch, changelog 24242_patch.txt text/plain 2215 simon.fraser ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggNWNhNGU0Mi4uNTUyN2Y1NiAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMi0yNyAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjQyNDIKKyAgICAgICAgCisgICAgICAgIHNldEN1cnNvcigpLCBhbmQg cmVzZXRDdXJzb3JSZWN0cygpIG9uIFRpZ2VyLCB3ZXJlIHVzaW5nIGdsb2JhbCwgbm90IGxvY2Fs CisgICAgICAgIGNvb3JkaW5hdGVzIGZvciBlbGVtZW50QXRQb2ludDoKKyAgICAgICAgCisgICAg ICAgICogV2ViVmlldy9XZWJIVE1MVmlldy5tbToKKyAgICAgICAgKHJlc2V0Q3Vyc29yUmVjdHMp OgorICAgICAgICAoc2V0Q3Vyc29yKToKKwogMjAwOS0wMi0yNiAgQWRlbGUgUGV0ZXJzb24gIDxh ZGVsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYgR2FyZW4uCmRpZmYg LS1naXQgYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0gYi9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViSFRNTFZpZXcubW0KaW5kZXggYWEwMDk0Yy4uY2M3OWJkYSAxMDA2NDQKLS0tIGEv V2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCisrKyBiL1dlYktpdC9tYWMvV2ViVmll dy9XZWJIVE1MVmlldy5tbQpAQCAtMTQ1LDcgKzE0NSw3IEBAIHN0YXRpYyB2b2lkIHJlc2V0Q3Vy c29yUmVjdHMoTlNXaW5kb3cqIHNlbGYsIFNFTCBjbWQpCiAgICAgaWYgKFt2aWV3IGlzS2luZE9m Q2xhc3M6W1dlYkhUTUxWaWV3IGNsYXNzXV0pIHsKICAgICAgICAgV2ViSFRNTFZpZXcgKmh0bWxW aWV3ID0gKFdlYkhUTUxWaWV3Kil2aWV3OwogICAgICAgICBOU1BvaW50IGxvY2FsUG9pbnQgPSBb aHRtbFZpZXcgY29udmVydFBvaW50OnBvaW50IGZyb21WaWV3Om5pbF07Ci0gICAgICAgIE5TRGlj dGlvbmFyeSAqZGljdCA9IFtodG1sVmlldyBlbGVtZW50QXRQb2ludDpwb2ludCBhbGxvd1NoYWRv d0NvbnRlbnQ6Tk9dOworICAgICAgICBOU0RpY3Rpb25hcnkgKmRpY3QgPSBbaHRtbFZpZXcgZWxl bWVudEF0UG9pbnQ6bG9jYWxQb2ludCBhbGxvd1NoYWRvd0NvbnRlbnQ6Tk9dOwogICAgICAgICBE T01FbGVtZW50ICplbGVtZW50ID0gW2RpY3Qgb2JqZWN0Rm9yS2V5OldlYkVsZW1lbnRET01Ob2Rl S2V5XTsKICAgICAgICAgaWYgKCFbZWxlbWVudCBpc0tpbmRPZkNsYXNzOltET01IVE1MQXBwbGV0 RWxlbWVudCBjbGFzc11dICYmICFbZWxlbWVudCBpc0tpbmRPZkNsYXNzOltET01IVE1MT2JqZWN0 RWxlbWVudCBjbGFzc11dICYmCiAgICAgICAgICAgICAhW2VsZW1lbnQgaXNLaW5kT2ZDbGFzczpb RE9NSFRNTEVtYmVkRWxlbWVudCBjbGFzc11dKQpAQCAtMTY3LDcgKzE2Nyw3IEBAIHN0YXRpYyB2 b2lkIHNldEN1cnNvcihOU1dpbmRvdyogc2VsZiwgU0VMIGNtZCwgTlNQb2ludCBwb2ludCkKICAg ICBpZiAoW3ZpZXcgaXNLaW5kT2ZDbGFzczpbV2ViSFRNTFZpZXcgY2xhc3NdXSkgewogICAgICAg ICBXZWJIVE1MVmlldyAqaHRtbFZpZXcgPSAoV2ViSFRNTFZpZXcqKXZpZXc7CiAgICAgICAgIE5T UG9pbnQgbG9jYWxQb2ludCA9IFtodG1sVmlldyBjb252ZXJ0UG9pbnQ6cG9pbnQgZnJvbVZpZXc6 bmlsXTsKLSAgICAgICAgTlNEaWN0aW9uYXJ5ICpkaWN0ID0gW2h0bWxWaWV3IGVsZW1lbnRBdFBv aW50OnBvaW50IGFsbG93U2hhZG93Q29udGVudDpOT107CisgICAgICAgIE5TRGljdGlvbmFyeSAq ZGljdCA9IFtodG1sVmlldyBlbGVtZW50QXRQb2ludDpsb2NhbFBvaW50IGFsbG93U2hhZG93Q29u dGVudDpOT107CiAgICAgICAgIERPTUVsZW1lbnQgKmVsZW1lbnQgPSBbZGljdCBvYmplY3RGb3JL ZXk6V2ViRWxlbWVudERPTU5vZGVLZXldOwogICAgICAgICBpZiAoIVtlbGVtZW50IGlzS2luZE9m Q2xhc3M6W0RPTUhUTUxBcHBsZXRFbGVtZW50IGNsYXNzXV0gJiYgIVtlbGVtZW50IGlzS2luZE9m Q2xhc3M6W0RPTUhUTUxPYmplY3RFbGVtZW50IGNsYXNzXV0gJiYKICAgICAgICAgICAgICFbZWxl bWVudCBpc0tpbmRPZkNsYXNzOltET01IVE1MRW1iZWRFbGVtZW50IGNsYXNzXV0pCg==