242409 2022-07-06 12:54:41 -0700 [WPE][GTK] Decide on conditional name for new API versions 2022-07-14 15:11:18 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 210100 1 mcatanzaro webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1881051 0 mcatanzaro 2022-07-06 12:54:41 -0700 I'm trying to decide on a single conditional I can use to distinguish between new API and old API. Example usage: #if PLATFORM(GTK) && WEBKITGTK_API_VERSION >= 5.0 || PLATFORM(WPE) && WPE_API_VERSION >= 2.0 // do new thing #else // do old thing #endif Except that's too verbose, so we should have something much shorter, ideally with no && or || at all. #if ENABLE(NEW_GLIB_APIS) #if ENABLE(MODERN_WPE_GTK_API) #if ENABLE(2022_API_VERSION) #if ENABLE(2022_GLIB_API) #if ENABLE(SOME_CODEWORD) Ideas and/or votes welcome. This is a bikeshedding bug report. 1881054 1 mcatanzaro 2022-07-06 12:57:00 -0700 Another option, which works only if we drop older WPE API versions (see bug #242407): #if WEBKITGTK_API_VERSION >= 5.0 || PLATFORM(WPE) #if PLATFORM(WPE) WEBKITGTK_API_VERSION >= 5.0 which is slightly longer, but not too long. 1883127 2 mcatanzaro 2022-07-13 10:01:04 -0700 (In reply to Michael Catanzaro from comment #0) > #if ENABLE(2022_GLIB_API) If nobody has a preference, I'll probably try this.